From: "Gustavo A. R. Silva" <garsilva@embeddedor.com>
To: Pablo Neira Ayuso <pablo@netfilter.org>
Cc: Jozsef Kadlecsik <kadlec@blackhole.kfki.hu>,
Florian Westphal <fw@strlen.de>,
"David S. Miller" <davem@davemloft.net>,
Wensong Zhang <wensong@linux-vs.org>,
Simon Horman <horms@verge.net.au>, Julian Anastasov <ja@ssi.bg>,
netfilter-devel@vger.kernel.org, coreteam@netfilter.org,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
lvs-devel@vger.kernel.org
Subject: Re: [PATCH] netfilter: mark expected switch fall-throughs
Date: Tue, 07 Nov 2017 07:30:45 -0600 [thread overview]
Message-ID: <20171107073045.Horde.fHvUlYL1jmnkY_bpuXRFqCR@gator4166.hostgator.com> (raw)
In-Reply-To: <20171107010729.GA23302@salvia>
Hello Pablo,
Quoting Pablo Neira Ayuso <pablo@netfilter.org>:
> Hi Gustavo,
>
> On Thu, Oct 19, 2017 at 09:06:16AM -0500, Gustavo A. R. Silva wrote:
>> diff --git a/net/netfilter/ipset/ip_set_core.c
>> b/net/netfilter/ipset/ip_set_core.c
>> index cf84f7b..72f654a 100644
>> --- a/net/netfilter/ipset/ip_set_core.c
>> +++ b/net/netfilter/ipset/ip_set_core.c
>> @@ -1386,7 +1386,8 @@ ip_set_dump_start(struct sk_buff *skb, struct
>> netlink_callback *cb)
>> goto next_set;
>> if (set->variant->uref)
>> set->variant->uref(set, cb, true);
>> - /* Fall through and add elements */
>> + /* add elements */
>> + /* fall through */
>
> Just replace this comment by /* fall through */, I think it's enough
> to remember that this is intentional.
OK. Will do.
>
>> default:
>> rcu_read_lock_bh();
>> ret = set->variant->list(set, skb, cb);
> [...]
>> diff --git a/net/netfilter/x_tables.c b/net/netfilter/x_tables.c
>> index d8571f4..fa5cdd0 100644
>> --- a/net/netfilter/x_tables.c
>> +++ b/net/netfilter/x_tables.c
>> @@ -1382,7 +1382,8 @@ static void *xt_mttg_seq_next(struct seq_file
>> *seq, void *v, loff_t *ppos,
>> trav->curr = trav->curr->next;
>> if (trav->curr != trav->head)
>> break;
>> - /* fallthru, _stop will unlock */
>> + /* _stop will unlock */
>
> Same thing here, thanks!
OK. I will send v2 shortly.
Thanks for your comments
--
Gustavo A. R. Silva
next prev parent reply other threads:[~2017-11-07 13:30 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-19 14:06 [PATCH] netfilter: mark expected switch fall-throughs Gustavo A. R. Silva
2017-11-07 1:07 ` Pablo Neira Ayuso
2017-11-07 13:30 ` Gustavo A. R. Silva [this message]
2017-11-07 14:19 ` [PATCH v2] " Gustavo A. R. Silva
2017-11-13 7:59 ` Simon Horman
2017-11-13 12:46 ` Pablo Neira Ayuso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171107073045.Horde.fHvUlYL1jmnkY_bpuXRFqCR@gator4166.hostgator.com \
--to=garsilva@embeddedor.com \
--cc=coreteam@netfilter.org \
--cc=davem@davemloft.net \
--cc=fw@strlen.de \
--cc=horms@verge.net.au \
--cc=ja@ssi.bg \
--cc=kadlec@blackhole.kfki.hu \
--cc=linux-kernel@vger.kernel.org \
--cc=lvs-devel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
--cc=wensong@linux-vs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).