linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Herbert Xu <herbert@gondor.apana.org.au>
To: Dmitry Vyukov <dvyukov@google.com>
Cc: syzbot 
	<bot+413384116f7f7dab7903d54c53fc4af6a4441965@syzkaller.appspotmail.com>,
	David Miller <davem@davemloft.net>,
	LKML <linux-kernel@vger.kernel.org>,
	netdev <netdev@vger.kernel.org>,
	Steffen Klassert <steffen.klassert@secunet.com>,
	syzkaller-bugs@googlegroups.com
Subject: Re: kernel BUG at net/key/af_key.c:LINE!
Date: Fri, 10 Nov 2017 13:04:59 +1100	[thread overview]
Message-ID: <20171110020459.GA22329@gondor.apana.org.au> (raw)
In-Reply-To: <20171109113857.GA15280@gondor.apana.org.au>

On Thu, Nov 09, 2017 at 10:38:57PM +1100, Herbert Xu wrote:
> 
> The xfrm code path is meant to forbid the creation of such a policy.
> I don't currently see how this is bypassing that check.  But
> clearly it has found a way through the check since it's crashing.

By castrating the reproducer to not perform a pfkey dump I have
captured the corrupted policy via xfrm:

src ???/0 dst ???/0 uid 0
        socket in action allow index 2083 priority 0 ptype main share any flag  (0x00000000)
        lifetime config:
          limit: soft 0(bytes), hard 0(bytes)
          limit: soft 0(packets), hard 0(packets)
          expire add: soft 0(sec), hard 0(sec)
          expire use: soft 0(sec), hard 0(sec)
        lifetime current:
          0(bytes), 0(packets)
          add 2017-11-10 09:58:17 use 2017-11-10 09:58:20
        tmpl src ac14:bb:: dst ::
                proto 0 spi 0x00000000(0) reqid 0(0x00000000) mode transport
                level 5 share any 
                enc-mask 00000000 auth-mask 00000000 comp-mask 00000000

For comparison here is a good policy that was also created by the
reproducer:

src fe80::bb/0 dst ::/0 uid 0
        socket in action allow index 2083 priority 0 ptype main share any flag  (0x00000000)
        lifetime config:
          limit: soft 0(bytes), hard 0(bytes)
          limit: soft 0(packets), hard 0(packets)
          expire add: soft 0(sec), hard 0(sec)
          expire use: soft 0(sec), hard 0(sec)
        lifetime current:
          0(bytes), 0(packets)
          add 2017-11-10 09:58:17 use 2017-11-10 09:58:17
        tmpl src ac14:bb:: dst ::
                proto 0 spi 0x00000000(0) reqid 0(0x00000000) mode transport
                level 5 share any 
                enc-mask 00000000 auth-mask 00000000 comp-mask 00000000

Cheers,
-- 
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

  reply	other threads:[~2017-11-10  2:05 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-10-24 15:08 kernel BUG at net/key/af_key.c:LINE! syzbot
2017-10-24 15:10 ` Dmitry Vyukov
2017-11-08  7:47   ` Herbert Xu
2017-11-08  7:59     ` Dmitry Vyukov
2017-11-08  8:00       ` Dmitry Vyukov
2017-11-09 11:38       ` Herbert Xu
2017-11-10  2:04         ` Herbert Xu [this message]
2017-11-10  2:11           ` Herbert Xu
2017-11-10  2:30             ` Herbert Xu
2017-11-10  3:14               ` Herbert Xu
2017-11-15 11:29                 ` Steffen Klassert
2017-12-03 20:28                   ` Eric Biggers

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171110020459.GA22329@gondor.apana.org.au \
    --to=herbert@gondor.apana.org.au \
    --cc=bot+413384116f7f7dab7903d54c53fc4af6a4441965@syzkaller.appspotmail.com \
    --cc=davem@davemloft.net \
    --cc=dvyukov@google.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=steffen.klassert@secunet.com \
    --cc=syzkaller-bugs@googlegroups.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).