From: Guenter Roeck <linux@roeck-us.net>
To: Eddie James <eajames@linux.vnet.ibm.com>
Cc: linux-hwmon@vger.kernel.org, linux-kernel@vger.kernel.org,
jdelvare@suse.com, mspinler@linux.vnet.ibm.com, joel@jms.id.au,
"Edward A. James" <eajames@us.ibm.com>
Subject: Re: [PATCH 1/2] hwmon: (pmbus): Export pmbus device debugfs directory entry
Date: Thu, 7 Dec 2017 12:42:34 -0800 [thread overview]
Message-ID: <20171207204234.GA7736@roeck-us.net> (raw)
In-Reply-To: <1512676238-8020-2-git-send-email-eajames@linux.vnet.ibm.com>
On Thu, Dec 07, 2017 at 01:50:37PM -0600, Eddie James wrote:
> From: "Edward A. James" <eajames@us.ibm.com>
>
> Pmbus client drivers, if they want to use debugfs, should use the same
> root directory as the pmbus debugfs entries are using. Therefore, export
> the device dentry for the pmbus client.
>
> Signed-off-by: Edward A. James <eajames@us.ibm.com>
> ---
> drivers/hwmon/pmbus/pmbus.h | 2 ++
> drivers/hwmon/pmbus/pmbus_core.c | 7 +++++++
> 2 files changed, 9 insertions(+)
>
> diff --git a/drivers/hwmon/pmbus/pmbus.h b/drivers/hwmon/pmbus/pmbus.h
> index d39d506..1d24397 100644
> --- a/drivers/hwmon/pmbus/pmbus.h
> +++ b/drivers/hwmon/pmbus/pmbus.h
> @@ -461,4 +461,6 @@ int pmbus_get_fan_rate_cached(struct i2c_client *client, int page, int id,
> enum pmbus_fan_mode mode);
> int pmbus_update_fan(struct i2c_client *client, int page, int id,
> u8 config, u8 mask, u16 command);
> +struct dentry *pmbus_get_debugfs_dir(struct i2c_client *client);
> +
> #endif /* PMBUS_H */
> diff --git a/drivers/hwmon/pmbus/pmbus_core.c b/drivers/hwmon/pmbus/pmbus_core.c
> index 99ab39f..9abd382 100644
> --- a/drivers/hwmon/pmbus/pmbus_core.c
> +++ b/drivers/hwmon/pmbus/pmbus_core.c
> @@ -2381,6 +2381,13 @@ int pmbus_do_remove(struct i2c_client *client)
> }
> EXPORT_SYMBOL_GPL(pmbus_do_remove);
>
> +struct dentry *pmbus_get_debugfs_dir(struct i2c_client *client)
> +{
> + struct pmbus_data *data = i2c_get_clientdata(client);
> +
> + return data->debugfs;
> +}
EXPORT_SYMBOL_GPL(pmbus_get_debugfs_dir);
> +
> static int __init pmbus_core_init(void)
> {
> pmbus_debugfs_dir = debugfs_create_dir("pmbus", NULL);
> --
> 1.8.3.1
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-hwmon" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2017-12-07 20:42 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-07 19:50 [PATCH 0/2] hwmon (pmbus): cffps: Add debugfs entries Eddie James
2017-12-07 19:50 ` [PATCH 1/2] hwmon: (pmbus): Export pmbus device debugfs directory entry Eddie James
2017-12-07 20:42 ` Guenter Roeck [this message]
2017-12-07 19:50 ` [PATCH 2/2] hwmon (pmbus): cffps: Add debugfs entries Eddie James
2017-12-07 20:53 ` Guenter Roeck
2017-12-07 22:19 ` Eddie James
2017-12-07 23:18 ` Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171207204234.GA7736@roeck-us.net \
--to=linux@roeck-us.net \
--cc=eajames@linux.vnet.ibm.com \
--cc=eajames@us.ibm.com \
--cc=jdelvare@suse.com \
--cc=joel@jms.id.au \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mspinler@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).