From mboxrd@z Thu Jan 1 00:00:00 1970 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934012AbeAJLpt (ORCPT + 1 other); Wed, 10 Jan 2018 06:45:49 -0500 Received: from mail.skyhub.de ([5.9.137.197]:55952 "EHLO mail.skyhub.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933212AbeAJLpm (ORCPT ); Wed, 10 Jan 2018 06:45:42 -0500 Date: Wed, 10 Jan 2018 12:45:28 +0100 From: Borislav Petkov To: David Woodhouse Cc: Linus Torvalds , Andi Kleen , Thomas Gleixner , the arch/x86 maintainers , Linux Kernel Mailing List , Paul Turner , Andrew Lutomirski , Peter Zijlstra , Tom Lendacky , Tim Chen , Greg Kroah-Hartman , Dave Hansen , Jiri Kosina , Andi Kleen Subject: Re: [PATCH] x86/alternatives: Fix optimize_nops() checking Message-ID: <20180110114528.4ceo5akuen2wnjx2@pd.tnic> References: <20180110003139.10531-1-andi@firstfloor.org> <1515568506.22302.72.camel@infradead.org> <1515578735.22302.91.camel@infradead.org> <20180110112815.mgciyf5acwacphkq@pd.tnic> <1515584201.22302.113.camel@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <1515584201.22302.113.camel@infradead.org> User-Agent: NeoMutt/20170609 (1.8.3) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Return-Path: On Wed, Jan 10, 2018 at 11:36:41AM +0000, David Woodhouse wrote: > That fixed and understood, I shall remove the offending NOPs anyway, > because aligning instructions in the *altinstr* section is entirely > pointless as they might still not be aligned when they get copied into > place anyway. Yap. It was still a good experiment because we found this shortcoming! :-) Thx. -- Regards/Gruss, Boris. Good mailing practices for 400: avoid top-posting and trim the reply.