From: "Tobin C. Harding" <me@tobin.cc>
To: Randy Dunlap <rdunlap@infradead.org>
Cc: Steven Rostedt <rostedt@goodmis.org>,
Adam Borowski <kilobyte@angband.pl>,
Petr Mladek <pmladek@suse.com>,
Sergey Senozhatsky <sergey.senozhatsky@gmail.com>,
linux-kernel@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>,
Joe Perches <joe@perches.com>, Kees Cook <keescook@chromium.org>,
"Roberts, William C" <william.c.roberts@intel.com>,
Linus Torvalds <torvalds@linux-foundation.org>,
David Laight <David.Laight@ACULAB.COM>,
Geert Uytterhoeven <geert@linux-m68k.org>
Subject: Re: [PATCH] vsprintf: avoid misleading "(null)" for %px
Date: Tue, 6 Feb 2018 07:19:01 +1100 [thread overview]
Message-ID: <20180205201901.GR29988@eros> (raw)
In-Reply-To: <49fbcc8b-9522-f19c-d51c-d0059445abdc@infradead.org>
On Mon, Feb 05, 2018 at 09:36:03AM -0800, Randy Dunlap wrote:
> On 02/05/2018 08:49 AM, Steven Rostedt wrote:
> > On Mon, 5 Feb 2018 16:22:19 +0100
> > Adam Borowski <kilobyte@angband.pl> wrote:
> >
> >> My change touches %px only, where your concern doesn't apply.
> >>
> >> You're right, though, when it comes to %pK:
> >> printk("%%pK: %pK, %%px: %px\n", 0, 0);
> >> says
> >> %pK: 00000000ba8bdc0a, %px: 0000000000000000
> >>
> >> So what should we do? Avoid hashing 0? Print a special value?
> >
> > My personal opinion is that NULL should stay NULL and not be hashed.
> > What security issue could be leaked by a NULL? I'm not a security
> > person, that's a real question.
>
> Agree.
While these views seem valid I don't think we are going to get much
love trying to change %pK to give a smidgen more information when %pK is
arguably out of favour :)
Tobin
next prev parent reply other threads:[~2018-02-05 20:19 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-04 17:45 [PATCH] vsprintf: avoid misleading "(null)" for %px Adam Borowski
2018-02-05 9:44 ` Petr Mladek
2018-02-05 10:03 ` Tobin C. Harding
2018-02-05 15:22 ` Adam Borowski
2018-02-05 16:49 ` Steven Rostedt
2018-02-05 17:36 ` Randy Dunlap
2018-02-05 20:19 ` Tobin C. Harding [this message]
2018-02-05 18:57 ` Kees Cook
2018-02-05 20:15 ` Tobin C. Harding
2018-02-05 20:32 ` Kees Cook
2018-02-05 20:58 ` Adam Borowski
2018-02-05 22:22 ` Tobin C. Harding
2018-02-06 18:43 ` Andy Shevchenko
2018-02-07 15:03 ` Petr Mladek
2018-02-07 15:11 ` Geert Uytterhoeven
2018-02-07 15:41 ` Petr Mladek
2018-02-07 15:48 ` Geert Uytterhoeven
2018-02-08 15:29 ` Andy Shevchenko
2018-02-09 12:03 ` Petr Mladek
2018-02-14 14:35 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180205201901.GR29988@eros \
--to=me@tobin.cc \
--cc=David.Laight@ACULAB.COM \
--cc=akpm@linux-foundation.org \
--cc=geert@linux-m68k.org \
--cc=joe@perches.com \
--cc=keescook@chromium.org \
--cc=kilobyte@angband.pl \
--cc=linux-kernel@vger.kernel.org \
--cc=pmladek@suse.com \
--cc=rdunlap@infradead.org \
--cc=rostedt@goodmis.org \
--cc=sergey.senozhatsky@gmail.com \
--cc=torvalds@linux-foundation.org \
--cc=william.c.roberts@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).