From: "Marc-André Lureau" <marcandre.lureau@redhat.com>
To: linux-kernel@vger.kernel.org
Cc: slp@redhat.com, bhe@redhat.com, mst@redhat.com, somlo@cmu.edu,
xiaolong.ye@intel.com,
"Marc-André Lureau" <marcandre.lureau@redhat.com>
Subject: [PATCH v15 07/11] fw_cfg: remove inline from fw_cfg_read_blob()
Date: Thu, 15 Feb 2018 22:33:08 +0100 [thread overview]
Message-ID: <20180215213312.29234-8-marcandre.lureau@redhat.com> (raw)
In-Reply-To: <20180215213312.29234-1-marcandre.lureau@redhat.com>
The function is not small and getting bigger.
Let the compiler decide instead. No profiling done, hopefully
unnecessary.
Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
---
drivers/firmware/qemu_fw_cfg.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/firmware/qemu_fw_cfg.c b/drivers/firmware/qemu_fw_cfg.c
index 805372e8e50d..f6f90bef604c 100644
--- a/drivers/firmware/qemu_fw_cfg.c
+++ b/drivers/firmware/qemu_fw_cfg.c
@@ -59,8 +59,8 @@ static void fw_cfg_sel_endianness(u16 key)
}
/* read chunk of given fw_cfg blob (caller responsible for sanity-check) */
-static inline void fw_cfg_read_blob(u16 key,
- void *buf, loff_t pos, size_t count)
+static void fw_cfg_read_blob(u16 key,
+ void *buf, loff_t pos, size_t count)
{
u32 glk = -1U;
acpi_status status;
--
2.16.1.73.g5832b7e9f2
next prev parent reply other threads:[~2018-02-15 21:33 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-15 21:33 [PATCH v15 00/11] fw_cfg: add DMA operations & etc/vmcoreinfo support Marc-André Lureau
2018-02-15 21:33 ` [PATCH v15 01/11] crash: export paddr_vmcoreinfo_note() Marc-André Lureau
2018-02-15 21:33 ` [PATCH v15 02/11] fw_cfg: add a public uapi header Marc-André Lureau
2018-02-27 0:06 ` Michael S. Tsirkin
2018-02-28 11:50 ` Marc-André Lureau
2018-02-15 21:33 ` [PATCH v15 03/11] fw_cfg: fix sparse warnings in fw_cfg_sel_endianness() Marc-André Lureau
2018-02-15 21:33 ` [PATCH v15 04/11] fw_cfg: fix sparse warnings with fw_cfg_file Marc-André Lureau
2018-02-15 21:33 ` [PATCH v15 05/11] fw_cfg: fix sparse warning reading FW_CFG_ID Marc-André Lureau
2018-02-15 21:33 ` [PATCH v15 06/11] fw_cfg: fix sparse warnings around FW_CFG_FILE_DIR read Marc-André Lureau
2018-02-15 21:33 ` Marc-André Lureau [this message]
2018-02-15 21:33 ` [PATCH v15 08/11] fw_cfg: handle fw_cfg_read_blob() error Marc-André Lureau
2018-02-27 0:20 ` Michael S. Tsirkin
2018-02-28 11:49 ` Marc-André Lureau
2018-02-28 13:01 ` Gabriel Somlo
2018-02-28 15:32 ` Michael S. Tsirkin
2018-02-28 23:25 ` Gabriel Somlo
2018-02-28 23:58 ` Michael S. Tsirkin
2018-02-28 23:58 ` Michael S. Tsirkin
2018-03-01 0:49 ` Gabriel Somlo
2018-03-01 0:35 ` Gabriel Somlo
2018-02-15 21:33 ` [PATCH v15 09/11] fw_cfg: add DMA register Marc-André Lureau
2018-02-15 21:33 ` [PATCH v15 10/11] fw_cfg: write vmcoreinfo details Marc-André Lureau
2018-02-27 0:28 ` Michael S. Tsirkin
2018-02-28 12:22 ` Marc-André Lureau
2018-02-28 15:34 ` Michael S. Tsirkin
2018-02-15 21:33 ` [PATCH v15 11/11] RFC: fw_cfg: do DMA read operation Marc-André Lureau
2018-02-27 0:04 ` Michael S. Tsirkin
2018-02-28 12:27 ` Marc-André Lureau
2018-02-28 15:35 ` Michael S. Tsirkin
2018-02-28 15:41 ` Marc-André Lureau
2018-02-28 15:48 ` Michael S. Tsirkin
2018-02-28 16:00 ` Marc-André Lureau
2018-02-28 17:16 ` Michael S. Tsirkin
2018-02-28 17:17 ` Michael S. Tsirkin
2018-02-28 17:22 ` Marc-André Lureau
2018-02-27 0:29 ` [PATCH v15 00/11] fw_cfg: add DMA operations & etc/vmcoreinfo support Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180215213312.29234-8-marcandre.lureau@redhat.com \
--to=marcandre.lureau@redhat.com \
--cc=bhe@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mst@redhat.com \
--cc=slp@redhat.com \
--cc=somlo@cmu.edu \
--cc=xiaolong.ye@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).