From: Ingo Molnar <mingo@kernel.org>
To: Peter Zijlstra <peterz@infradead.org>
Cc: Davidlohr Bueso <dave@stgolabs.net>,
efault@gmx.de, rostedt@goodmis.org, matt@codeblueprint.co.uk,
linux-kernel@vger.kernel.org, Davidlohr Bueso <dbueso@suse.de>
Subject: Re: [PATCH] sched/rt: Fix rq->clock_update_flags < RQCF_ACT_SKIP warning
Date: Thu, 5 Apr 2018 09:21:05 +0200 [thread overview]
Message-ID: <20180405072105.egwq2pg26np3l7pb@gmail.com> (raw)
In-Reply-To: <20180404163910.GL4043@hirez.programming.kicks-ass.net>
* Peter Zijlstra <peterz@infradead.org> wrote:
> On Wed, Apr 04, 2018 at 09:15:39AM -0700, Davidlohr Bueso wrote:
> > On Mon, 02 Apr 2018, Davidlohr Bueso wrote:
> >
> > > The case for the rt task throttling (which this workload also hits) can be ignored in
> > > that the skip_update call is actually bogus and quite the contrary (the request bits
> > > are removed/reverted).
> >
> > While at it, how about this trivial patch?
> >
> > ----8<--------------------------------------------------------
> > [PATCH 2/1] sched: Simplify helpers for rq clock update skip requests
> >
> > By renaming the functions we can get rid of the skip parameter
> > and have better code redability. It makes zero sense to have
> > things such as:
> >
> > rq_clock_skip_update(rq, false)
> >
> > When the skip request is in fact not going to happen. Ever. Rename
> > things such that we end up with:
> >
> > rq_clock_skip_update(rq)
> > rq_clock_cancel_skipupdate(rq)
> >
> > Signed-off-by: Davidlohr Bueso <dbueso@suse.de>
>
> Works for me :-)
>
> Acked-by: Peter Zijlstra (Intel) <peterz@infradead.org>
I have applied both patches, thanks guys!
Ingo
next prev parent reply other threads:[~2018-04-05 7:21 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-02 16:49 [PATCH] sched/rt: Fix rq->clock_update_flags < RQCF_ACT_SKIP warning Davidlohr Bueso
2018-04-03 12:39 ` Matt Fleming
2018-04-04 15:27 ` Peter Zijlstra
2018-04-04 16:15 ` Davidlohr Bueso
2018-04-04 16:39 ` Peter Zijlstra
2018-04-05 7:21 ` Ingo Molnar [this message]
2018-04-05 9:17 ` [tip:sched/urgent] sched/core: Simplify helpers for rq clock update skip requests tip-bot for Davidlohr Bueso
2018-04-05 9:16 ` [tip:sched/urgent] sched/rt: Fix rq->clock_update_flags < RQCF_ACT_SKIP warning tip-bot for Davidlohr Bueso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180405072105.egwq2pg26np3l7pb@gmail.com \
--to=mingo@kernel.org \
--cc=dave@stgolabs.net \
--cc=dbueso@suse.de \
--cc=efault@gmx.de \
--cc=linux-kernel@vger.kernel.org \
--cc=matt@codeblueprint.co.uk \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).