From: Michal Hocko <mhocko@kernel.org>
To: Matthew Wilcox <willy@infradead.org>
Cc: Joel Fernandes <joelaf@google.com>,
Steven Rostedt <rostedt@goodmis.org>,
Zhaoyang Huang <huangzhaoyang@gmail.com>,
Ingo Molnar <mingo@kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
kernel-patch-test@lists.linaro.org,
Andrew Morton <akpm@linux-foundation.org>,
"open list:MEMORY MANAGEMENT" <linux-mm@kvack.org>,
Vlastimil Babka <vbabka@suse.cz>
Subject: Re: [PATCH v1] kernel/trace:check the val against the available mem
Date: Thu, 5 Apr 2018 16:27:49 +0200 [thread overview]
Message-ID: <20180405142749.GL6312@dhcp22.suse.cz> (raw)
In-Reply-To: <20180405142258.GA28128@bombadil.infradead.org>
On Thu 05-04-18 07:22:58, Matthew Wilcox wrote:
> On Wed, Apr 04, 2018 at 09:12:52PM -0700, Joel Fernandes wrote:
> > On Wed, Apr 4, 2018 at 7:58 PM, Matthew Wilcox <willy@infradead.org> wrote:
> > > On Wed, Apr 04, 2018 at 11:47:30AM -0400, Steven Rostedt wrote:
> > >> I originally was going to remove the RETRY_MAYFAIL, but adding this
> > >> check (at the end of the loop though) appears to have OOM consistently
> > >> kill this task.
> > >>
> > >> I still like to keep RETRY_MAYFAIL, because it wont trigger OOM if
> > >> nothing comes in and tries to do an allocation, but instead will fail
> > >> nicely with -ENOMEM.
> > >
> > > I still don't get why you want RETRY_MAYFAIL. You know that tries
> > > *harder* to allocate memory than plain GFP_KERNEL does, right? And
> > > that seems like the exact opposite of what you want.
> >
> > No. We do want it to try harder but not if its already setup for failure.
>
> I understand you don't want GFP_NORETRY. But why is it more important for
> this allocation to succeed than other normal GFP_KERNEL allocations?
I guess they simply want a failure rather than OOM even when they can
shoot themselves into head by using oom_origin. It is still quite ugly
to see OOM report...
--
Michal Hocko
SUSE Labs
next prev parent reply other threads:[~2018-04-05 14:27 UTC|newest]
Thread overview: 64+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-29 10:41 [PATCH v1] kernel/trace:check the val against the available mem Zhaoyang Huang
2018-03-29 16:05 ` Steven Rostedt
2018-03-30 3:32 ` Zhaoyang Huang
2018-03-30 14:07 ` Steven Rostedt
2018-03-30 6:53 ` [Kernel-patch-test] " kbuild test robot
2018-03-30 6:54 ` kbuild test robot
2018-03-30 14:20 ` Steven Rostedt
2018-03-30 16:37 ` Joel Fernandes
2018-03-30 19:10 ` Steven Rostedt
2018-03-30 20:37 ` Joel Fernandes
2018-03-30 20:53 ` Matthew Wilcox
2018-03-30 21:30 ` Steven Rostedt
2018-03-30 21:42 ` Steven Rostedt
2018-03-30 23:38 ` Joel Fernandes
2018-03-31 1:41 ` Steven Rostedt
2018-03-31 2:18 ` Matthew Wilcox
2018-03-31 3:07 ` Steven Rostedt
2018-03-31 5:44 ` Joel Fernandes
2018-04-02 0:52 ` Zhaoyang Huang
2018-04-03 11:06 ` Michal Hocko
2018-04-03 11:51 ` Steven Rostedt
2018-04-03 12:16 ` Michal Hocko
2018-04-03 12:23 ` Steven Rostedt
2018-04-03 12:35 ` Michal Hocko
2018-04-03 13:32 ` Steven Rostedt
2018-04-03 13:56 ` Michal Hocko
2018-04-03 14:17 ` Steven Rostedt
2018-04-03 16:11 ` Michal Hocko
2018-04-03 16:59 ` Steven Rostedt
2018-04-03 22:56 ` Steven Rostedt
2018-04-04 6:20 ` Michal Hocko
2018-04-04 12:21 ` Joel Fernandes
2018-04-04 12:59 ` Steven Rostedt
2018-04-04 14:10 ` Michal Hocko
2018-04-04 14:25 ` Steven Rostedt
2018-04-04 14:42 ` Michal Hocko
2018-04-04 15:04 ` Steven Rostedt
2018-04-04 15:27 ` Michal Hocko
2018-04-04 15:38 ` Steven Rostedt
2018-04-04 2:58 ` Zhaoyang Huang
2018-04-04 6:23 ` Michal Hocko
2018-04-04 9:29 ` Zhaoyang Huang
2018-04-04 14:11 ` Steven Rostedt
2018-04-04 14:23 ` Michal Hocko
2018-04-04 14:31 ` Steven Rostedt
2018-04-04 14:47 ` Michal Hocko
2018-04-04 15:47 ` Steven Rostedt
2018-04-05 2:58 ` Matthew Wilcox
2018-04-05 4:12 ` Joel Fernandes
2018-04-05 14:22 ` Matthew Wilcox
2018-04-05 14:27 ` Michal Hocko [this message]
2018-04-05 14:34 ` Steven Rostedt
2018-04-05 15:13 ` Matthew Wilcox
2018-04-05 15:32 ` Michal Hocko
2018-04-05 16:15 ` Matthew Wilcox
2018-04-05 18:54 ` Michal Hocko
2018-04-05 20:15 ` __GFP_LOW Matthew Wilcox
2018-04-06 6:09 ` __GFP_LOW Michal Hocko
2018-04-08 4:27 ` __GFP_LOW Matthew Wilcox
2018-04-09 7:34 ` __GFP_LOW Michal Hocko
2018-04-09 15:51 ` __GFP_LOW Matthew Wilcox
2018-04-09 18:14 ` __GFP_LOW Michal Hocko
[not found] ` <CA+JonM0HG9kWb6-0iyDQ8UMxTeR-f=+ZL89t5DvvDULDC8Sfyw@mail.gmail.com>
2018-04-10 12:19 ` __GFP_LOW Matthew Wilcox
2018-04-05 14:30 ` [PATCH v1] kernel/trace:check the val against the available mem Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180405142749.GL6312@dhcp22.suse.cz \
--to=mhocko@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=huangzhaoyang@gmail.com \
--cc=joelaf@google.com \
--cc=kernel-patch-test@lists.linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mingo@kernel.org \
--cc=rostedt@goodmis.org \
--cc=vbabka@suse.cz \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).