From: Benson Leung <bleung@google.com>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: linux-input@vger.kernel.org, Benson Leung <bleung@chromium.org>,
Nick Dyer <nick@shmanahar.org>, Olof Johansson <olof@lixom.net>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 00/14] chrome_laptop: stop being a platform driver
Date: Tue, 10 Apr 2018 22:44:25 -0700 [thread overview]
Message-ID: <20180411054425.GB123734@decatoncale.mtv.corp.google.com> (raw)
In-Reply-To: <20180320223138.234724-1-dmitry.torokhov@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 2471 bytes --]
Hi Dmitry,
On Tue, Mar 20, 2018 at 03:31:24PM -0700, Dmitry Torokhov wrote:
> Hi,
>
> This series is a combination of Atmel touchscreen driver stopping using
> platform data and moving over to generic device properties, and
> chromeos-laptop switching from being platform driver, which is the wrong
> abstraction for it, and moving to using i2c bis notifier. Switching from
> platform driver to the notifiers allows us to get rid of the ugly code that
> manually tries to handle deferrals in case i2c bus is not ready at the time
> we start initializing the module.
>
> Thanks!
This series is in next now. I will roll up a pull request for v4.17 soon.
Thanks!
Benson
>
> Changes v1->v2:
>
> - switched suspend mode handling to use DMI quirk. We'll clean it up properly
> in the Atmel driver later, for now we just want to untangle Atmel and
> chromeos-laptop
>
> - added Nick's Acks.
>
> Dmitry Torokhov (14):
> Input: atmel_mxt_ts - do not pass suspend mode in platform data
> Input: atmel_mxt_ts - switch from OF to generic device properties
> Input: atmel_mxt_ts - switch ChromeOS ACPI devices to generic props
> platform/chrome: chromeos_laptop - add SPDX identifier
> platform/chrome: chromeos_laptop - stop setting suspend mode for Atmel devices
> platform/chrome: chromeos_laptop - introduce pr_fmt()
> platform/chrome: chromeos_laptop - factor out getting IRQ from DMI
> platform/chrome: chromeos_laptop - rework i2c peripherals initialization
> platform/chrome: chromeos_laptop - parse DMI IRQ data once
> platform/chrome: chromeos_laptop - use I2C notifier to create devices
> platform/chrome: chromeos_laptop - rely on I2C to set up interrupt trigger
> platform/chrome: chromeos_laptop - use device properties for Pixel
> platform/chrome: chromeos_laptop - discard data for unneeded boards
> Input: atmel_mxt_ts - remove platform data support
>
> MAINTAINERS | 1 -
> drivers/input/touchscreen/atmel_mxt_ts.c | 231 +++---
> drivers/platform/chrome/chromeos_laptop.c | 896 +++++++++++----------
> include/linux/platform_data/atmel_mxt_ts.h | 31 -
> 4 files changed, 579 insertions(+), 580 deletions(-)
> delete mode 100644 include/linux/platform_data/atmel_mxt_ts.h
>
> --
> Dmitry
--
Benson Leung
Staff Software Engineer
Chrome OS Kernel
Google Inc.
bleung@google.com
Chromium OS Project
bleung@chromium.org
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
prev parent reply other threads:[~2018-04-11 5:44 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-20 22:31 [PATCH v2 00/14] chrome_laptop: stop being a platform driver Dmitry Torokhov
2018-03-20 22:31 ` [PATCH v2 01/14] Input: atmel_mxt_ts - do not pass suspend mode in platform data Dmitry Torokhov
2018-04-10 5:44 ` Benson Leung
2018-03-20 22:31 ` [PATCH v2 02/14] Input: atmel_mxt_ts - switch from OF to generic device properties Dmitry Torokhov
2018-03-20 22:31 ` [PATCH v2 03/14] Input: atmel_mxt_ts - switch ChromeOS ACPI devices to generic props Dmitry Torokhov
2018-03-20 22:31 ` [PATCH v2 04/14] platform/chrome: chromeos_laptop - add SPDX identifier Dmitry Torokhov
2018-03-20 22:31 ` [PATCH v2 05/14] platform/chrome: chromeos_laptop - stop setting suspend mode for Atmel devices Dmitry Torokhov
2018-03-22 23:34 ` Benson Leung
2018-03-20 22:31 ` [PATCH v2 06/14] platform/chrome: chromeos_laptop - introduce pr_fmt() Dmitry Torokhov
2018-03-20 22:31 ` [PATCH v2 07/14] platform/chrome: chromeos_laptop - factor out getting IRQ from DMI Dmitry Torokhov
2018-03-20 22:31 ` [PATCH v2 08/14] platform/chrome: chromeos_laptop - rework i2c peripherals initialization Dmitry Torokhov
2018-03-20 22:31 ` [PATCH v2 09/14] platform/chrome: chromeos_laptop - parse DMI IRQ data once Dmitry Torokhov
2018-03-20 22:31 ` [PATCH v2 10/14] platform/chrome: chromeos_laptop - use I2C notifier to create devices Dmitry Torokhov
2018-03-20 22:31 ` [PATCH v2 11/14] platform/chrome: chromeos_laptop - rely on I2C to set up interrupt trigger Dmitry Torokhov
2018-03-20 22:31 ` [PATCH v2 12/14] platform/chrome: chromeos_laptop - use device properties for Pixel Dmitry Torokhov
2018-03-20 22:31 ` [PATCH v2 13/14] platform/chrome: chromeos_laptop - discard data for unneeded boards Dmitry Torokhov
2018-03-20 22:31 ` [PATCH v2 14/14] Input: atmel_mxt_ts - remove platform data support Dmitry Torokhov
2018-04-11 5:44 ` Benson Leung [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180411054425.GB123734@decatoncale.mtv.corp.google.com \
--to=bleung@google.com \
--cc=bleung@chromium.org \
--cc=dmitry.torokhov@gmail.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nick@shmanahar.org \
--cc=olof@lixom.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).