From: Christoph Hellwig <hch@lst.de>
To: Robin Murphy <robin.murphy@arm.com>
Cc: Christoph Hellwig <hch@lst.de>,
linux-arch@vger.kernel.org, linux-xtensa@linux-xtensa.org,
Michal Simek <monstr@monstr.eu>,
Vincent Chen <deanbo422@gmail.com>,
linux-c6x-dev@linux-c6x.org, linux-parisc@vger.kernel.org,
linux-sh@vger.kernel.org, linux-hexagon@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-m68k@vger.kernel.org,
openrisc@lists.librecores.org, Greentime Hu <green.hu@gmail.com>,
linux-alpha@vger.kernel.org, sparclinux@vger.kernel.org,
nios2-dev@lists.rocketboards.org,
linux-snps-arc@lists.infradead.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 01/22] dma-debug: move initialization to common code
Date: Tue, 24 Apr 2018 09:35:24 +0200 [thread overview]
Message-ID: <20180424073524.GB18945@lst.de> (raw)
In-Reply-To: <294a1469-01d6-10fb-5de1-b1d4513a066c@arm.com>
On Fri, Apr 20, 2018 at 11:23:43AM +0100, Robin Murphy wrote:
>> -void dma_debug_init(u32 num_entries)
>> +static int dma_debug_init(void)
>> {
>> + u32 num_entries;
>
> Maybe initialise it to PREALLOC_DMA_DEBUG_ENTRIES?
We initialize it down in an if/else clause which seems a little more clear
to me, at the cost of two extra lines of code. But I suspect I should
just go a little further and merge the global req_entries and the local
num_entries into a single variable with a better name.
>> +core_initcall(dma_debug_init);
>
> I think it's worth noting that for most users this now happens much earlier
> than before. In general that's probably good (e.g. on arm64 it should
> prevent false-positives from the Arm SMMU drivers under ACPI), and I can't
> imagine it's high-risk, but it is a behaviour change.
I'll mention this in the changelog, thanks!
next prev parent reply other threads:[~2018-04-24 7:34 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-20 8:02 Christoph Hellwig
2018-04-20 8:02 ` [PATCH 01/22] dma-debug: move initialization to common code Christoph Hellwig
2018-04-20 10:23 ` Robin Murphy
2018-04-24 7:35 ` Christoph Hellwig [this message]
2018-04-20 8:02 ` [PATCH 02/22] dma-mapping: simplify Kconfig dependencies Christoph Hellwig
2018-04-20 8:02 ` [PATCH 03/22] dma-mapping: provide a generic dma-noncoherent implementation Christoph Hellwig
2018-04-20 8:02 ` [PATCH 04/22] alpha: use dma_direct_ops for jensen Christoph Hellwig
2018-04-20 8:02 ` [PATCH 05/22] alpha: simplify get_arch_dma_ops Christoph Hellwig
2018-04-20 8:02 ` [PATCH 06/22] arc: use generic dma_noncoherent_ops Christoph Hellwig
2018-04-25 11:17 ` Alexey Brodkin
2018-04-26 6:45 ` hch
2018-04-26 8:25 ` hch
2018-04-20 8:02 ` [PATCH 07/22] arm-nommu: " Christoph Hellwig
2018-04-20 8:02 ` [PATCH 08/22] c6x: " Christoph Hellwig
2018-04-20 8:03 ` [PATCH 09/22] hexagon: " Christoph Hellwig
2018-04-20 8:03 ` [PATCH 10/22] m68k: " Christoph Hellwig
2018-04-20 8:03 ` [PATCH 11/22] microblaze: " Christoph Hellwig
2018-04-20 8:03 ` [PATCH 12/22] microblaze: remove the consistent_sync and consistent_sync_page Christoph Hellwig
2018-04-20 8:03 ` [PATCH 13/22] nds32: use generic dma_noncoherent_ops Christoph Hellwig
2018-04-23 6:49 ` Greentime Hu
2018-04-24 19:16 ` Christoph Hellwig
2018-04-25 1:43 ` Greentime Hu
2018-04-25 6:40 ` Christoph Hellwig
2018-04-25 12:25 ` Greentime Hu
2018-04-26 6:42 ` Christoph Hellwig
2018-04-26 8:06 ` Greentime Hu
2018-04-26 8:24 ` Christoph Hellwig
2018-04-26 9:39 ` Greentime Hu
2018-04-20 8:03 ` [PATCH 14/22] nios2: " Christoph Hellwig
2018-04-20 8:03 ` [PATCH 15/22] openrisc: " Christoph Hellwig
2018-04-20 8:03 ` [PATCH 16/22] sh: simplify get_arch_dma_ops Christoph Hellwig
2018-04-20 8:03 ` [PATCH 17/22] sh: introduce a sh_cacheop_vaddr helper Christoph Hellwig
2018-04-20 8:03 ` [PATCH 18/22] sh: use dma_direct_ops for the CONFIG_DMA_COHERENT case Christoph Hellwig
2018-04-20 8:03 ` [PATCH 19/22] sh: use generic dma_noncoherent_ops Christoph Hellwig
2018-04-20 8:03 ` [PATCH 20/22] xtensa: " Christoph Hellwig
2018-04-20 8:03 ` [PATCH 21/22] sparc: " Christoph Hellwig
2018-04-20 8:03 ` [PATCH 22/22] parisc: " Christoph Hellwig
2018-04-21 17:43 ` Helge Deller
2018-04-21 21:52 ` James Bottomley
2018-04-25 7:21 ` Christoph Hellwig
2018-04-25 21:07 ` Helge Deller
2018-04-21 21:42 ` James Bottomley
2018-04-24 8:20 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180424073524.GB18945@lst.de \
--to=hch@lst.de \
--cc=deanbo422@gmail.com \
--cc=green.hu@gmail.com \
--cc=linux-alpha@vger.kernel.org \
--cc=linux-arch@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-c6x-dev@linux-c6x.org \
--cc=linux-hexagon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-m68k@vger.kernel.org \
--cc=linux-parisc@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=linux-snps-arc@lists.infradead.org \
--cc=linux-xtensa@linux-xtensa.org \
--cc=monstr@monstr.eu \
--cc=nios2-dev@lists.rocketboards.org \
--cc=openrisc@lists.librecores.org \
--cc=robin.murphy@arm.com \
--cc=sparclinux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).