From: Andrew Morton <akpm@linux-foundation.org>
To: Alexey Dobriyan <adobriyan@gmail.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] proc: test /proc/*/fd a bit (+ PF_KTHREAD is ABI!)
Date: Tue, 8 May 2018 15:39:20 -0700 [thread overview]
Message-ID: <20180508153920.9e74e1ab86a8b10e8ddf09a0@linux-foundation.org> (raw)
In-Reply-To: <20180505000414.GA15090@avx2>
On Sat, 5 May 2018 03:04:14 +0300 Alexey Dobriyan <adobriyan@gmail.com> wrote:
> * Test lookup in /proc/self/fd.
> "map_files" lookup story showed that lookup is not that simple.
>
> * Test that all those symlinks open the same file.
> Check with (st_dev, st_info).
>
> * Test that kernel threads do not have anything in their /proc/*/fd/
> directory.
>
> Now this is where things get interesting.
>
> First, kernel threads aren't pinned by /proc/self or equivalent,
> thus some "atomicity" is required.
>
> Second, ->comm can contain whitespace and ')'.
> No, they are not escaped.
>
> Third, the only reliable way to check if process is kernel thread
> appears to be field #9 in /proc/*/stat.
>
> This field is struct task_struct::flags in decimal!
> Check is done by testing PF_KTHREAD flags like we do in kernel.
>
> PF_KTREAD value is a part of userspace ABI !!!
erk. Well if there's a need the we could export and support some
stable interface. I wonder how ps determines this.
> Other methods for determining kernel threadness are not reliable:
> * RSS can be 0 if everything is swapped, even while reading
> from /proc/self.
>
> * ->total_vm CAN BE ZERO if process is finishing
>
> munmap(NULL, whole address space);
>
> * /proc/*/maps and similar files can be empty because unmapping
> everything works. Read returning 0 can't distinguish between
> kernel thread and such suicide process.
>
next prev parent reply other threads:[~2018-05-08 22:39 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-05 0:04 [PATCH] proc: test /proc/*/fd a bit (+ PF_KTHREAD is ABI!) Alexey Dobriyan
2018-05-08 22:39 ` Andrew Morton [this message]
2018-05-09 16:34 ` Alexey Dobriyan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180508153920.9e74e1ab86a8b10e8ddf09a0@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=adobriyan@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).