From: kbuild test robot <lkp@intel.com>
To: Doug Oucharek <dougso@me.com>
Cc: kbuild-all@01.org,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
devel@driverdev.osuosl.org, Oleg Drokin <oleg.drokin@intel.com>,
Andreas Dilger <andreas.dilger@intel.com>,
James Simmons <jsimmons@infradead.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Lustre Development List <lustre-devel@lists.lustre.org>
Subject: Re: [PATCH] staging: lustre: o2iblnd: Fix crash in kiblnd_handle_early_rxs()
Date: Fri, 11 May 2018 03:15:59 +0800 [thread overview]
Message-ID: <201805110304.MOAwHAIT%fengguang.wu@intel.com> (raw)
In-Reply-To: <1525930679-15227-1-git-send-email-dougso@me.com>
[-- Attachment #1: Type: text/plain, Size: 3383 bytes --]
Hi Doug,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on staging/staging-testing]
[also build test ERROR on v4.17-rc4 next-20180510]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
url: https://github.com/0day-ci/linux/commits/Doug-Oucharek/staging-lustre-o2iblnd-Fix-crash-in-kiblnd_handle_early_rxs/20180511-004953
config: i386-allyesconfig (attached as .config)
compiler: gcc-7 (Debian 7.3.0-16) 7.3.0
reproduce:
# save the attached .config to linux build tree
make ARCH=i386
All errors (new ones prefixed by >>):
drivers/staging/lustre/lnet/klnds/o2iblnd/o2iblnd_cb.c: In function 'kiblnd_handle_early_rxs':
drivers/staging/lustre/lnet/klnds/o2iblnd/o2iblnd_cb.c:1974:161: error: 'kib_rx_t' undeclared (first use in this function); did you mean 'kib_rx'?
rx = list_entry(conn->ibc_early_rxs.next,
^
kib_rx
drivers/staging/lustre/lnet/klnds/o2iblnd/o2iblnd_cb.c:1974:161: note: each undeclared identifier is reported only once for each function it appears in
>> drivers/staging/lustre/lnet/klnds/o2iblnd/o2iblnd_cb.c:1974:171: error: expected expression before ')' token
rx = list_entry(conn->ibc_early_rxs.next,
^
drivers/staging/lustre/lnet/klnds/o2iblnd/o2iblnd_cb.c:1974:468: error: expected expression before ')' token
rx = list_entry(conn->ibc_early_rxs.next,
^
vim +1974 drivers/staging/lustre/lnet/klnds/o2iblnd/o2iblnd_cb.c
1962
1963 static void
1964 kiblnd_handle_early_rxs(struct kib_conn *conn)
1965 {
1966 unsigned long flags;
1967 struct kib_rx *rx;
1968
1969 LASSERT(!in_interrupt());
1970 LASSERT(conn->ibc_state >= IBLND_CONN_ESTABLISHED);
1971
1972 write_lock_irqsave(&kiblnd_data.kib_global_lock, flags);
1973 while (!list_empty(&conn->ibc_early_rxs)) {
> 1974 rx = list_entry(conn->ibc_early_rxs.next,
1975 kib_rx_t, rx_list);
1976 list_del(&rx->rx_list);
1977 write_unlock_irqrestore(&kiblnd_data.kib_global_lock, flags);
1978
1979 kiblnd_handle_rx(rx);
1980
1981 write_lock_irqsave(&kiblnd_data.kib_global_lock, flags);
1982 }
1983 write_unlock_irqrestore(&kiblnd_data.kib_global_lock, flags);
1984 }
1985
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 62264 bytes --]
next prev parent reply other threads:[~2018-05-10 19:15 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-10 5:37 [PATCH] staging: lustre: o2iblnd: Fix crash in kiblnd_handle_early_rxs() Doug Oucharek
2018-05-10 17:39 ` kbuild test robot
2018-05-10 19:15 ` kbuild test robot [this message]
2018-05-11 0:53 ` [lustre-devel] " NeilBrown
2018-05-11 2:30 ` Doug Oucharek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201805110304.MOAwHAIT%fengguang.wu@intel.com \
--to=lkp@intel.com \
--cc=andreas.dilger@intel.com \
--cc=devel@driverdev.osuosl.org \
--cc=dougso@me.com \
--cc=gregkh@linuxfoundation.org \
--cc=jsimmons@infradead.org \
--cc=kbuild-all@01.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lustre-devel@lists.lustre.org \
--cc=oleg.drokin@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).