From: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
To: srinivas.pandruvada@linux.intel.com, tglx@linutronix.de,
mingo@redhat.com, peterz@infradead.org, bp@suse.de,
lenb@kernel.org, rjw@rjwysocki.net, mgorman@techsingularity.net
Cc: x86@kernel.org, linux-pm@vger.kernel.org,
viresh.kumar@linaro.org, juri.lelli@arm.com,
linux-kernel@vger.kernel.org
Subject: [RFC/RFT] [PATCH 08/10] cpufreq: intel_pstate: Dyanmically update busy pct
Date: Tue, 15 May 2018 21:49:09 -0700 [thread overview]
Message-ID: <20180516044911.28797-9-srinivas.pandruvada@linux.intel.com> (raw)
In-Reply-To: <20180516044911.28797-1-srinivas.pandruvada@linux.intel.com>
Calculate hwp_boost_threshold_busy_pct (task busy percent, which is
worth boosting) and hwp_boost_pstate_threshold (Don't boost if
CPU already has some performance) based on platform, min, max and
turbo frequencies.
Signed-off-by: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
---
drivers/cpufreq/intel_pstate.c | 40 +++++++++++++++++++++++++++++++++++++++-
1 file changed, 39 insertions(+), 1 deletion(-)
diff --git a/drivers/cpufreq/intel_pstate.c b/drivers/cpufreq/intel_pstate.c
index ec455af..c43edce 100644
--- a/drivers/cpufreq/intel_pstate.c
+++ b/drivers/cpufreq/intel_pstate.c
@@ -1463,6 +1463,42 @@ static inline int intel_pstate_get_sched_util(struct cpudata *cpu)
return util * 100 / max;
}
+
+static inline void intel_pstate_update_busy_threshold(struct cpudata *cpu)
+{
+ if (!hwp_boost_threshold_busy_pct) {
+ int min_freq, max_freq;
+
+ min_freq = cpu->pstate.min_pstate * cpu->pstate.scaling;
+ update_turbo_state();
+ max_freq = global.turbo_disabled || global.no_turbo ?
+ cpu->pstate.max_freq : cpu->pstate.turbo_freq;
+
+ /*
+ * We are guranteed to get atleast min P-state. If we assume
+ * P-state is proportional to load (such that 10% load
+ * increase will result in 10% P-state increase), we will
+ * get at least min P-state till we have atleast
+ * (min * 100/max) percent cpu load. So any load less than
+ * than this this we shouldn't do any boost. Then boosting
+ * is not free, we will add atleast 20% offset.
+ */
+ hwp_boost_threshold_busy_pct = min_freq * 100 / max_freq;
+ hwp_boost_threshold_busy_pct += 20;
+ pr_debug("hwp_boost_threshold_busy_pct = %d\n",
+ hwp_boost_threshold_busy_pct);
+ }
+
+ /* P1 percent out of total range of P-states */
+ if (cpu->pstate.max_freq != cpu->pstate.turbo_freq) {
+ hwp_boost_pstate_threshold =
+ cpu->pstate.max_freq * SCHED_CAPACITY_SCALE / cpu->pstate.turbo_freq;
+ pr_debug("hwp_boost_pstate_threshold = %d\n",
+ hwp_boost_pstate_threshold);
+ }
+
+}
+
static inline void intel_pstate_update_util_hwp(struct update_util_data *data,
u64 time, unsigned int flags)
{
@@ -2061,8 +2097,10 @@ static int __intel_pstate_cpu_init(struct cpufreq_policy *policy)
policy->fast_switch_possible = true;
- if (hwp_active)
+ if (hwp_active) {
csd_init(cpu);
+ intel_pstate_update_busy_threshold(cpu);
+ }
return 0;
}
--
2.9.5
next prev parent reply other threads:[~2018-05-16 4:49 UTC|newest]
Thread overview: 58+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-16 4:49 [RFC/RFT] [PATCH 00/10] Intel_pstate: HWP Dynamic performance boost Srinivas Pandruvada
2018-05-16 4:49 ` [RFC/RFT] [PATCH 01/10] x86,sched: Add support for frequency invariance Srinivas Pandruvada
2018-05-16 9:56 ` Peter Zijlstra
2018-05-16 4:49 ` [RFC/RFT] [PATCH 02/10] cpufreq: intel_pstate: Conditional frequency invariant accounting Srinivas Pandruvada
2018-05-16 7:16 ` Peter Zijlstra
2018-05-16 7:29 ` Peter Zijlstra
2018-05-16 9:07 ` Rafael J. Wysocki
2018-05-16 17:32 ` Srinivas Pandruvada
2018-05-16 15:19 ` Juri Lelli
2018-05-16 15:47 ` Peter Zijlstra
2018-05-16 16:31 ` Juri Lelli
2018-05-17 10:59 ` Juri Lelli
2018-05-17 15:04 ` Juri Lelli
2018-05-17 15:41 ` Srinivas Pandruvada
2018-05-17 16:16 ` Peter Zijlstra
2018-05-17 16:42 ` Srinivas Pandruvada
2018-05-17 16:56 ` Rafael J. Wysocki
2018-05-17 18:28 ` Peter Zijlstra
2018-05-18 7:36 ` Rafael J. Wysocki
2018-05-18 10:57 ` Patrick Bellasi
2018-05-18 11:29 ` Peter Zijlstra
2018-05-18 13:33 ` Patrick Bellasi
2018-05-30 16:57 ` Patrick Bellasi
2018-05-18 14:09 ` Valentin Schneider
2018-05-16 15:58 ` Srinivas Pandruvada
2018-05-16 4:49 ` [RFC/RFT] [PATCH 03/10] cpufreq: intel_pstate: Utility functions to boost HWP performance limits Srinivas Pandruvada
2018-05-16 7:22 ` Peter Zijlstra
2018-05-16 9:15 ` Rafael J. Wysocki
2018-05-16 10:43 ` Peter Zijlstra
2018-05-16 15:39 ` Srinivas Pandruvada
2018-05-16 15:41 ` Srinivas Pandruvada
2018-05-16 4:49 ` [RFC/RFT] [PATCH 04/10] cpufreq: intel_pstate: Add update_util_hook for HWP Srinivas Pandruvada
2018-05-16 4:49 ` [RFC/RFT] [PATCH 05/10] cpufreq: intel_pstate: HWP boost performance on IO Wake Srinivas Pandruvada
2018-05-16 7:37 ` Peter Zijlstra
2018-05-16 17:55 ` Srinivas Pandruvada
2018-05-17 8:19 ` Peter Zijlstra
2018-05-16 9:45 ` Rafael J. Wysocki
2018-05-16 19:28 ` Srinivas Pandruvada
2018-05-16 4:49 ` [RFC/RFT] [PATCH 06/10] cpufreq / sched: Add interface to get utilization values Srinivas Pandruvada
2018-05-16 6:40 ` Viresh Kumar
2018-05-16 22:25 ` Srinivas Pandruvada
2018-05-16 8:11 ` Peter Zijlstra
2018-05-16 22:40 ` Srinivas Pandruvada
2018-05-17 7:50 ` Peter Zijlstra
2018-05-16 4:49 ` [RFC/RFT] [PATCH 07/10] cpufreq: intel_pstate: HWP boost performance on busy task migrate Srinivas Pandruvada
2018-05-16 9:49 ` Rafael J. Wysocki
2018-05-16 20:59 ` Srinivas Pandruvada
2018-05-16 4:49 ` Srinivas Pandruvada [this message]
2018-05-16 7:43 ` [RFC/RFT] [PATCH 08/10] cpufreq: intel_pstate: Dyanmically update busy pct Peter Zijlstra
2018-05-16 7:47 ` Peter Zijlstra
2018-05-16 4:49 ` [RFC/RFT] [PATCH 09/10] cpufreq: intel_pstate: New sysfs entry to control HWP boost Srinivas Pandruvada
2018-05-16 4:49 ` [RFC/RFT] [PATCH 10/10] cpufreq: intel_pstate: enable boost for SKX Srinivas Pandruvada
2018-05-16 7:49 ` Peter Zijlstra
2018-05-16 15:46 ` Srinivas Pandruvada
2018-05-16 15:54 ` Peter Zijlstra
2018-05-17 0:52 ` Srinivas Pandruvada
2018-05-16 6:49 ` [RFC/RFT] [PATCH 00/10] Intel_pstate: HWP Dynamic performance boost Juri Lelli
2018-05-16 15:43 ` Srinivas Pandruvada
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180516044911.28797-9-srinivas.pandruvada@linux.intel.com \
--to=srinivas.pandruvada@linux.intel.com \
--cc=bp@suse.de \
--cc=juri.lelli@arm.com \
--cc=lenb@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=mgorman@techsingularity.net \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=rjw@rjwysocki.net \
--cc=tglx@linutronix.de \
--cc=viresh.kumar@linaro.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).