From: Matthew Wilcox <willy@infradead.org>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Roman Kagan <rkagan@virtuozzo.com>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] idr: fix invalid ptr dereference on item delete
Date: Fri, 18 May 2018 17:28:15 -0700 [thread overview]
Message-ID: <20180519002815.GA21615@bombadil.infradead.org> (raw)
In-Reply-To: <20180518153138.459c78a83c6bada41b4b187d@linux-foundation.org>
On Fri, May 18, 2018 at 03:31:38PM -0700, Andrew Morton wrote:
> On Fri, 18 May 2018 10:50:25 -0700 Matthew Wilcox <willy@infradead.org> wrote:
> > If the radix tree underlying the IDR happens to be full and we attempt
> > to remove an id which is larger than any id in the IDR, we will call
> > __radix_tree_delete() with an uninitialised 'slot' pointer, at which
> > point anything could happen. This was easiest to hit with a single entry
> > at id 0 and attempting to remove a non-0 id, but it could have happened
> > with 64 entries and attempting to remove an id >= 64.
> >
> > Fixes: 0a835c4f090a ("Reimplement IDR and IDA using the radix tree")
> > Reported-by: syzbot+35666cba7f0a337e2e79@syzkaller.appspotmail.com
> > Debugged-by: Roman Kagan <rkagan@virtuozzo.com>
> > Signed-off-by: Matthew Wilcox <mawilcox@microsoft.com>
>
> Neither of the changelogs I'm seeing attempt to describe the end-user
> impact of the bug. People like to know that so they can decide which
> kernel version(s) need patching, so please always remember it.
The problem is that it could be user-triggerable a dozen different
ways.
> Looknig at the sysbot report, the impact is at least "privileged user
> can trigger a WARN", but I assume there could be worse,
> as-yet-undiscovered impacts. So I'm thinking a cc:stable is needed,
> yes?
I thought if I used the Fixes: tag it would automatically get picked up.
Did I misunderstand? I can imagine many different parts of the kernel
that use the IDR could trigger such a warning (although syzbot should
probably have tripped over them before now) so I wouldn't downplay
it to "only privileged users".
next prev parent reply other threads:[~2018-05-19 0:28 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-18 17:50 [PATCH] idr: fix invalid ptr dereference on item delete Matthew Wilcox
2018-05-18 20:23 ` Roman Kagan
2018-05-19 0:31 ` Matthew Wilcox
2018-05-18 22:31 ` Andrew Morton
2018-05-19 0:28 ` Matthew Wilcox [this message]
2018-05-19 6:26 ` Roman Kagan
2018-05-19 14:14 ` Matthew Wilcox
2018-05-21 19:13 ` Andrew Morton
-- strict thread matches above, loose matches on Subject: below --
2018-05-10 19:16 Roman Kagan
2018-05-10 23:54 ` Paolo Bonzini
2018-05-11 5:40 ` Dmitry Vyukov
2018-05-11 5:57 ` Roman Kagan
2018-05-11 9:12 ` Paolo Bonzini
2018-05-18 20:29 ` Roman Kagan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180519002815.GA21615@bombadil.infradead.org \
--to=willy@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rkagan@virtuozzo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).