From: Lee Jones <lee.jones@linaro.org>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Marek Vasut <marek.vasut@gmail.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Marek Vasut <marek.vasut+renesas@gmail.com>,
Geert Uytterhoeven <geert+renesas@glider.be>,
Mark Brown <broonie@kernel.org>,
Steve Twiss <stwiss.opensource@diasemi.com>,
Wolfram Sang <wsa+renesas@sang-engineering.com>,
Linux-Renesas <linux-renesas-soc@vger.kernel.org>
Subject: Re: [PATCH v3 02/10] mfd: da9063: Use REGMAP_IRQ_REG
Date: Tue, 5 Jun 2018 09:16:38 +0100 [thread overview]
Message-ID: <20180605080115.GN21163@dell> (raw)
In-Reply-To: <CAMuHMdWEeH4_ciyn6V7FYrs0doutqkz++32D_bz57rSHnY=CEQ@mail.gmail.com>
On Tue, 05 Jun 2018, Geert Uytterhoeven wrote:
> Hi Lee,
>
> On Tue, Jun 5, 2018 at 9:09 AM, Lee Jones <lee.jones@linaro.org> wrote:
> > On Mon, 04 Jun 2018, Marek Vasut wrote:
> >> On 06/04/2018 02:26 PM, Lee Jones wrote:
> >> > On Sat, 02 Jun 2018, Marek Vasut wrote:
> >> >> Convert the regmap_irq table to use REGMAP_IRQ_REG().
> >> >>
> >> >> Signed-off-by: Marek Vasut <marek.vasut+renesas@gmail.com>
> >> >> Cc: Geert Uytterhoeven <geert+renesas@glider.be>
> >> >> Cc: Lee Jones <lee.jones@linaro.org>
> >> >> Cc: Mark Brown <broonie@kernel.org>
> >> >> Cc: Steve Twiss <stwiss.opensource@diasemi.com>
> >> >> Cc: Wolfram Sang <wsa+renesas@sang-engineering.com>
> >> >> Cc: linux-renesas-soc@vger.kernel.org
> >> >> ---
> >> >> V3: New patch
> >> >> Note: A sed oneliner was used:
> >> >> sed -i "/\[DA9063_IRQ_/ {N;N;N;s/\n//g;s/.*\[\(DA9063_IRQ_[^]]\+\)].*reg_offset = \([^,]\+\),.* = \([^,]\+\),.*/\tREGMAP_IRQ_REG(\1, \2, \3),/}" drivers/mfd/da9063-irq.c
> >> >> ---
> >> >> drivers/mfd/da9063-irq.c | 145 ++++++++++-------------------------------------
> >> >> 1 file changed, 29 insertions(+), 116 deletions(-)
> >> >>
> >> >> diff --git a/drivers/mfd/da9063-irq.c b/drivers/mfd/da9063-irq.c
> >> >> index 207bbfe55449..5b406ecfc14a 100644
> >> >> --- a/drivers/mfd/da9063-irq.c
> >> >> +++ b/drivers/mfd/da9063-irq.c
> >> >> @@ -28,125 +28,38 @@
> >> >>
> >> >> static const struct regmap_irq da9063_irqs[] = {
> >> >> /* DA9063 event A register */
> >> >> - [DA9063_IRQ_ONKEY] = {
> >> >> - .reg_offset = DA9063_REG_EVENT_A_OFFSET,
> >> >> - .mask = DA9063_M_ONKEY,
> >> >> - },
> >> >> - [DA9063_IRQ_ALARM] = {
> >> >> - .reg_offset = DA9063_REG_EVENT_A_OFFSET,
> >> >> - .mask = DA9063_M_ALARM,
> >> >> - },
> >> >> - [DA9063_IRQ_TICK] = {
> >> >> - .reg_offset = DA9063_REG_EVENT_A_OFFSET,
> >> >> - .mask = DA9063_M_TICK,
> >> >> - },
> >> >> - [DA9063_IRQ_ADC_RDY] = {
> >> >> - .reg_offset = DA9063_REG_EVENT_A_OFFSET,
> >> >> - .mask = DA9063_M_ADC_RDY,
> >> >> - },
> >> >> - [DA9063_IRQ_SEQ_RDY] = {
> >> >> - .reg_offset = DA9063_REG_EVENT_A_OFFSET,
> >> >> - .mask = DA9063_M_SEQ_RDY,
> >> >> - },
> >> >> + REGMAP_IRQ_REG(DA9063_IRQ_ONKEY, DA9063_REG_EVENT_A_OFFSET, DA9063_M_ONKEY),
> >> >> + REGMAP_IRQ_REG(DA9063_IRQ_ALARM, DA9063_REG_EVENT_A_OFFSET, DA9063_M_ALARM),
> >> >> + REGMAP_IRQ_REG(DA9063_IRQ_TICK, DA9063_REG_EVENT_A_OFFSET, DA9063_M_TICK),
> >> >> + REGMAP_IRQ_REG(DA9063_IRQ_ADC_RDY, DA9063_REG_EVENT_A_OFFSET, DA9063_M_ADC_RDY),
> >> >> + REGMAP_IRQ_REG(DA9063_IRQ_SEQ_RDY, DA9063_REG_EVENT_A_OFFSET, DA9063_M_SEQ_RDY),
> >> >
> >> > Nice, but I think checkpatch.pl would complain.
> >> >
> >> > Better to break after the first argument I think.
> >>
> >> Doesn't really help the readability, but done.
> >
> > I don't make the rules. :)
>
> Documentation/process/coding-style.rst:
>
> "Statements longer than 80 columns will be broken into sensible chunks, unless
> exceeding 80 columns significantly increases readability and does not hide
> information."
Operative word here is "significantly".
> > Personally /me is hoping that the 80 char limit is lifted to ~120 soon.
>
> Please no ;-)
Maybe 120 is pushing it a little, but 80 is so 19xx? ... well, 80!
--
Lee Jones [李琼斯]
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
next prev parent reply other threads:[~2018-06-05 8:16 UTC|newest]
Thread overview: 51+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-02 10:11 [PATCH v3 01/10] mfd: da9063: Fix failpath in core Marek Vasut
2018-06-02 10:11 ` [PATCH v3 02/10] mfd: da9063: Use REGMAP_IRQ_REG Marek Vasut
2018-06-04 7:17 ` Geert Uytterhoeven
2018-06-04 12:26 ` Lee Jones
2018-06-04 16:23 ` Marek Vasut
2018-06-05 7:09 ` Lee Jones
2018-06-05 7:31 ` Geert Uytterhoeven
2018-06-05 8:16 ` Lee Jones [this message]
2018-06-05 19:48 ` Steve Twiss
2018-06-02 10:11 ` [PATCH v3 03/10] mfd: da9063: Rename PMIC_DA9063 to PMIC_CHIP_ID_DA9063 Marek Vasut
2018-06-04 12:26 ` Lee Jones
2018-06-04 18:31 ` Marek Vasut
2018-06-05 7:05 ` Lee Jones
2018-06-05 17:16 ` Steve Twiss
2018-06-05 17:20 ` Marek Vasut
2018-06-05 19:49 ` Steve Twiss
2018-06-02 10:11 ` [PATCH v3 04/10] mfd: da9063: Replace model with type Marek Vasut
2018-06-05 7:21 ` Lee Jones
2018-06-02 10:11 ` [PATCH v3 05/10] mfd: da9063: Add DA9063L type Marek Vasut
2018-06-05 7:22 ` Lee Jones
2018-06-05 19:50 ` Steve Twiss
2018-06-02 10:11 ` [PATCH v3 06/10] mfd: da9063: Add custom regmap for DA9063L Marek Vasut
2018-06-04 7:39 ` Geert Uytterhoeven
2018-06-04 16:25 ` Marek Vasut
2018-06-05 20:17 ` Steve Twiss
2018-06-05 23:02 ` Marek Vasut
2018-06-06 9:47 ` Steve Twiss
2018-06-06 9:50 ` Marek Vasut
2018-06-02 10:11 ` [PATCH v3 07/10] mfd: da9063: Add custom IRQ map " Marek Vasut
2018-06-05 7:47 ` Lee Jones
2018-06-05 7:54 ` Geert Uytterhoeven
2018-06-05 8:24 ` Lee Jones
2018-06-05 19:52 ` Steve Twiss
2018-06-05 22:58 ` Marek Vasut
2018-06-02 10:11 ` [PATCH v3 08/10] mfd: da9063: Register RTC only on DA9063L Marek Vasut
2018-06-05 7:53 ` Lee Jones
2018-06-05 9:29 ` Marek Vasut
2018-06-06 6:16 ` Lee Jones
2018-06-06 9:17 ` Marek Vasut
2018-06-07 5:04 ` Lee Jones
2018-06-07 10:57 ` Marek Vasut
2018-06-07 13:24 ` Lee Jones
2018-06-02 10:11 ` [PATCH v3 09/10] mfd: da9063: Handle less LDOs " Marek Vasut
2018-06-05 8:18 ` Lee Jones
2018-06-02 10:11 ` [PATCH v3 10/10] mfd: da9063: Add DA9063L support Marek Vasut
2018-06-05 8:18 ` Lee Jones
2018-06-05 19:47 ` Steve Twiss
2018-06-04 7:16 ` [PATCH v3 01/10] mfd: da9063: Fix failpath in core Geert Uytterhoeven
2018-06-04 8:28 ` Vaishali Thakkar
2018-06-04 12:24 ` Lee Jones
2018-06-04 13:08 ` Marek Vasut
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180605080115.GN21163@dell \
--to=lee.jones@linaro.org \
--cc=broonie@kernel.org \
--cc=geert+renesas@glider.be \
--cc=geert@linux-m68k.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=marek.vasut+renesas@gmail.com \
--cc=marek.vasut@gmail.com \
--cc=stwiss.opensource@diasemi.com \
--cc=wsa+renesas@sang-engineering.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).