From: Nick Desaulniers <ndesaulniers@google.com>
To: thierry.reding@gmail.com, airlied@linux.ie
Cc: Jagan Teki <jagannadh.teki@gmail.com>,
Rob Herring <robh@kernel.org>,
Thierry Reding <treding@nvidia.com>,
Nick Desaulniers <ndesaulniers@google.com>,
dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
Subject: [PATCH] drm/panel: simple: fix -Wliteral-conversion warning
Date: Fri, 15 Jun 2018 15:37:49 -0700 [thread overview]
Message-ID: <20180615223749.149073-1-ndesaulniers@google.com> (raw)
Fixes commit 8cfe83419cdb ("drm/panel: simple: Add
support for KEO TX31D200VM0BAA")
drivers/gpu/drm/panel/panel-simple.c:1250:27: warning: implicit conversion from
'double' to 'u32' (aka 'unsigned int') changes value from 33.5 to 33
[-Wliteral-conversion]
.vfront_porch = { 6, 21, 33.5 },
~ ^~~~
drivers/gpu/drm/panel/panel-simple.c:1251:26: warning: implicit conversion from
'double' to 'u32' (aka 'unsigned int') changes value from 33.5 to 33
[-Wliteral-conversion]
.vback_porch = { 6, 21, 33.5 },
~ ^~~~
Signed-off-by: Nick Desaulniers <ndesaulniers@google.com>
---
Alternatively, should these be rounded up to 34? I'm guessing the
current behaviour (truncation) is correct since that's how the patch was
operating.
drivers/gpu/drm/panel/panel-simple.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c
index cbf1ab404ee7..12bcbd1dd77b 100644
--- a/drivers/gpu/drm/panel/panel-simple.c
+++ b/drivers/gpu/drm/panel/panel-simple.c
@@ -1247,8 +1247,8 @@ static const struct display_timing koe_tx31d200vm0baa_timing = {
.hback_porch = { 16, 36, 56 },
.hsync_len = { 8, 8, 8 },
.vactive = { 480, 480, 480 },
- .vfront_porch = { 6, 21, 33.5 },
- .vback_porch = { 6, 21, 33.5 },
+ .vfront_porch = { 6, 21, 33 },
+ .vback_porch = { 6, 21, 33 },
.vsync_len = { 8, 8, 8 },
.flags = DISPLAY_FLAGS_DE_HIGH,
};
--
2.18.0.rc1.244.gcf134e6275-goog
next reply other threads:[~2018-06-15 22:38 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-15 22:37 Nick Desaulniers [this message]
2018-08-08 22:06 ` [PATCH] drm/panel: simple: fix -Wliteral-conversion warning Nick Desaulniers
2018-08-09 9:59 ` Thierry Reding
2018-08-09 16:38 ` Nick Desaulniers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180615223749.149073-1-ndesaulniers@google.com \
--to=ndesaulniers@google.com \
--cc=airlied@linux.ie \
--cc=dri-devel@lists.freedesktop.org \
--cc=jagannadh.teki@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
--cc=thierry.reding@gmail.com \
--cc=treding@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).