From: Viresh Kumar <viresh.kumar@linaro.org>
To: Taniya Das <tdas@codeaurora.org>
Cc: Sudeep Holla <sudeep.holla@arm.com>,
Amit Kucheria <amit.kucheria@verdurent.com>,
LKML <linux-kernel@vger.kernel.org>,
Linux PM list <linux-pm@vger.kernel.org>,
"Rafael J. Wysocki" <rjw@rjwysocki.net>,
Stephen Boyd <sboyd@kernel.org>,
Rajendra Nayak <rnayak@codeaurora.org>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>, Rob Herring <robh@kernel.org>,
Saravana Kannan <skannan@codeaurora.org>
Subject: Re: [PATCH v4 1/2] dt-bindings: cpufreq: Introduce QCOM CPUFREQ FW bindings
Date: Tue, 19 Jun 2018 14:51:22 +0530 [thread overview]
Message-ID: <20180619092122.ul56qnh5uangti3e@vireshk-i7> (raw)
In-Reply-To: <514eea88-1f98-7959-2341-3d57cff6f66b@codeaurora.org>
On 19-06-18, 13:23, Taniya Das wrote:
> Driver code (The below representation is just for example).
> =============
>
> V1
> #define ENABLE 0x0
> #define LUT_V1 0x110
> #define PERF_V1 0x920
>
> V2
> #define LUT_V2 0x150
> #define PERF_V2 0x980
>
> V3
> #define LUT_V3 0x120
> ....
>
> Do you want me to use "compatible" flag to
>
> if (compatible == v1)
> enable = readl_relaxed(X + LUT_V1);
> else if (compatible == v2)
> enable = readl_relaxed(X + LUT_V2);
> else if (compatible == v3)
> enable = readl_relaxed(X + LUT_V2);
You can have fields in a struct somewhere like enable_offset, which you can fill
based on compatible string only once during probe and then the rest of the code
would just do:
enable = readl_relaxed(X + struct->enable_offset);
--
viresh
next prev parent reply other threads:[~2018-06-19 9:21 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-12 11:02 [PATCH v4 0/2] cpufreq: qcom-fw: Add support for QCOM cpufreq FW driver Taniya Das
2018-06-12 11:02 ` [PATCH v4 1/2] dt-bindings: cpufreq: Introduce QCOM CPUFREQ FW bindings Taniya Das
2018-06-13 11:26 ` Sudeep Holla
2018-06-13 18:13 ` Taniya Das
2018-06-14 10:47 ` Sudeep Holla
2018-06-14 18:24 ` Taniya Das
2018-06-15 11:59 ` Amit Kucheria
2018-06-15 13:27 ` Sudeep Holla
2018-06-15 17:40 ` Taniya Das
2018-06-15 17:45 ` Sudeep Holla
2018-06-17 9:03 ` Amit Kucheria
2018-06-18 9:21 ` Sudeep Holla
2018-06-19 7:53 ` Taniya Das
2018-06-19 9:21 ` Viresh Kumar [this message]
2018-06-19 9:34 ` Sudeep Holla
2018-06-19 10:44 ` Taniya Das
2018-06-15 13:23 ` Sudeep Holla
2018-06-15 17:31 ` Taniya Das
2018-06-15 17:42 ` Sudeep Holla
2018-06-15 13:07 ` Amit Kucheria
2018-06-12 11:02 ` [PATCH v4 2/2] cpufreq: qcom-fw: Add support for QCOM cpufreq FW driver Taniya Das
2018-06-15 12:02 ` Amit Kucheria
2018-06-19 9:30 ` Viresh Kumar
2018-07-11 20:37 ` Matthias Kaehlcke
2018-07-12 18:06 ` Taniya Das
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180619092122.ul56qnh5uangti3e@vireshk-i7 \
--to=viresh.kumar@linaro.org \
--cc=amit.kucheria@verdurent.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=rjw@rjwysocki.net \
--cc=rnayak@codeaurora.org \
--cc=robh@kernel.org \
--cc=sboyd@kernel.org \
--cc=skannan@codeaurora.org \
--cc=sudeep.holla@arm.com \
--cc=tdas@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).