From: "Michael S. Tsirkin" <mst@redhat.com>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: wei.w.wang@intel.com, virtio-dev@lists.oasis-open.org,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
virtualization <virtualization@lists.linux-foundation.org>,
KVM list <kvm@vger.kernel.org>, linux-mm <linux-mm@kvack.org>,
Michal Hocko <mhocko@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
Paolo Bonzini <pbonzini@redhat.com>,
liliang.opensource@gmail.com, yang.zhang.wz@gmail.com,
quan.xu0@gmail.com, nilal@redhat.com,
Rik van Riel <riel@redhat.com>,
peterx@redhat.com
Subject: Re: [PATCH v35 1/5] mm: support to get hints of free page blocks
Date: Wed, 11 Jul 2018 07:04:01 +0300 [thread overview]
Message-ID: <20180711070318-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <20180711064709-mutt-send-email-mst@kernel.org>
On Wed, Jul 11, 2018 at 07:00:37AM +0300, Michael S. Tsirkin wrote:
> On Tue, Jul 10, 2018 at 10:33:08AM -0700, Linus Torvalds wrote:
> > NAK.
> >
> > On Tue, Jul 10, 2018 at 2:56 AM Wei Wang <wei.w.wang@intel.com> wrote:
> > >
> > > +
> > > + buf_page = list_first_entry_or_null(pages, struct page, lru);
> > > + if (!buf_page)
> > > + return -EINVAL;
> > > + buf = (__le64 *)page_address(buf_page);
> >
> > Stop this garbage.
> >
> > Why the hell would you pass in some crazy "liost of pages" that uses
> > that lru list?
> >
> > That's just insane shit.
> >
> > Just pass in a an array to fill in.
> > No idiotic games like this with
> > odd list entries (what's the locking?) and crazy casting to
> >
> > So if you want an array of page addresses, pass that in as such. If
> > you want to do it in a page, do it with
> >
> > u64 *array = page_address(page);
> > int nr = PAGE_SIZE / sizeof(u64);
> >
> > and now you pass that array in to the thing. None of this completely
> > insane crazy crap interfaces.
>
> Question was raised what to do if there are so many free
> MAX_ORDER pages that their addresses don't fit in a single MAX_ORDER
> page.
Oh you answered already, I spoke too soon. Nevermind, pls ignore me.
next prev parent reply other threads:[~2018-07-11 4:04 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-10 9:31 [PATCH v35 0/5] Virtio-balloon: support free page reporting Wei Wang
2018-07-10 9:31 ` [PATCH v35 1/5] mm: support to get hints of free page blocks Wei Wang
2018-07-10 10:16 ` Wang, Wei W
2018-07-10 17:33 ` Linus Torvalds
2018-07-11 1:28 ` Wei Wang
2018-07-11 1:44 ` Linus Torvalds
2018-07-11 9:21 ` Michal Hocko
2018-07-11 10:52 ` Wei Wang
2018-07-11 11:09 ` Michal Hocko
2018-07-11 13:55 ` Wang, Wei W
2018-07-11 14:38 ` Michal Hocko
2018-07-11 19:36 ` Michael S. Tsirkin
2018-07-11 16:23 ` Linus Torvalds
2018-07-12 2:21 ` Wei Wang
2018-07-12 2:30 ` Linus Torvalds
2018-07-12 2:52 ` Wei Wang
2018-07-12 8:13 ` Michal Hocko
2018-07-12 11:34 ` Wei Wang
2018-07-12 11:49 ` Michal Hocko
2018-07-13 0:33 ` Wei Wang
2018-07-12 13:12 ` Michal Hocko
2018-07-11 4:00 ` Michael S. Tsirkin
2018-07-11 4:04 ` Michael S. Tsirkin [this message]
2018-07-10 9:31 ` [PATCH v35 2/5] virtio-balloon: remove BUG() in init_vqs Wei Wang
2018-07-10 9:31 ` [PATCH v35 3/5] virtio-balloon: VIRTIO_BALLOON_F_FREE_PAGE_HINT Wei Wang
2018-07-10 9:31 ` [PATCH v35 4/5] mm/page_poison: expose page_poisoning_enabled to kernel modules Wei Wang
2018-07-10 9:31 ` [PATCH v35 5/5] virtio-balloon: VIRTIO_BALLOON_F_PAGE_POISON Wei Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180711070318-mutt-send-email-mst@kernel.org \
--to=mst@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=kvm@vger.kernel.org \
--cc=liliang.opensource@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@kernel.org \
--cc=nilal@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peterx@redhat.com \
--cc=quan.xu0@gmail.com \
--cc=riel@redhat.com \
--cc=torvalds@linux-foundation.org \
--cc=virtio-dev@lists.oasis-open.org \
--cc=virtualization@lists.linux-foundation.org \
--cc=wei.w.wang@intel.com \
--cc=yang.zhang.wz@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).