From: Matthew Wilcox <willy@infradead.org>
To: Pablo Neira Ayuso <pablo@netfilter.org>
Cc: Stephen Rothwell <sfr@canb.auug.org.au>,
NetFilter <netfilter-devel@vger.kernel.org>,
Linux-Next Mailing List <linux-next@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Varsha Rao <rvarsha016@gmail.com>
Subject: Re: linux-next: build failure after merge of the ida tree
Date: Wed, 18 Jul 2018 04:59:19 -0700 [thread overview]
Message-ID: <20180718115919.GB4949@bombadil.infradead.org> (raw)
In-Reply-To: <20180718092426.mxdti3jes5jsssta@salvia>
On Wed, Jul 18, 2018 at 11:24:26AM +0200, Pablo Neira Ayuso wrote:
> I see, we have no more lockless API for IDA anymore :-(. In our case,
> we were already protected by the the nfnl_lock mutex, which it was
> sufficient to ensure non-concurrent access to IDA structures.
You're actually the first user for whom this is true. For every other
user, the requirement to manage their own spinlock was a pain.
> Unless I'm missing anything, the new API forces use to the spinlock
> call with disabled irq for each time we update something from the
> netfilter netlink interface, so that's a no-go for us.
I can't believe that's a serious problem for you, though. You're calling
sscanf(), this can't possibly be a performance path.
next prev parent reply other threads:[~2018-07-18 11:59 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-18 6:54 linux-next: build failure after merge of the ida tree Stephen Rothwell
2018-07-18 9:24 ` Pablo Neira Ayuso
2018-07-18 11:59 ` Matthew Wilcox [this message]
2018-07-18 13:25 ` Pablo Neira Ayuso
2018-07-18 13:14 ` Matthew Wilcox
2018-07-18 13:27 ` Pablo Neira Ayuso
2018-07-18 13:31 ` Matthew Wilcox
2018-07-18 14:25 ` Pablo Neira Ayuso
-- strict thread matches above, loose matches on Subject: below --
2018-08-10 6:36 Stephen Rothwell
2018-07-05 5:13 Stephen Rothwell
2018-07-05 4:36 Stephen Rothwell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180718115919.GB4949@bombadil.infradead.org \
--to=willy@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
--cc=rvarsha016@gmail.com \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).