From: Miquel Raynal <miquel.raynal@bootlin.com>
To: Boris Brezillon <boris.brezillon@bootlin.com>
Cc: Abhishek Sahu <absahu@codeaurora.org>,
David Woodhouse <dwmw2@infradead.org>,
Brian Norris <computersforpeace@gmail.com>,
Marek Vasut <marek.vasut@gmail.com>,
Richard Weinberger <richard@nod.at>,
linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-mtd@lists.infradead.org, Andy Gross <andy.gross@linaro.org>
Subject: Re: [PATCH 4/5] mtd: rawnand: qcom: update BBT related flags
Date: Wed, 18 Jul 2018 23:42:55 +0200 [thread overview]
Message-ID: <20180718234255.4e51c188@xps13> (raw)
In-Reply-To: <20180718234144.158217f2@xps13>
Abhishek,
Miquel Raynal <miquel.raynal@bootlin.com> wrote on Wed, 18 Jul 2018
23:41:44 +0200:
> Hi Boris,
>
> Boris Brezillon <boris.brezillon@bootlin.com> wrote on Wed, 18 Jul 2018
> 23:36:37 +0200:
>
> > On Wed, 18 Jul 2018 23:15:26 +0200
> > Miquel Raynal <miquel.raynal@bootlin.com> wrote:
> >
> > > Hi Abhishek,
> > >
> > > Abhishek Sahu <absahu@codeaurora.org> wrote on Fri, 6 Jul 2018
> > > 13:21:58 +0530:
> > >
> > > > Remove the NAND_SKIP_BBTSCAN to use RAM based BBT.
> > >
> > > Unless I am understanding it the wrong way, NAND_SKIP_BBTSCAN will skip
> > > the scan of the on-chip BBT and will scan every block to construct a
> > > RAM, based BBT thanks to the BBM.
> > >
> > > So flash based BBT is already unused and removing this flag is a
> > > mistake, right?
> >
> > ->scan_bbt() is also taking care of building the in-RAM BBT based on
> > BBM when no on-flash BBT is provided, so I think it's the right thing
> > to do.
>
> Oh right. Then doing so is harmless.
Could you please update the commit log to reflect this aspect?
>
> Thanks for the clarification.
> Miquèl
next prev parent reply other threads:[~2018-07-18 21:43 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-06 7:51 [PATCH 0/5] Update for removing driver specific BBM functions Abhishek Sahu
2018-07-06 7:51 ` [PATCH 1/5] mtd: rawnand: qcom: remove driver specific bad block check function Abhishek Sahu
2018-07-06 7:51 ` [PATCH 2/5] mtd: rawnand: qcom: remove driver specific block_markbad function Abhishek Sahu
2018-07-18 21:23 ` Miquel Raynal
2018-07-18 21:43 ` Boris Brezillon
2018-07-20 12:16 ` Abhishek Sahu
2018-07-20 13:03 ` Boris Brezillon
2018-11-04 15:56 ` Boris Brezillon
2018-11-09 6:18 ` Abhishek Sahu
2018-07-06 7:51 ` [PATCH 3/5] mtd: rawnand: qcom: fix NAND register write errors Abhishek Sahu
2018-07-06 7:51 ` [PATCH 4/5] mtd: rawnand: qcom: update BBT related flags Abhishek Sahu
2018-07-18 21:15 ` Miquel Raynal
2018-07-18 21:36 ` Boris Brezillon
2018-07-18 21:41 ` Miquel Raynal
2018-07-18 21:42 ` Miquel Raynal [this message]
2018-07-20 7:14 ` Abhishek Sahu
2018-07-06 7:51 ` [PATCH 5/5] mtd: rawnand: qcom: reorganization by removing read/write helpers Abhishek Sahu
2018-07-18 21:29 ` Miquel Raynal
2018-07-18 21:54 ` Boris Brezillon
2018-07-28 10:20 ` Abhishek Sahu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180718234255.4e51c188@xps13 \
--to=miquel.raynal@bootlin.com \
--cc=absahu@codeaurora.org \
--cc=andy.gross@linaro.org \
--cc=boris.brezillon@bootlin.com \
--cc=computersforpeace@gmail.com \
--cc=dwmw2@infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=marek.vasut@gmail.com \
--cc=richard@nod.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).