From: Russell King - ARM Linux <linux@armlinux.org.uk>
To: Venkata Narendra Kumar Gutta <vnkgutta@codeaurora.org>
Cc: linux-arm-kernel@lists.infradead.org, tsoni@codeaurora.org,
ckadabi@codeaurora.org, rishabhb@codeaurora.org,
linux-kernel@vger.kernel.org, robh@kernel.org,
hoeun.ryu@gmail.com, adobriyan@gmail.com,
zhizhouzhang@asrmicro.com, suzuki.poulose@arm.com,
mark.rutland@arm.com, james.morse@arm.com, will.deacon@arm.com,
catalin.marinas@arm.com,
Abhimanyu Kapur <abhimany@codeaurora.org>
Subject: Re: [PATCH] ARM64: smp: Fix cpu_up() racing with sys_reboot
Date: Thu, 19 Jul 2018 23:55:38 +0100 [thread overview]
Message-ID: <20180719225538.GN17271@n2100.armlinux.org.uk> (raw)
In-Reply-To: <1532038726-3376-1-git-send-email-vnkgutta@codeaurora.org>
On Thu, Jul 19, 2018 at 03:18:46PM -0700, Venkata Narendra Kumar Gutta wrote:
> Nothing stops a process from hotplugging in a CPU concurrently
> with a sys_reboot() call. In such a situation we could have
> ipi_cpu_stop() mark a cpu as 'offline' and _cpu_up() ignore the
> fact that the CPU is not really offline and call the
> CPU_UP_PREPARE notifier. When this happens stop_machine code will
> complain that the cpu thread already exists and BUG_ON().
>
> CPU0 CPU1
>
> sys_reboot()
> kernel_restart()
> machine_restart()
> machine_shutdown()
> smp_send_stop()
> ... ipi_cpu_stop()
> set_cpu_online(1, false)
> local_irq_disable()
> while(1)
> <PREEMPT>
> cpu_up()
> _cpu_up()
> if (!cpu_online(1))
> __cpu_notify(CPU_UP_PREPARE...)
>
> cpu_stop_cpu_callback()
> BUG_ON(stopper->thread)
>
> This is easily reproducible by hotplugging in and out in a tight
> loop while also rebooting.
>
> Since the CPU is not really offline and hasn't gone through the
> proper steps to be marked as such, let's mark the CPU as inactive.
> This is just as easily testable as online and avoids any possibility
> of _cpu_up() trying to bring the CPU back online when it never was
> offline to begin with. Based on the similar patchset by for arm
> targets 040c163( "ARM: smp: Fix cpu_up() racing with sys_reboot)"
You really need to use 12 digit commit IDs to refer to commits to
avoid:
$ git log 040c163
fatal: ambiguous argument '040c163': unknown revision or path not in the working tree.
because 7 digits are just too short and given the size of the kernel,
result in conflicting references.
I can find no trace of "040c163" touching arch/arm/kernel/smp.c,
nor can I find a commit with "racing with sys_reboot" touching the
same file.
The commit you reference doesn't seem to be in mainline.
--
RMK's Patch system: http://www.armlinux.org.uk/developer/patches/
FTTC broadband for 0.8mile line in suburbia: sync at 13.8Mbps down 630kbps up
According to speedtest.net: 13Mbps down 490kbps up
next prev parent reply other threads:[~2018-07-19 22:55 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-19 22:18 [PATCH] ARM64: smp: Fix cpu_up() racing with sys_reboot Venkata Narendra Kumar Gutta
2018-07-19 22:55 ` Russell King - ARM Linux [this message]
2018-07-20 6:23 ` Mark Rutland
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180719225538.GN17271@n2100.armlinux.org.uk \
--to=linux@armlinux.org.uk \
--cc=abhimany@codeaurora.org \
--cc=adobriyan@gmail.com \
--cc=catalin.marinas@arm.com \
--cc=ckadabi@codeaurora.org \
--cc=hoeun.ryu@gmail.com \
--cc=james.morse@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=rishabhb@codeaurora.org \
--cc=robh@kernel.org \
--cc=suzuki.poulose@arm.com \
--cc=tsoni@codeaurora.org \
--cc=vnkgutta@codeaurora.org \
--cc=will.deacon@arm.com \
--cc=zhizhouzhang@asrmicro.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).