From: Chao Fan <fanc.fnst@cn.fujitsu.com>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: <linux-kernel@vger.kernel.org>, <x86@kernel.org>, <hpa@zytor.com>,
<mingo@redhat.com>, <bhe@redhat.com>, <keescook@chromium.org>,
<yasu.isimatu@gmail.com>, <indou.takao@jp.fujitsu.com>,
<lcapitulino@redhat.com>, <caoj.fnst@cn.fujitsu.com>,
<douly.fnst@cn.fujitsu.com>
Subject: Re: [PATCH v3 2/4] x86/boot: Add acpitb.c to parse acpi tables
Date: Fri, 20 Jul 2018 08:57:18 +0800 [thread overview]
Message-ID: <20180720005717.GA6914@localhost.localdomain> (raw)
In-Reply-To: <alpine.DEB.2.21.1807191720270.1693@nanos.tec.linutronix.de>
On Thu, Jul 19, 2018 at 05:22:35PM +0200, Thomas Gleixner wrote:
>On Tue, 17 Jul 2018, Chao Fan wrote:
>> +
>> +/* Search efi table for rsdp table. */
>> +static bool efi_get_rsdp_addr(acpi_physical_address *rsdp_addr)
>> +{
>> + efi_system_table_t *systab;
>> + bool find_rsdp = false;
>> + bool acpi_20 = false;
>> + bool efi_64 = false;
>> + void *config_tables;
>> + struct efi_info *e;
>> + char *sig;
>> + int size;
>> + int i;
>> +
>> +#ifndef CONFIG_EFI
>> + return false;
>> +#endif
>
>Please no. Wrap the whole function into CONFIG_EFI annd have a stub for the
>non EFI case returning false.
Yes, you are right. Will change it in the next version.
Thanks,
Chao Fan
>
>Thanks,
>
> tglx
>
>
next prev parent reply other threads:[~2018-07-20 0:59 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-17 10:04 [PATCH v3 0/4] x86/boot/KASLR: Parse ACPI table and limit kaslr in immovable memory Chao Fan
2018-07-17 10:04 ` [PATCH v3 1/4] x86/boot: Add acpitb.h to help parse acpi tables Chao Fan
2018-07-19 15:19 ` Thomas Gleixner
2018-07-20 9:35 ` Chao Fan
2018-07-17 10:04 ` [PATCH v3 2/4] x86/boot: Add acpitb.c to " Chao Fan
2018-07-19 15:22 ` Thomas Gleixner
2018-07-20 0:57 ` Chao Fan [this message]
2018-07-17 10:04 ` [PATCH v3 3/4] x86/boot/KASLR: Walk srat tables to filter immovable memory Chao Fan
2018-07-17 10:04 ` [PATCH v3 4/4] x86/boot/KASLR: Limit kaslr to choosing the " Chao Fan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180720005717.GA6914@localhost.localdomain \
--to=fanc.fnst@cn.fujitsu.com \
--cc=bhe@redhat.com \
--cc=caoj.fnst@cn.fujitsu.com \
--cc=douly.fnst@cn.fujitsu.com \
--cc=hpa@zytor.com \
--cc=indou.takao@jp.fujitsu.com \
--cc=keescook@chromium.org \
--cc=lcapitulino@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
--cc=yasu.isimatu@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).