From: Greg KH <gregkh@linuxfoundation.org>
To: Mark Railton <mark@markrailton.com>
Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Staging: pi433: rf69: fixed a multi line comment issue
Date: Sat, 21 Jul 2018 08:53:21 +0200 [thread overview]
Message-ID: <20180721065321.GB24909@kroah.com> (raw)
In-Reply-To: <20180719214318.388-1-mark@markrailton.com>
On Thu, Jul 19, 2018 at 10:43:18PM +0100, Mark Railton wrote:
> Fixed a coding style issue
>
> Signed-off-by: Mark Railton <mark@markrailton.com>
> ---
> drivers/staging/pi433/rf69.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/staging/pi433/rf69.c b/drivers/staging/pi433/rf69.c
> index 90280e9b006d..14826fb505dd 100644
> --- a/drivers/staging/pi433/rf69.c
> +++ b/drivers/staging/pi433/rf69.c
> @@ -618,7 +618,8 @@ bool rf69_get_flag(struct spi_device *spi, enum flag flag)
> case fifo_full:
> return (rf69_read_reg(spi, REG_IRQFLAGS2) & MASK_IRQFLAGS2_FIFO_FULL);
> /* case fifo_not_empty:
> - * return (rf69_read_reg(spi, REG_IRQFLAGS2) & MASK_IRQFLAGS2_FIFO_NOT_EMPTY); */
> + * return (rf69_read_reg(spi, REG_IRQFLAGS2) & MASK_IRQFLAGS2_FIFO_NOT_EMPTY);
> + */
Ick, just delete this whole thing if it isn't being used, don't make it
prettier :)
thanks,
greg k-h
next prev parent reply other threads:[~2018-07-21 6:53 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-19 21:43 [PATCH] Staging: pi433: rf69: fixed a multi line comment issue Mark Railton
2018-07-21 6:53 ` Greg KH [this message]
2018-07-21 12:26 ` Mark Railton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180721065321.GB24909@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=devel@driverdev.osuosl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark@markrailton.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).