From: kbuild test robot <lkp@intel.com>
To: Masami Hiramatsu <mhiramat@kernel.org>
Cc: kbuild-all@01.org, rostedt@goodmis.org,
Francis Deslauriers <francis.deslauriers@efficios.com>,
peterz@infradead.org, mhiramat@kernel.org,
mathieu.desnoyers@efficios.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/3] tracing: kprobes: Prohibit probing on notrace function
Date: Sat, 28 Jul 2018 16:24:04 +0800 [thread overview]
Message-ID: <201807281638.kHdz5DwF%fengguang.wu@intel.com> (raw)
In-Reply-To: <153258440707.11602.3706182300882155086.stgit@devbox>
[-- Attachment #1: Type: text/plain, Size: 1742 bytes --]
Hi Masami,
I love your patch! Yet something to improve:
[auto build test ERROR on tip/perf/core]
[also build test ERROR on v4.18-rc6 next-20180727]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
url: https://github.com/0day-ci/linux/commits/Masami-Hiramatsu/tracing-kprobes-Prohibit-probing-on-notrace-functions/20180728-145919
config: i386-randconfig-a0-201829 (attached as .config)
compiler: gcc-4.9 (Debian 4.9.4-2) 4.9.4
reproduce:
# save the attached .config to linux build tree
make ARCH=i386
All errors (new ones prefixed by >>):
kernel/trace/trace_kprobe.c: In function 'within_notrace_func':
>> kernel/trace/trace_kprobe.c:503:2: error: implicit declaration of function 'ftrace_location_range' [-Werror=implicit-function-declaration]
return !ftrace_location_range(addr - offset, addr - offset + size);
^
cc1: some warnings being treated as errors
vim +/ftrace_location_range +503 kernel/trace/trace_kprobe.c
489
490 #ifdef CONFIG_KPROBE_EVENTS_ON_NOTRACE
491 #define within_notrace_func(tk) (false)
492 #else
493 static bool within_notrace_func(struct trace_kprobe *tk)
494 {
495 unsigned long offset, size, addr;
496
497 addr = kallsyms_lookup_name(trace_kprobe_symbol(tk));
498 addr += trace_kprobe_offset(tk);
499
500 if (!kallsyms_lookup_size_offset(addr, &size, &offset))
501 return true; /* Out of range. */
502
> 503 return !ftrace_location_range(addr - offset, addr - offset + size);
504 }
505 #endif
506
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 28747 bytes --]
next prev parent reply other threads:[~2018-07-28 8:29 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-26 5:52 [PATCH v2 0/3] tracing: kprobes: Prohibit probing on notrace functions Masami Hiramatsu
2018-07-26 5:53 ` [PATCH v2 1/3] tracing: kprobes: Prohibit probing on notrace function Masami Hiramatsu
2018-07-28 1:00 ` Masami Hiramatsu
2018-07-28 8:11 ` kbuild test robot
2018-07-28 13:42 ` Masami Hiramatsu
2018-07-28 8:24 ` kbuild test robot [this message]
2018-07-26 5:53 ` [PATCH v2 2/3] selftest/ftrace: Move kprobe selftest function to separate compile unit Masami Hiramatsu
2018-07-26 23:29 ` Steven Rostedt
2018-07-27 12:39 ` Masami Hiramatsu
2018-07-27 12:44 ` [PATCH v2.1 " Masami Hiramatsu
2018-07-26 5:54 ` [PATCH v2 3/3] selftests/ftrace: Fix kprobe string testcase to not probe notrace function Masami Hiramatsu
2018-07-26 7:44 ` Masami Hiramatsu
2018-07-26 19:58 ` Steven Rostedt
2018-07-26 21:22 ` Shuah Khan
2018-07-27 12:47 ` Masami Hiramatsu
2018-07-27 14:26 ` Shuah Khan
2018-07-27 14:31 ` Steven Rostedt
2018-07-28 2:24 ` Masami Hiramatsu
2018-07-27 21:43 ` Steven Rostedt
2018-07-27 23:59 ` Masami Hiramatsu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201807281638.kHdz5DwF%fengguang.wu@intel.com \
--to=lkp@intel.com \
--cc=francis.deslauriers@efficios.com \
--cc=kbuild-all@01.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mathieu.desnoyers@efficios.com \
--cc=mhiramat@kernel.org \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).