From: MyungJoo Ham <myungjoo.ham@samsung.com>
To: Kyungmin Park <kyungmin.park@samsung.com>,
Chanwoo Choi <cw00.choi@samsung.com>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>
Cc: Saravana Kannan <skannan@codeaurora.org>,
"georgi.djakov@linaro.org" <georgi.djakov@linaro.org>,
"vincent.guittot@linaro.org" <vincent.guittot@linaro.org>,
"daidavid1@codeaurora.org" <daidavid1@codeaurora.org>,
"bjorn.andersson@linaro.org" <bjorn.andersson@linaro.org>,
"linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH v3 2/2] PM / devfreq: Add devfreq driver for interconnect bandwidth voting
Date: Thu, 02 Aug 2018 19:13:41 +0900 [thread overview]
Message-ID: <20180802101341epcms1p53ee79776dbcbeaf6f1e7910b20095220@epcms1p5> (raw)
In-Reply-To: <1533171465-25508-2-git-send-email-skannan@codeaurora.org>
>This driver registers itself as a devfreq device that allows devfreq
>governors to make bandwidth votes for an interconnect path. This allows
>applying various policies for different interconnect paths using devfreq
>governors.
>
First of all, the name, "devfreq_icbw", is not appropriate for a
devfreq device driver. It confuses; it looks like a part of the
framework itself.
>diff --git a/drivers/devfreq/devfreq_icbw.c b/drivers/devfreq/devfreq_icbw.c
>new file mode 100644
>index 0000000..231fb21
>--- /dev/null
>+++ b/drivers/devfreq/devfreq_icbw.c
>@@ -0,0 +1,116 @@
>+// SPDX-License-Identifier: GPL-2.0
>+/*
>+ * Copyright (c) 2013-2014, 2018, The Linux Foundation. All rights reserved.
>+ */
>+
>+#define pr_fmt(fmt) "icbw: " fmt
>+
>+#include <linux/kernel.h>
>+#include <linux/module.h>
>+#include <linux/init.h>
>+#include <linux/err.h>
>+#include <linux/errno.h>
>+#include <linux/mutex.h>
>+#include <linux/devfreq.h>
>+#include <linux/platform_device.h>
>+#include <linux/of.h>
>+#include <linux/interconnect.h>
Where can I find this file?
>+
>+struct dev_data {
>+ struct icc_path *path;
>+ u32 cur_ab;
>+ u32 cur_pb;
>+ unsigned long gov_ab;
>+ struct devfreq *df;
>+ struct devfreq_dev_profile dp;
>+};
>+
>+static int icbw_target(struct device *dev, unsigned long *freq, u32 flags)
>+{
>+ struct dev_data *d = dev_get_drvdata(dev);
>+ int ret;
>+ u32 new_pb = *freq, new_ab = d->gov_ab;
>+
>+ if (d->cur_pb == new_pb && d->cur_ab == new_ab)
>+ return 0;
>+
>+ dev_dbg(dev, "BW KBps: AB: %u PB: %u\n", new_ab, new_pb);
>+
>+ ret = icc_set(d->path, new_ab, new_pb);
I'm not sure if icc_set is available.
Cheers,
MyungJoo
next prev parent reply other threads:[~2018-08-02 10:13 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-02 0:57 [PATCH v3 2/2] PM / devfreq: Add devfreq driver for interconnect bandwidth voting Saravana Kannan
[not found] ` <CGME20180802005759epcas4p4a68d50e61c8425124a993de1917021a2@epcms1p5>
2018-08-02 10:13 ` MyungJoo Ham [this message]
2018-08-02 13:15 ` Georgi Djakov
2018-08-02 19:07 ` skannan
2018-08-07 16:51 ` Rob Herring
2018-08-07 19:31 ` skannan
2018-08-23 13:00 ` Georgi Djakov
2018-09-10 18:55 ` Sibi Sankar
2018-09-14 12:53 ` Sibi Sankar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180802101341epcms1p53ee79776dbcbeaf6f1e7910b20095220@epcms1p5 \
--to=myungjoo.ham@samsung.com \
--cc=bjorn.andersson@linaro.org \
--cc=cw00.choi@samsung.com \
--cc=daidavid1@codeaurora.org \
--cc=devicetree@vger.kernel.org \
--cc=georgi.djakov@linaro.org \
--cc=kyungmin.park@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
--cc=skannan@codeaurora.org \
--cc=vincent.guittot@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).