From: Mark Brown <broonie@kernel.org>
To: Baolin Wang <baolin.wang@linaro.org>
Cc: robh+dt@kernel.org, mark.rutland@arm.com, orsonzhai@gmail.com,
zhang.lyra@gmail.com, lanqing.liu@spreadtrum.com,
linux-spi@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] spi: sprd: Add SPI driver for Spreadtrum SC9860
Date: Tue, 7 Aug 2018 15:24:08 +0100 [thread overview]
Message-ID: <20180807142408.GB7958@sirena.org.uk> (raw)
In-Reply-To: <99befd2badc4dffb59662fca1e11d79f18b64755.1533638405.git.baolin.wang@linaro.org>
[-- Attachment #1: Type: text/plain, Size: 2985 bytes --]
On Tue, Aug 07, 2018 at 06:43:38PM +0800, Baolin Wang wrote:
> From: Lanqing Liu <lanqing.liu@spreadtrum.com>
>
> This patch adds the SPI controller driver for Spreadtrum SC9860 platform.
This all looks pretty clean, a few comments below but nothing too major:
> +static void sprd_spi_chipselect(struct spi_device *sdev, bool cs)
> +{
> + struct spi_controller *sctlr = sdev->controller;
> + struct sprd_spi *ss = spi_controller_get_devdata(sctlr);
> + u32 val;
> + int ret;
> +
> + ret = pm_runtime_get_sync(ss->dev);
> + if (ret < 0) {
> + dev_err(ss->dev, "failed to resume SPI controller\n");
> + return;
> + }
Something else further up the stack should probably have runtime PM
enabled already - we should only be changing chip select as part of a
bigger operation. If you use the core auto_runtime_pm feature this will
definitely happen.
> + bits_per_word = bits_per_word > 16 ? round_up(bits_per_word, 16) :
> + round_up(bits_per_word, 8);
Please
> + switch (bits_per_word) {
> + case 8:
> + case 16:
> + case 32:
It'd be nice to have a default case, the core should check for you but
it's nice to have defensive programming here.
> +static int sprd_spi_transfer_one(struct spi_controller *sctlr,
> + struct spi_device *sdev,
> + struct spi_transfer *t)
> +{
> + struct sprd_spi *ss = spi_controller_get_devdata(sctlr);
> + int ret;
> +
> + ret = pm_runtime_get_sync(ss->dev);
> + if (ret < 0) {
> + dev_err(ss->dev, "failed to resume SPI controller\n");
> + goto rpm_err;
> + }
Same thing with runtime PM here - the core can do this for you.
> +static int sprd_spi_setup(struct spi_device *spi_dev)
> +{
> + struct spi_controller *sctlr = spi_dev->controller;
> + struct sprd_spi *ss = spi_controller_get_devdata(sctlr);
> + int ret;
> +
> + ret = pm_runtime_get_sync(ss->dev);
> + if (ret < 0) {
> + dev_err(ss->dev, "failed to resume SPI controller\n");
> + return ret;
> + }
> +
> + ss->hw_mode = spi_dev->mode;
> + sprd_spi_init_hw(ss);
This can be called for one chip select while another is in progress so
it's not good to actually configure the hardware here unless the
configuration is in a chip select specific set of registers. Instead
you should defer to when the transfer is being set up.
> +static int sprd_spi_clk_init(struct platform_device *pdev, struct sprd_spi *ss)
> +{
> + struct clk *clk_spi, *clk_parent;
> +
> + clk_spi = devm_clk_get(&pdev->dev, "spi");
> + if (IS_ERR(clk_spi)) {
> + dev_warn(&pdev->dev, "can't get the spi clock\n");
> + clk_spi = NULL;
> + }
I suspect some of these clocks are essential and you should probably
return an error if you can't get them (especially if probe deferral
becomes a factor).
> + if (!clk_set_parent(clk_spi, clk_parent))
> + ss->src_clk = clk_get_rate(clk_spi);
> + else
> + ss->src_clk = SPRD_SPI_DEFAULT_SOURCE;
Are upstream DTs going to be missing the clock setup needed here?
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2018-08-07 14:24 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-07 10:43 [PATCH 1/2] dt-bindings: spi: Add Spreadtrum SPI controller documentation Baolin Wang
2018-08-07 10:43 ` [PATCH 2/2] spi: sprd: Add SPI driver for Spreadtrum SC9860 Baolin Wang
2018-08-07 14:24 ` Mark Brown [this message]
2018-08-08 2:45 ` Baolin Wang
2018-08-08 9:31 ` Mark Brown
2018-08-08 9:33 ` Baolin Wang
2018-08-07 17:10 ` Trent Piepho
2018-08-08 3:19 ` Baolin Wang
2018-08-08 19:08 ` Trent Piepho
2018-08-09 3:23 ` Baolin Wang
2018-08-07 13:41 ` [PATCH 1/2] dt-bindings: spi: Add Spreadtrum SPI controller documentation Mark Brown
2018-08-08 2:26 ` Baolin Wang
2018-08-08 9:50 ` Mark Brown
2018-08-08 10:35 ` Baolin Wang
2018-08-08 10:54 ` Mark Brown
2018-08-08 11:07 ` Baolin Wang
2018-08-08 18:57 ` Trent Piepho
2018-08-09 3:03 ` Baolin Wang
2018-08-14 20:27 ` Rob Herring
2018-08-15 2:17 ` Baolin Wang
2018-08-14 20:21 ` Rob Herring
2018-08-15 1:44 ` Baolin Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180807142408.GB7958@sirena.org.uk \
--to=broonie@kernel.org \
--cc=baolin.wang@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=lanqing.liu@spreadtrum.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=orsonzhai@gmail.com \
--cc=robh+dt@kernel.org \
--cc=zhang.lyra@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).