From: Bjorn Helgaas <helgaas@kernel.org>
To: Alex Williamson <alex.williamson@redhat.com>
Cc: linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-nvme@lists.infradead.org
Subject: Re: [PATCH v4 0/3] PCI: NVMe reset quirks
Date: Thu, 9 Aug 2018 15:23:40 -0500 [thread overview]
Message-ID: <20180809202340.GE113140@bhelgaas-glaptop.roam.corp.google.com> (raw)
In-Reply-To: <153384487209.15793.15203778129263981368.stgit@gimli.home>
On Thu, Aug 09, 2018 at 02:04:03PM -0600, Alex Williamson wrote:
> v4: Fix 0-day i386 build error for readq, simply use readl
> instead, the bits we're interested in are 24:31 and the NVMe
> spec indicates that smaller, aligned accesses are allowed.
> Update bz links for both device specific resets.
>
> v3: Separate quirks, only for the afflicted devices
>
> v2: Add bug link, use Samsung vendor ID, add spec references
>
> Fix two different NVMe device reset issues with device specific
> quirks. The Samsung controller in patch 2 sometimes doesn't like
> being reset while enabled, so disable the NVMe controller prior to
> FLR. This quirk is generic to all NVMe class devices, though I've
> dropped the additional delay some devices require between disabling
> and checking ready status. This can be added later should any of
> those devices need this quirk. The Intel controller quirk is now
> just a simple delay after FLR, which clearly any device needing
> similar behavior can also use. Thanks,
>
> Alex
>
> ---
>
> Alex Williamson (3):
> PCI: Export pcie_has_flr()
> PCI: Samsung SM961/PM961 NVMe disable before FLR quirk
> PCI: Intel DC P3700 NVMe delay after FLR quirk
>
>
> drivers/pci/pci.c | 3 +
> drivers/pci/quirks.c | 105 ++++++++++++++++++++++++++++++++++++++++++++++++++
> include/linux/pci.h | 1
> 3 files changed, 108 insertions(+), 1 deletion(-)
Applied to pci/virtualization for v4.19, thanks!
prev parent reply other threads:[~2018-08-09 20:23 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-09 20:04 [PATCH v4 0/3] PCI: NVMe reset quirks Alex Williamson
2018-08-09 20:04 ` [PATCH v4 1/3] PCI: Export pcie_has_flr() Alex Williamson
2018-08-09 20:04 ` [PATCH v4 2/3] PCI: Samsung SM961/PM961 NVMe disable before FLR quirk Alex Williamson
2018-08-09 20:04 ` [PATCH v4 3/3] PCI: Intel DC P3700 NVMe delay after " Alex Williamson
2018-08-09 20:23 ` Bjorn Helgaas [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180809202340.GE113140@bhelgaas-glaptop.roam.corp.google.com \
--to=helgaas@kernel.org \
--cc=alex.williamson@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=linux-pci@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).