From: Lina Iyer <ilina@codeaurora.org>
To: Marc Zyngier <marc.zyngier@arm.com>
Cc: swboyd@chromium.org, evgreen@chromium.org,
linus.walleij@linaro.org, bjorn.andersson@linaro.org,
rplsssn@codeaurora.org, linux-kernel@vger.kernel.org,
linux-arm-msm@vger.kernel.org, rnayak@codeaurora.org,
devicetree@vger.kernel.org
Subject: Re: [PATCH RESEND RFC 2/4] drivers: pinctrl: qcom: add wakeup gpio map for sdm845
Date: Mon, 13 Aug 2018 13:41:52 -0600 [thread overview]
Message-ID: <20180813194152.GG5081@codeaurora.org> (raw)
In-Reply-To: <20180801200405.GB6422@codeaurora.org>
On Wed, Aug 01 2018 at 14:04 -0600, Lina Iyer wrote:
>On Wed, Aug 01 2018 at 02:42 -0600, Marc Zyngier wrote:
>>On Wed, 01 Aug 2018 03:00:19 +0100,
>>Lina Iyer <ilina@codeaurora.org> wrote:
>>>
>>>Add GPIO to PDC pin map for the SDM845 SoC.
>>>
>>>Signed-off-by: Lina Iyer <ilina@codeaurora.org>
>>>---
>>> drivers/pinctrl/qcom/pinctrl-sdm845.c | 76 +++++++++++++++++++++++++++
>>> 1 file changed, 76 insertions(+)
>>>
>>>diff --git a/drivers/pinctrl/qcom/pinctrl-sdm845.c b/drivers/pinctrl/qcom/pinctrl-sdm845.c
>>>index 2ab7a8885757..e93660922dc2 100644
>>>--- a/drivers/pinctrl/qcom/pinctrl-sdm845.c
>>>+++ b/drivers/pinctrl/qcom/pinctrl-sdm845.c
>>>@@ -1277,6 +1277,80 @@ static const struct msm_pingroup sdm845_groups[] = {
>>> UFS_RESET(ufs_reset, 0x99f000),
>>> };
>>>
>>>+static struct msm_pinctrl_pdc_map sdm845_wakeup_gpios[] = {
>>
>>[huge array]
>>
>>>+};
>>
>>Why isn't that array part of the DT? I'd expect other SoCs to
>>eventually use a similar mechanism, no?
>>
>I agree and it should be.
>
>One place I am thinking is to add it to the DT definition of PDC
>controller as a data argument -
>
> tlmm: pinctrl@000000{
> [...]
> interrupts-extended = <&pdc 30 IRQ_TYPE_LEVEL_HIGH 1>,
> <&pdc 31 IRQ_TYPE_LEVEL_HIGH 3>,
> <&pdc 32 IRQ_TYPE_LEVEL_HIGH 5>,
> ^
> |--- Provide the GPIO
> for the PDC pin here.
> };
>
> pdc: interrupt-controller@b220000 {
> compatible = "qcom,sdm845-pdc";
> reg = <0xb220000 0x30000>;
> qcom,pdc-ranges = <0 512 94>, <94 641 15>, <115 662 7>;
> #interrupt-cells = <3>; <-------- Increase this from 2 ?
> interrupt-parent = <&intc>;
> interrupt-controller;
> };
>
>Would that be acceptable?
>
Any ideas on how to do this better?
>Thanks,
>Lina
next prev parent reply other threads:[~2018-08-13 19:41 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-01 2:00 [PATCH RESEND RFC 0/4] Wakeup GPIO support for SDM845 SoC Lina Iyer
2018-08-01 2:00 ` [PATCH RESEND RFC 1/4] drivers: pinctrl: qcom: add wakeup capability to GPIO Lina Iyer
2018-08-01 6:31 ` Marc Zyngier
2018-08-01 19:45 ` Lina Iyer
2018-08-01 22:36 ` Bjorn Andersson
2018-08-02 2:10 ` Lina Iyer
2018-08-02 6:08 ` Marc Zyngier
2018-08-02 6:51 ` Lina Iyer
2018-08-02 7:27 ` Marc Zyngier
2018-08-02 12:58 ` Lina Iyer
2018-08-08 6:05 ` Stephen Boyd
2018-08-08 6:26 ` Marc Zyngier
2018-08-09 17:30 ` Stephen Boyd
2018-08-10 7:45 ` Marc Zyngier
2018-08-10 15:06 ` Stephen Boyd
2018-08-10 16:15 ` Lina Iyer
2018-08-01 2:00 ` [PATCH RESEND RFC 2/4] drivers: pinctrl: qcom: add wakeup gpio map for sdm845 Lina Iyer
2018-08-01 8:42 ` Marc Zyngier
2018-08-01 20:04 ` Lina Iyer
2018-08-13 19:41 ` Lina Iyer [this message]
2018-08-14 9:26 ` Marc Zyngier
2018-08-01 2:00 ` [PATCH RESEND RFC 3/4] arm64: dts: msm: add PDC device bindings " Lina Iyer
2018-08-01 2:00 ` [PATCH RESEND RFC 4/4] arm64: dts: qcom: add wake up interrupts for GPIOs Lina Iyer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180813194152.GG5081@codeaurora.org \
--to=ilina@codeaurora.org \
--cc=bjorn.andersson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=evgreen@chromium.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marc.zyngier@arm.com \
--cc=rnayak@codeaurora.org \
--cc=rplsssn@codeaurora.org \
--cc=swboyd@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).