From: Torsten Duwe <duwe@lst.de>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: Julien Thierry <julien.thierry@arm.com>,
Will Deacon <will.deacon@arm.com>,
Catalin Marinas <catalin.marinas@arm.com>,
Ingo Molnar <mingo@redhat.com>,
Ard Biesheuvel <ard.biesheuvel@linaro.org>,
Arnd Bergmann <arnd@arndb.de>,
AKASHI Takahiro <takahiro.akashi@linaro.org>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, live-patching@vger.kernel.org
Subject: Re: [PATCH 1/3] arm64: implement ftrace with regs
Date: Wed, 15 Aug 2018 15:47:10 +0200 [thread overview]
Message-ID: <20180815134710.GA27854@lst.de> (raw)
In-Reply-To: <20180814120433.1f5e8da1@gandalf.local.home>
[working on V2 with your feedback]
On Tue, Aug 14, 2018 at 12:04:33PM -0400, Steven Rostedt wrote:
> On Tue, 14 Aug 2018 09:33:52 +0100
> Julien Thierry <julien.thierry@arm.com> wrote:
> > >> Shouldn't this be an error? The option -fpatchable-function-entry has
> > >> been added to the CC_FLAGS_FTRACE, so any call to the compiler is gonna
> > >> break anyway. Or am I missing something?
This should be the case.
> OK, I see what you mean. If the resulting build wont boot, then yes
> this should be an error and not a warning.
No, there won't be a binary because the first gcc invocation with
CC_FLAGS_FTRACE will error out.
The alternatives are a makefile-warning followed by a gcc-error or just
a makefile-error. The makefile warning or error should hint at the causing
config option, that's the key point. Beyond that I don't have any preference.
Torsten
next prev parent reply other threads:[~2018-08-15 13:46 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-10 16:00 [PATCH 0/3] arm64 live patching Torsten Duwe
2018-08-10 16:02 ` [PATCH 1/3] arm64: implement ftrace with regs Torsten Duwe
2018-08-10 19:27 ` Steven Rostedt
2018-08-13 10:54 ` Julien Thierry
2018-08-14 2:03 ` Steven Rostedt
2018-08-14 8:33 ` Julien Thierry
2018-08-14 16:04 ` Steven Rostedt
2018-08-15 13:47 ` Torsten Duwe [this message]
2018-08-10 16:03 ` [PATCH 2/3] arm64: implement live patching Torsten Duwe
2018-08-29 11:37 ` Miroslav Benes
2018-08-10 16:03 ` [PATCH 3/3] arm64: reliable stacktraces Torsten Duwe
2018-08-10 20:44 ` Josh Poimboeuf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180815134710.GA27854@lst.de \
--to=duwe@lst.de \
--cc=ard.biesheuvel@linaro.org \
--cc=arnd@arndb.de \
--cc=catalin.marinas@arm.com \
--cc=julien.thierry@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=live-patching@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=rostedt@goodmis.org \
--cc=takahiro.akashi@linaro.org \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).