From: Wei Yang <richard.weiyang@gmail.com>
To: Oscar Salvador <osalvador@techadventures.net>
Cc: David Hildenbrand <david@redhat.com>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
Andrew Morton <akpm@linux-foundation.org>,
Michal Hocko <mhocko@suse.com>, Vlastimil Babka <vbabka@suse.cz>,
Stephen Rothwell <sfr@canb.auug.org.au>,
Pavel Tatashin <pasha.tatashin@oracle.com>,
Kemi Wang <kemi.wang@intel.com>,
David Rientjes <rientjes@google.com>,
Jia He <jia.he@hxt-semitech.com>,
Oscar Salvador <osalvador@suse.de>,
Petr Tesarik <ptesarik@suse.com>,
Andrey Ryabinin <aryabinin@virtuozzo.com>,
Dan Williams <dan.j.williams@intel.com>,
Mathieu Malaterre <malat@debian.org>, Baoquan He <bhe@redhat.com>,
Wei Yang <richard.weiyang@gmail.com>,
Ross Zwisler <zwisler@kernel.org>,
"Kirill A . Shutemov" <kirill.shutemov@linux.intel.com>
Subject: Re: [PATCH v1 5/5] mm/memory_hotplug: print only with DEBUG_VM in online/offline_pages()
Date: Sun, 19 Aug 2018 20:34:03 +0800 [thread overview]
Message-ID: <20180819123403.GA22352@WeideMacBook-Pro.local> (raw)
In-Reply-To: <20180817081853.GB17638@techadventures.net>
On Fri, Aug 17, 2018 at 10:18:53AM +0200, Oscar Salvador wrote:
>> failed_addition:
>> +#ifdef CONFIG_DEBUG_VM
>> pr_debug("online_pages [mem %#010llx-%#010llx] failed\n",
>> (unsigned long long) pfn << PAGE_SHIFT,
>> (((unsigned long long) pfn + nr_pages) << PAGE_SHIFT) - 1);
>> +#endif
>
>I have never been sure about this.
>IMO, if I fail to online pages, I want to know I failed.
>I think that pr_err would be better than pr_debug and without CONFIG_DEBUG_VM.
>
>But at least, if not, envolve it with a CONFIG_DEBUG_VM, but change pr_debug to pr_info.
>
I don't have a clear rule about these debug macro neither.
While when you look at the page related logs in calculate_node_totalpages(),
it is KERNEL_DEBUG level and without any config macro.
Maybe we should leave them at the same state?
>> +#ifdef CONFIG_DEBUG_VM
>> pr_debug("memory offlining [mem %#010llx-%#010llx] failed\n",
>> (unsigned long long) start_pfn << PAGE_SHIFT,
>> ((unsigned long long) end_pfn << PAGE_SHIFT) - 1);
>> +#endif
>
>Same goes here.
>
>Thanks
>--
>Oscar Salvador
>SUSE L3
--
Wei Yang
Help you, Help me
next prev parent reply other threads:[~2018-08-19 12:34 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-16 10:06 [PATCH v1 0/5] mm/memory_hotplug: online/offline_pages refactorings David Hildenbrand
2018-08-16 10:06 ` [PATCH v1 1/5] mm/memory_hotplug: drop intermediate __offline_pages David Hildenbrand
2018-08-16 11:44 ` Stephen Rothwell
2018-08-16 12:08 ` David Hildenbrand
2018-08-16 18:50 ` kbuild test robot
2018-08-30 20:17 ` Pasha Tatashin
2018-08-30 20:20 ` Pasha Tatashin
2018-08-16 10:06 ` [PATCH v1 2/5] mm/memory_hotplug: enforce section alignment when onlining/offlining David Hildenbrand
2018-08-16 12:34 ` Oscar Salvador
2018-08-30 22:14 ` Pasha Tatashin
2018-08-31 7:51 ` David Hildenbrand
2018-08-16 10:06 ` [PATCH v1 3/5] mm/memory_hotplug: check if sections are already online/offline David Hildenbrand
2018-08-16 10:47 ` Oscar Salvador
2018-08-16 11:00 ` David Hildenbrand
2018-08-30 22:17 ` Pasha Tatashin
2018-08-16 10:06 ` [PATCH v1 4/5] mm/memory_hotplug: onlining pages can only fail due to notifiers David Hildenbrand
2018-08-30 22:30 ` Pasha Tatashin
2018-08-16 10:06 ` [PATCH v1 5/5] mm/memory_hotplug: print only with DEBUG_VM in online/offline_pages() David Hildenbrand
2018-08-17 8:18 ` Oscar Salvador
2018-08-19 12:34 ` Wei Yang [this message]
2018-08-20 9:57 ` David Hildenbrand
2018-08-20 13:12 ` Wei Yang
2018-08-20 9:45 ` David Hildenbrand
2018-08-20 9:49 ` David Hildenbrand
2018-08-20 10:46 ` David Hildenbrand
2018-08-30 22:36 ` Pasha Tatashin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180819123403.GA22352@WeideMacBook-Pro.local \
--to=richard.weiyang@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=aryabinin@virtuozzo.com \
--cc=bhe@redhat.com \
--cc=dan.j.williams@intel.com \
--cc=david@redhat.com \
--cc=jia.he@hxt-semitech.com \
--cc=kemi.wang@intel.com \
--cc=kirill.shutemov@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=malat@debian.org \
--cc=mhocko@suse.com \
--cc=osalvador@suse.de \
--cc=osalvador@techadventures.net \
--cc=pasha.tatashin@oracle.com \
--cc=ptesarik@suse.com \
--cc=rientjes@google.com \
--cc=sfr@canb.auug.org.au \
--cc=vbabka@suse.cz \
--cc=zwisler@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).