From: Andi Kleen <ak@linux.intel.com>
To: Vlastimil Babka <vbabka@suse.cz>
Cc: Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, "H . Peter Anvin" <hpa@zytor.com>,
x86@kernel.org, linux-kernel@vger.kernel.org,
Linus Torvalds <torvalds@linux-foundation.org>,
Dave Hansen <dave.hansen@intel.com>,
Michal Hocko <mhocko@kernel.org>,
stable@vger.kernel.org, Adrian Schroeter <adrian@suse.de>,
Dominique Leuenberger <dimstar@suse.de>
Subject: Re: [PATCH] x86/speculation/l1tf: fix overflow on l1tf_pfn_limit() on 32bit
Date: Mon, 20 Aug 2018 07:20:27 -0700 [thread overview]
Message-ID: <20180820142027.GL12066@tassilo.jf.intel.com> (raw)
In-Reply-To: <20180820095835.5298-1-vbabka@suse.cz>
On Mon, Aug 20, 2018 at 11:58:35AM +0200, Vlastimil Babka wrote:
> On 32bit PAE kernels on 64bit hardware with enough physical bits,
> l1tf_pfn_limit() will overflow unsigned long. This in turn affects
> max_swapfile_size() and can lead to swapon returning -EINVAL. This has been
> observed in a 32bit guest with 42 bits physical address size, where
> max_swapfile_size() overflows exactly to 1 << 32, thus zero, and produces the
> following warning to dmesg:
>
> [ 6.396845] Truncating oversized swap area, only using 0k out of 2047996k
>
> Fix this by using unsigned long long instead.
Looks good.
Acked-by: Andi Kleen <ak@linux.intel.com>
BTW our much worse problems right now are crash reports on several
stable kernels, especially with large pages
I'll dig into this more today, but if you have any hints from testing/fixing
your own backports please share them.
-Andi
next prev parent reply other threads:[~2018-08-20 14:20 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-20 9:58 [PATCH] x86/speculation/l1tf: fix overflow on l1tf_pfn_limit() on 32bit Vlastimil Babka
2018-08-20 10:49 ` Michal Hocko
2018-08-20 11:41 ` Vlastimil Babka
2018-08-20 14:27 ` Michal Hocko
2018-08-20 14:20 ` Andi Kleen [this message]
2018-08-20 14:26 ` Michal Hocko
2018-08-20 15:42 ` Andi Kleen
2018-08-20 16:11 ` [tip:x86/urgent] x86/speculation/l1tf: Fix overflow in " tip-bot for Vlastimil Babka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180820142027.GL12066@tassilo.jf.intel.com \
--to=ak@linux.intel.com \
--cc=adrian@suse.de \
--cc=dave.hansen@intel.com \
--cc=dimstar@suse.de \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mhocko@kernel.org \
--cc=mingo@redhat.com \
--cc=stable@vger.kernel.org \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
--cc=vbabka@suse.cz \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).