From: Jaegeuk Kim <jaegeuk@kernel.org>
To: Chao Yu <chao@kernel.org>
Cc: Chao Yu <yuchao0@huawei.com>,
linux-f2fs-devel@lists.sourceforge.net,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] f2fs: fix to avoid quota inode leak in ->put_super
Date: Mon, 20 Aug 2018 19:38:40 -0700 [thread overview]
Message-ID: <20180821023840.GD20263@jaegeuk-macbookpro.roam.corp.google.com> (raw)
In-Reply-To: <b10c4ae6-2a25-fb0b-cbfa-467b5e988b47@kernel.org>
On 08/20, Chao Yu wrote:
> On 2018/8/18 23:16, Jaegeuk Kim wrote:
> > On 08/17, Chao Yu wrote:
> >> generic/019 reports below error:
> >>
> >> __quota_error: 1160 callbacks suppressed
> >> Quota error (device zram1): write_blk: dquota write failed
> >> Quota error (device zram1): qtree_write_dquot: Error -28 occurred while creating quota
> >> Quota error (device zram1): write_blk: dquota write failed
> >> Quota error (device zram1): qtree_write_dquot: Error -28 occurred while creating quota
> >> Quota error (device zram1): write_blk: dquota write failed
> >> Quota error (device zram1): qtree_write_dquot: Error -28 occurred while creating quota
> >> Quota error (device zram1): write_blk: dquota write failed
> >> Quota error (device zram1): qtree_write_dquot: Error -28 occurred while creating quota
> >> Quota error (device zram1): write_blk: dquota write failed
> >> Quota error (device zram1): qtree_write_dquot: Error -28 occurred while creating quota
> >> VFS: Busy inodes after unmount of zram1. Self-destruct in 5 seconds. Have a nice day...
> >>
> >> If we failed in below path due to fail to write dquot block, we will miss
> >> to release quota inode, fix it.
> >>
> >> - f2fs_put_super
> >> - f2fs_quota_off_umount
> >> - f2fs_quota_off
> >> - f2fs_quota_sync <-- failed
> >> - dquot_quota_off <-- missed to call
> >>
> >> Signed-off-by: Chao Yu <yuchao0@huawei.com>
> >> ---
> >> fs/f2fs/super.c | 6 ++++--
> >> 1 file changed, 4 insertions(+), 2 deletions(-)
> >>
> >> diff --git a/fs/f2fs/super.c b/fs/f2fs/super.c
> >> index a5df9fbc6355..9647bbcdfd2b 100644
> >> --- a/fs/f2fs/super.c
> >> +++ b/fs/f2fs/super.c
> >> @@ -1977,10 +1977,12 @@ void f2fs_quota_off_umount(struct super_block *sb)
> >> for (type = 0; type < MAXQUOTAS; type++) {
> >> err = f2fs_quota_off(sb, type);
> >> if (err) {
> >> + int ret = dquot_quota_off(sb, type);
> >> +
> >
> > Could you check the mainline version?
>
> I guess we missed to apply below patch? Could you check that?
>
> f2fs: report error if quota off error during umount
I remember there was a bug in the patch.
>
> Thanks,
>
> >
> >> f2fs_msg(sb, KERN_ERR,
> >> "Fail to turn off disk quota "
> >> - "(type: %d, err: %d), Please "
> >> - "run fsck to fix it.", type, err);
> >> + "(type: %d, err: %d, ret:%d), Please "
> >> + "run fsck to fix it.", type, err, ret);
> >> set_sbi_flag(F2FS_SB(sb), SBI_NEED_FSCK);
> >> }
> >> }
> >> --
> >> 2.18.0.rc1
next prev parent reply other threads:[~2018-08-21 2:38 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-17 9:18 [PATCH 1/2] f2fs: fix to avoid quota inode leak in ->put_super Chao Yu
2018-08-17 9:18 ` [PATCH 2/2] f2fs: guarantee journalled quota data by checkpoint Chao Yu
2018-08-18 15:35 ` Jaegeuk Kim
2018-08-18 15:16 ` [PATCH 1/2] f2fs: fix to avoid quota inode leak in ->put_super Jaegeuk Kim
2018-08-20 12:33 ` Chao Yu
2018-08-21 2:38 ` Jaegeuk Kim [this message]
2018-08-21 3:35 ` Chao Yu
2018-08-29 2:05 ` Jaegeuk Kim
2018-08-29 2:15 ` Chao Yu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180821023840.GD20263@jaegeuk-macbookpro.roam.corp.google.com \
--to=jaegeuk@kernel.org \
--cc=chao@kernel.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=yuchao0@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).