linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Rob Herring <robh@kernel.org>
To: linux-kernel@vger.kernel.org
Cc: Liam Girdwood <lgirdwood@gmail.com>,
	Mark Brown <broonie@kernel.org>,
	Sangbeom Kim <sbkim73@samsung.com>,
	Krzysztof Kozlowski <krzk@kernel.org>,
	Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
	linux-samsung-soc@vger.kernel.org
Subject: [PATCH] regulator: Convert to using %pOFn instead of device_node.name
Date: Mon, 27 Aug 2018 20:52:42 -0500	[thread overview]
Message-ID: <20180828015252.28511-41-robh@kernel.org> (raw)
In-Reply-To: <20180828015252.28511-1-robh@kernel.org>

In preparation to remove the node name pointer from struct device_node,
convert printf users to use the %pOFn format specifier.

Cc: Liam Girdwood <lgirdwood@gmail.com>
Cc: Mark Brown <broonie@kernel.org>
Cc: Sangbeom Kim <sbkim73@samsung.com>
Cc: Krzysztof Kozlowski <krzk@kernel.org>
Cc: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
Cc: linux-samsung-soc@vger.kernel.org
Signed-off-by: Rob Herring <robh@kernel.org>
---
 drivers/regulator/max8997-regulator.c      |  4 +-
 drivers/regulator/mc13xxx-regulator-core.c |  2 +-
 drivers/regulator/of_regulator.c           | 44 +++++++++++-----------
 drivers/regulator/qcom-rpmh-regulator.c    | 14 +++----
 drivers/regulator/s5m8767.c                | 12 +++---
 5 files changed, 38 insertions(+), 38 deletions(-)

diff --git a/drivers/regulator/max8997-regulator.c b/drivers/regulator/max8997-regulator.c
index ad0c806b0737..3bf5ddfaaea8 100644
--- a/drivers/regulator/max8997-regulator.c
+++ b/drivers/regulator/max8997-regulator.c
@@ -929,8 +929,8 @@ static int max8997_pmic_dt_parse_pdata(struct platform_device *pdev,
 				break;
 
 		if (i == ARRAY_SIZE(regulators)) {
-			dev_warn(&pdev->dev, "don't know how to configure regulator %s\n",
-				 reg_np->name);
+			dev_warn(&pdev->dev, "don't know how to configure regulator %pOFn\n",
+				 reg_np);
 			continue;
 		}
 
diff --git a/drivers/regulator/mc13xxx-regulator-core.c b/drivers/regulator/mc13xxx-regulator-core.c
index da4fb9824757..65eb1e0350cf 100644
--- a/drivers/regulator/mc13xxx-regulator-core.c
+++ b/drivers/regulator/mc13xxx-regulator-core.c
@@ -203,7 +203,7 @@ struct mc13xxx_regulator_init_data *mc13xxx_parse_regulators_dt(
 
 		if (!found)
 			dev_warn(&pdev->dev,
-				 "Unknown regulator: %s\n", child->name);
+				 "Unknown regulator: %pOFn\n", child);
 	}
 	of_node_put(parent);
 
diff --git a/drivers/regulator/of_regulator.c b/drivers/regulator/of_regulator.c
index 638f17d4c848..92a516b959a7 100644
--- a/drivers/regulator/of_regulator.c
+++ b/drivers/regulator/of_regulator.c
@@ -95,8 +95,8 @@ static void of_get_regulation_constraints(struct device_node *np,
 	if (!ret)
 		constraints->settling_time_up = pval;
 	if (constraints->settling_time_up && constraints->settling_time) {
-		pr_warn("%s: ambiguous configuration for settling time, ignoring 'regulator-settling-time-up-us'\n",
-			np->name);
+		pr_warn("%pOFn: ambiguous configuration for settling time, ignoring 'regulator-settling-time-up-us'\n",
+			np);
 		constraints->settling_time_up = 0;
 	}
 
@@ -105,8 +105,8 @@ static void of_get_regulation_constraints(struct device_node *np,
 	if (!ret)
 		constraints->settling_time_down = pval;
 	if (constraints->settling_time_down && constraints->settling_time) {
-		pr_warn("%s: ambiguous configuration for settling time, ignoring 'regulator-settling-time-down-us'\n",
-			np->name);
+		pr_warn("%pOFn: ambiguous configuration for settling time, ignoring 'regulator-settling-time-down-us'\n",
+			np);
 		constraints->settling_time_down = 0;
 	}
 
@@ -127,12 +127,12 @@ static void of_get_regulation_constraints(struct device_node *np,
 		if (desc && desc->of_map_mode) {
 			mode = desc->of_map_mode(pval);
 			if (mode == REGULATOR_MODE_INVALID)
-				pr_err("%s: invalid mode %u\n", np->name, pval);
+				pr_err("%pOFn: invalid mode %u\n", np, pval);
 			else
 				constraints->initial_mode = mode;
 		} else {
-			pr_warn("%s: mapping for mode %d not defined\n",
-				np->name, pval);
+			pr_warn("%pOFn: mapping for mode %d not defined\n",
+				np, pval);
 		}
 	}
 
@@ -144,14 +144,14 @@ static void of_get_regulation_constraints(struct device_node *np,
 				ret = of_property_read_u32_index(np,
 					"regulator-allowed-modes", i, &pval);
 				if (ret) {
-					pr_err("%s: couldn't read allowed modes index %d, ret=%d\n",
-						np->name, i, ret);
+					pr_err("%pOFn: couldn't read allowed modes index %d, ret=%d\n",
+						np, i, ret);
 					break;
 				}
 				mode = desc->of_map_mode(pval);
 				if (mode == REGULATOR_MODE_INVALID)
-					pr_err("%s: invalid regulator-allowed-modes element %u\n",
-						np->name, pval);
+					pr_err("%pOFn: invalid regulator-allowed-modes element %u\n",
+						np, pval);
 				else
 					constraints->valid_modes_mask |= mode;
 			}
@@ -159,7 +159,7 @@ static void of_get_regulation_constraints(struct device_node *np,
 				constraints->valid_ops_mask
 					|= REGULATOR_CHANGE_MODE;
 		} else {
-			pr_warn("%s: mode mapping not defined\n", np->name);
+			pr_warn("%pOFn: mode mapping not defined\n", np);
 		}
 	}
 
@@ -197,13 +197,13 @@ static void of_get_regulation_constraints(struct device_node *np,
 			if (desc && desc->of_map_mode) {
 				mode = desc->of_map_mode(pval);
 				if (mode == REGULATOR_MODE_INVALID)
-					pr_err("%s: invalid mode %u\n",
-					       np->name, pval);
+					pr_err("%pOFn: invalid mode %u\n",
+					       np, pval);
 				else
 					suspend_state->mode = mode;
 			} else {
-				pr_warn("%s: mapping for mode %d not defined\n",
-					np->name, pval);
+				pr_warn("%pOFn: mapping for mode %d not defined\n",
+					np, pval);
 			}
 		}
 
@@ -351,8 +351,8 @@ int of_regulator_match(struct device *dev, struct device_node *node,
 							   match->desc);
 			if (!match->init_data) {
 				dev_err(dev,
-					"failed to parse DT for regulator %s\n",
-					child->name);
+					"failed to parse DT for regulator %pOFn\n",
+					child);
 				of_node_put(child);
 				return -EINVAL;
 			}
@@ -401,16 +401,16 @@ struct regulator_init_data *regulator_of_get_init_data(struct device *dev,
 		init_data = of_get_regulator_init_data(dev, child, desc);
 		if (!init_data) {
 			dev_err(dev,
-				"failed to parse DT for regulator %s\n",
-				child->name);
+				"failed to parse DT for regulator %pOFn\n",
+				child);
 			break;
 		}
 
 		if (desc->of_parse_cb) {
 			if (desc->of_parse_cb(child, desc, config)) {
 				dev_err(dev,
-					"driver callback failed to parse DT for regulator %s\n",
-					child->name);
+					"driver callback failed to parse DT for regulator %pOFn\n",
+					child);
 				init_data = NULL;
 				break;
 			}
diff --git a/drivers/regulator/qcom-rpmh-regulator.c b/drivers/regulator/qcom-rpmh-regulator.c
index 9f27daebd8c8..301e7f695374 100644
--- a/drivers/regulator/qcom-rpmh-regulator.c
+++ b/drivers/regulator/qcom-rpmh-regulator.c
@@ -414,7 +414,7 @@ static int rpmh_regulator_init_vreg(struct rpmh_vreg *vreg, struct device *dev,
 			break;
 
 	if (!rpmh_data->name) {
-		dev_err(dev, "Unknown regulator %s\n", node->name);
+		dev_err(dev, "Unknown regulator %pOFn\n", node);
 		return -EINVAL;
 	}
 
@@ -423,8 +423,8 @@ static int rpmh_regulator_init_vreg(struct rpmh_vreg *vreg, struct device *dev,
 
 	vreg->addr = cmd_db_read_addr(rpmh_resource_name);
 	if (!vreg->addr) {
-		dev_err(dev, "%s: could not find RPMh address for resource %s\n",
-			node->name, rpmh_resource_name);
+		dev_err(dev, "%pOFn: could not find RPMh address for resource %s\n",
+			node, rpmh_resource_name);
 		return -ENODEV;
 	}
 
@@ -469,13 +469,13 @@ static int rpmh_regulator_init_vreg(struct rpmh_vreg *vreg, struct device *dev,
 	rdev = devm_regulator_register(dev, &vreg->rdesc, &reg_config);
 	if (IS_ERR(rdev)) {
 		ret = PTR_ERR(rdev);
-		dev_err(dev, "%s: devm_regulator_register() failed, ret=%d\n",
-			node->name, ret);
+		dev_err(dev, "%pOFn: devm_regulator_register() failed, ret=%d\n",
+			node, ret);
 		return ret;
 	}
 
-	dev_dbg(dev, "%s regulator registered for RPMh resource %s @ 0x%05X\n",
-		node->name, rpmh_resource_name, vreg->addr);
+	dev_dbg(dev, "%pOFn regulator registered for RPMh resource %s @ 0x%05X\n",
+		node, rpmh_resource_name, vreg->addr);
 
 	return 0;
 }
diff --git a/drivers/regulator/s5m8767.c b/drivers/regulator/s5m8767.c
index 667d16dc83ce..09a97a7093e8 100644
--- a/drivers/regulator/s5m8767.c
+++ b/drivers/regulator/s5m8767.c
@@ -447,15 +447,15 @@ static void s5m8767_regulator_config_ext_control(struct s5m8767_info *s5m8767,
 	}
 	if (mode != S5M8767_ENCTRL_USE_GPIO) {
 		dev_warn(s5m8767->dev,
-				"ext-control for %s: mismatched op_mode (%x), ignoring\n",
-				rdata->reg_node->name, mode);
+				"ext-control for %pOFn: mismatched op_mode (%x), ignoring\n",
+				rdata->reg_node, mode);
 		return;
 	}
 
 	if (!rdata->ext_control_gpiod) {
 		dev_warn(s5m8767->dev,
-				"ext-control for %s: GPIO not valid, ignoring\n",
-			 rdata->reg_node->name);
+				"ext-control for %pOFn: GPIO not valid, ignoring\n",
+			 rdata->reg_node);
 		return;
 	}
 
@@ -566,8 +566,8 @@ static int s5m8767_pmic_dt_parse_pdata(struct platform_device *pdev,
 
 		if (i == ARRAY_SIZE(regulators)) {
 			dev_warn(iodev->dev,
-			"don't know how to configure regulator %s\n",
-			reg_np->name);
+			"don't know how to configure regulator %pOFn\n",
+			reg_np);
 			continue;
 		}
 
-- 
2.17.1


  parent reply	other threads:[~2018-08-28  1:56 UTC|newest]

Thread overview: 163+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-08-28  1:52 [PATCH] ARM: omap: Convert to using %pOFn instead of device_node.name Rob Herring
2018-08-28  1:52 ` [PATCH] ARM: shmobile: " Rob Herring
2018-08-28  7:24   ` Geert Uytterhoeven
2018-08-30 14:37     ` Simon Horman
2018-08-28  1:52 ` [PATCH] ARM: zynq: " Rob Herring
2018-09-05 13:27   ` Michal Simek
2018-08-28  1:52 ` [PATCH] MIPS: " Rob Herring
2018-08-28 16:54   ` Paul Burton
2018-08-28  1:52 ` [PATCH] nios2: " Rob Herring
2018-08-28 15:47   ` Ley Foon Tan
2018-08-28  1:52 ` [PATCH] powerpc: " Rob Herring
2018-10-04  6:14   ` Michael Ellerman
2018-08-28  1:52 ` [PATCH] sparc: " Rob Herring
2018-08-28 14:13   ` Rob Herring
2018-08-28 15:44   ` [PATCH v2] " Rob Herring
2018-10-08  5:57     ` David Miller
2018-08-28  1:52 ` [PATCH] xtensa: " Rob Herring
2018-08-28 15:45   ` Max Filippov
2018-08-28  1:52 ` [PATCH] ata: ahci: " Rob Herring
2018-08-28 14:44   ` Jens Axboe
2018-08-28  1:52 ` [PATCH] bus: fsl-mc: " Rob Herring
2018-08-28  1:52 ` [PATCH] bus: mvebu-mbus: " Rob Herring
2018-08-28  1:52 ` [PATCH] clk: " Rob Herring
2018-08-28 15:44   ` [PATCH v2] " Rob Herring
2018-08-28 22:15     ` Stephen Boyd
2018-08-29 11:13       ` Rob Herring
2018-08-30 16:50         ` Stephen Boyd
2018-09-03  5:29   ` [PATCH] " Chen-Yu Tsai
2018-09-07 15:08   ` Rob Herring
2018-08-28  1:52 ` [PATCH] clocksource: " Rob Herring
2018-08-29 15:23   ` Daniel Lezcano
2018-08-28  1:52 ` [PATCH] cpufreq: " Rob Herring
2018-09-03  6:34   ` Viresh Kumar
2018-09-14  8:27   ` Rafael J. Wysocki
2018-08-28  1:52 ` [PATCH] devfreq: " Rob Herring
2018-08-28  2:06   ` Chanwoo Choi
     [not found]   ` <CGME20180828015312epcas2p2fdb2ee1d1b292f212ec773dd8fb4bfc7@epcms1p8>
2018-08-29  2:10     ` MyungJoo Ham
2018-08-28  1:52 ` [PATCH] dmaengine: " Rob Herring
2018-08-28  5:16   ` Vinod
2018-08-28  1:52 ` [PATCH] firmware: " Rob Herring
2018-09-28 21:47   ` Rob Herring
2018-10-01  9:09     ` Sudeep Holla
2018-08-28  1:52 ` [PATCH] gpio: " Rob Herring
2018-08-29 12:02   ` Linus Walleij
2018-08-28  1:52 ` [PATCH] drm: " Rob Herring
2018-08-28 12:54   ` Maarten Lankhorst
2018-08-28 15:04     ` Rob Herring
2018-08-28 15:04   ` Rob Clark
2018-08-28  1:52 ` [PATCH] hwmon: " Rob Herring
2018-08-28 13:57   ` Guenter Roeck
2018-08-28 15:11     ` Rob Herring
2018-08-28 18:43   ` Guenter Roeck
2018-08-28  1:52 ` [PATCH] i2c: " Rob Herring
2018-08-28  6:33   ` Peter Rosin
2018-08-29 18:42     ` Rob Herring
2018-08-29 19:52       ` Peter Rosin
2018-08-30  0:49         ` Rob Herring
2018-08-28  1:52 ` [PATCH] iio: " Rob Herring
2018-09-02 17:55   ` Jonathan Cameron
2018-08-28  1:52 ` [PATCH] input: sun4i-lradc: " Rob Herring
2018-09-28 21:54   ` Rob Herring
2018-09-28 23:59   ` Dmitry Torokhov
2018-08-28  1:52 ` [PATCH] irqchip: " Rob Herring
2018-09-08 12:15   ` Thomas Gleixner
2018-09-10 13:55     ` Rob Herring
2018-08-28  1:52 ` [PATCH] leds: " Rob Herring
2018-08-28 11:07   ` Sakari Ailus
2018-08-28 11:37   ` Pavel Machek
2018-08-28 20:37   ` Jacek Anaszewski
2018-08-28  1:52 ` [PATCH] macintosh: " Rob Herring
2018-08-28  1:52 ` [PATCH] mailbox: " Rob Herring
2018-09-28 21:54   ` Rob Herring
2018-08-28  1:52 ` [PATCH] media: " Rob Herring
2018-08-28 10:06   ` Laurent Pinchart
2018-08-28 12:21     ` Rob Herring
2018-09-12 15:10       ` Mauro Carvalho Chehab
2018-08-28  1:52 ` [PATCH] memory: " Rob Herring
2018-08-28 10:42   ` Thierry Reding
2018-08-28 15:33   ` Tony Lindgren
2018-08-29  7:44   ` Krzysztof Kozlowski
2018-08-28  1:52 ` [PATCH] mfd: max77620: " Rob Herring
2018-09-10 15:24   ` Lee Jones
2018-08-28  1:52 ` [PATCH] misc: " Rob Herring
2018-08-28  2:35   ` Andrew Donnellan
2018-08-28  1:52 ` [PATCH] mmc: " Rob Herring
2018-08-28  7:59   ` Adrian Hunter
2018-08-28 11:41   ` Ulf Hansson
2018-08-28  1:52 ` [PATCH] mtd: rawnand: " Rob Herring
2018-08-28  9:16   ` Boris Brezillon
2018-09-04 21:58   ` Miquel Raynal
2018-08-28  1:52 ` [PATCH] net: ethernet: " Rob Herring
2018-08-28 15:44   ` [PATCH v2] " Rob Herring
2018-08-28 15:45     ` Matthias Brugger
2018-08-29  2:06     ` Sean Wang
2018-08-30  2:41     ` David Miller
2018-08-28  1:52 ` [PATCH] net: phy: " Rob Herring
2018-08-28 16:57   ` Florian Fainelli
2018-08-28  1:52 ` [PATCH] net: wireless: ath: " Rob Herring
2018-08-28 11:19   ` Kalle Valo
2018-09-03 16:58   ` Kalle Valo
2018-08-28  1:52 ` [PATCH] nvmem: " Rob Herring
2018-09-28 22:06   ` Rob Herring
2018-10-01  9:05     ` Srinivas Kandagatla
2018-08-28  1:52 ` [PATCH] perf: " Rob Herring
2018-08-28 17:02   ` Will Deacon
2018-09-28 21:19     ` Rob Herring
2018-10-01  9:18       ` Will Deacon
2018-08-28  1:52 ` [PATCH] phy: " Rob Herring
2018-09-04  2:24   ` Kishon Vijay Abraham I
2018-09-04 14:21     ` Rob Herring
2018-08-28  1:52 ` [PATCH] pinctrl: " Rob Herring
2018-08-28  1:57   ` A.s. Dong
2018-08-28  7:21   ` Alexandre Belloni
2018-08-28 15:34   ` Tony Lindgren
2018-08-29  2:13   ` Sean Wang
2018-08-29  2:15   ` Chen-Yu Tsai
2018-08-29  8:31   ` Heiko Stübner
2018-08-29 12:07   ` Linus Walleij
2018-09-03  9:57   ` Patrice CHOTARD
2018-08-28  1:52 ` Rob Herring [this message]
2018-08-29  7:47   ` [PATCH] regulator: " Krzysztof Kozlowski
2018-08-28  1:52 ` [PATCH] rpmsg: " Rob Herring
2018-08-28  3:08   ` Bjorn Andersson
2018-08-28  1:52 ` [PATCH] soc: " Rob Herring
2018-08-28 10:44   ` Thierry Reding
2018-08-28 18:48   ` Li Yang
2018-08-28 22:14     ` Tyrel Datwyler
2018-08-28 22:29       ` Li Yang
2018-08-28 22:46         ` Tyrel Datwyler
2018-08-29  8:21   ` Heiko Stübner
2018-08-29  8:57   ` Qiang Zhao
2018-09-30 17:08   ` Andy Gross
2018-08-28  1:52 ` [PATCH] staging: " Rob Herring
2018-08-28  6:34   ` Ian Arkver
2018-08-28 15:44   ` [PATCH v2] " Rob Herring
2018-09-12 15:17     ` Mauro Carvalho Chehab
2018-09-12 20:26       ` Rob Herring
2018-09-12 21:07         ` Mauro Carvalho Chehab
2018-09-12 22:48           ` Rob Herring
2018-09-13 11:50         ` Joe Perches
2018-09-13 21:26           ` Rob Herring
2018-09-14 11:41             ` Joe Perches
2018-08-28  1:52 ` [PATCH] thermal: " Rob Herring
2018-08-30 14:58   ` Daniel Lezcano
2018-08-28  1:52 ` [PATCH] tty: " Rob Herring
2018-09-28 22:09   ` Rob Herring
2018-09-28 22:32     ` Rob Herring
2018-08-28  1:52 ` [PATCH] uio: " Rob Herring
2018-08-28  1:52 ` [PATCH] backlight: pm8941: " Rob Herring
2018-08-28  1:52 ` [PATCH] fbdev: " Rob Herring
2018-09-28 22:11   ` Rob Herring
2018-10-08 10:41   ` Bartlomiej Zolnierkiewicz
2018-08-28  1:52 ` [PATCH] sound: " Rob Herring
2018-08-28  7:54   ` Andy Shevchenko
2018-08-28 15:44   ` [PATCH v2] " Rob Herring
2018-09-03 21:45     ` [alsa-devel] " Takashi Iwai
2018-08-28  1:52 ` [PATCH] ASoC: " Rob Herring
2018-08-28  7:57   ` Andy Shevchenko
2018-08-28 15:44   ` [PATCH v2] " Rob Herring
2018-08-28 18:03     ` Mark Brown
2018-08-28  6:55 ` [PATCH] ARM: omap: " Joe Perches
2018-08-28 15:44 ` [PATCH v2] " Rob Herring
2018-09-07 17:14   ` Tony Lindgren

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180828015252.28511-41-robh@kernel.org \
    --to=robh@kernel.org \
    --cc=b.zolnierkie@samsung.com \
    --cc=broonie@kernel.org \
    --cc=krzk@kernel.org \
    --cc=lgirdwood@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-samsung-soc@vger.kernel.org \
    --cc=sbkim73@samsung.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).