From: Rob Herring <robh@kernel.org>
To: Akash Gajjar <Akash_Gajjar@mentor.com>
Cc: heiko@sntech.de, deepak_das@mentor.com,
Mark Rutland <mark.rutland@arm.com>,
Jagan Teki <jagan@amarulasolutions.com>,
Levin Du <djw@t-chip.com.cn>,
Ezequiel Garcia <ezequiel@collabora.com>,
Klaus Goger <klaus.goger@theobroma-systems.com>,
Arnd Bergmann <arnd@arndb.de>,
Masahiro Yamada <yamada.masahiro@socionext.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Shohei Maruyama <cheat.sc.linux@outlook.com>,
Shawn Lin <shawn.lin@rock-chips.com>,
Heinrich Schuchardt <xypron.glpk@gmx.de>,
Enric Balletbo i Serra <enric.balletbo@collabora.com>,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] arm64: dts: rockchip: add initial dts support for Rockpro64 board
Date: Mon, 17 Sep 2018 01:44:14 -0400 [thread overview]
Message-ID: <20180917054414.GA13346@bogus> (raw)
In-Reply-To: <1536926957-12432-1-git-send-email-Akash_Gajjar@mentor.com>
On Fri, Sep 14, 2018 at 05:39:09PM +0530, Akash Gajjar wrote:
> Rockpro64 board is a rockchip RK3399 based board from pine64.org.
> This commit adds initial device tree support for Rockpro64 board.
>
> Signed-off-by: Akash Gajjar <Akash_Gajjar@mentor.com>
> ---
> Documentation/devicetree/bindings/arm/rockchip.txt | 4 +
> arch/arm64/boot/dts/rockchip/Makefile | 1 +
> arch/arm64/boot/dts/rockchip/rk3399-rockpro64.dts | 770 +++++++++++++++++++++
> 3 files changed, 775 insertions(+)
> create mode 100644 arch/arm64/boot/dts/rockchip/rk3399-rockpro64.dts
>
> diff --git a/Documentation/devicetree/bindings/arm/rockchip.txt b/Documentation/devicetree/bindings/arm/rockchip.txt
> index acfd3c7..ac95183 100644
> --- a/Documentation/devicetree/bindings/arm/rockchip.txt
> +++ b/Documentation/devicetree/bindings/arm/rockchip.txt
> @@ -160,6 +160,10 @@ Rockchip platforms device tree bindings
> Required root node properties:
> - compatible = "pine64,rock64", "rockchip,rk3328";
>
> +- Pine64 RockPro64 board:
> + Required root node properties:
> + - compatible = "pine64,rockpro64", "rockchip,rk3399";
> +
> - Rockchip PX3 Evaluation board:
> Required root node properties:
> - compatible = "rockchip,px3-evb", "rockchip,px3", "rockchip,rk3188";
> diff --git a/arch/arm64/boot/dts/rockchip/Makefile b/arch/arm64/boot/dts/rockchip/Makefile
> index b0092d9..03d523a 100644
> --- a/arch/arm64/boot/dts/rockchip/Makefile
> +++ b/arch/arm64/boot/dts/rockchip/Makefile
> @@ -14,5 +14,6 @@ dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3399-firefly.dtb
> dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3399-gru-bob.dtb
> dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3399-gru-kevin.dtb
> dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3399-puma-haikou.dtb
> +dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3399-rockpro64.dtb
> dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3399-sapphire.dtb
> dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3399-sapphire-excavator.dtb
> diff --git a/arch/arm64/boot/dts/rockchip/rk3399-rockpro64.dts b/arch/arm64/boot/dts/rockchip/rk3399-rockpro64.dts
> new file mode 100644
> index 0000000..9e2d4d9
> --- /dev/null
> +++ b/arch/arm64/boot/dts/rockchip/rk3399-rockpro64.dts
> @@ -0,0 +1,770 @@
> +// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
> +/*
> + * Copyright (c) 2017 Fuzhou Rockchip Electronics Co., Ltd.
> + */
> +
> +/dts-v1/;
> +#include <dt-bindings/input/linux-event-codes.h>
> +#include <dt-bindings/pwm/pwm.h>
> +#include "rk3399.dtsi"
> +#include "rk3399-opp.dtsi"
> +
> +/ {
> + model = "Pine64 RockPro64";
> + compatible = "pine64,rockpro64", "rockchip,rk3399";
> +
> + chosen {
> + stdout-path = "serial2:1500000n8";
> + };
> +
> + backlight: backlight {
> + compatible = "pwm-backlight";
> + enable-gpios = <&gpio1 RK_PB5 GPIO_ACTIVE_HIGH>;
> + pwms = <&pwm0 0 25000 0>;
> + brightness-levels = <
> + 0 1 2 3 4 5 6 7
> + 8 9 10 11 12 13 14 15
> + 16 17 18 19 20 21 22 23
There's a binding now so you don't have to list every single entry.
Rob
next prev parent reply other threads:[~2018-09-17 5:44 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-14 12:09 [PATCH] arm64: dts: rockchip: add initial dts support for Rockpro64 board Akash Gajjar
2018-09-14 17:53 ` Heiko Stuebner
2018-09-15 9:03 ` agajjar
2018-09-15 18:47 ` Heiko Stuebner
2018-09-17 5:44 ` Rob Herring [this message]
2018-09-19 14:43 Akash Gajjar
2018-09-20 6:25 ` Deepak Das
2018-09-24 13:05 ` Heiko Stuebner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180917054414.GA13346@bogus \
--to=robh@kernel.org \
--cc=Akash_Gajjar@mentor.com \
--cc=arnd@arndb.de \
--cc=cheat.sc.linux@outlook.com \
--cc=deepak_das@mentor.com \
--cc=devicetree@vger.kernel.org \
--cc=djw@t-chip.com.cn \
--cc=enric.balletbo@collabora.com \
--cc=ezequiel@collabora.com \
--cc=gregkh@linuxfoundation.org \
--cc=heiko@sntech.de \
--cc=jagan@amarulasolutions.com \
--cc=klaus.goger@theobroma-systems.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=mark.rutland@arm.com \
--cc=shawn.lin@rock-chips.com \
--cc=xypron.glpk@gmx.de \
--cc=yamada.masahiro@socionext.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).