From: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
To: Nathan Chancellor <natechancellor@gmail.com>,
Xiaowei Song <songxiaowei@hisilicon.com>,
Binghui Wang <wangbinghui@hisilicon.com>
Cc: Bjorn Helgaas <bhelgaas@google.com>,
linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org,
Nick Desaulniers <ndesaulniers@google.com>
Subject: Re: [PATCH] PCI: kirin: Fix section mismatch warning
Date: Wed, 19 Sep 2018 11:29:44 +0100 [thread overview]
Message-ID: <20180919102944.GA15014@e107981-ln.cambridge.arm.com> (raw)
In-Reply-To: <20180919053829.4858-1-natechancellor@gmail.com>
Xiaowei, Binghui,
On Tue, Sep 18, 2018 at 10:38:29PM -0700, Nathan Chancellor wrote:
> WARNING: vmlinux.o(.text+0x4758cc): Section mismatch in reference from
> the function kirin_pcie_probe() to the function
> .init.text:kirin_add_pcie_port()
> The function kirin_pcie_probe() references
> the function __init kirin_add_pcie_port().
> This is often because kirin_pcie_probe lacks a __init
> annotation or the annotation of kirin_add_pcie_port is wrong.
>
> Remove '__init' from kirin_add_pcie_port so there is no mismatch.
I think that instead of removing __init section tag we should add
it to kirin_pcie_probe().
Please let me know and ACK accordingly.
Lorenzo
> Fixes: fc5165db245a ("PCI: kirin: Add HiSilicon Kirin SoC PCIe controller driver")
> Reported-by: Nick Desaulniers <ndesaulniers@google.com>
> Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
> ---
> drivers/pci/controller/dwc/pcie-kirin.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/pci/controller/dwc/pcie-kirin.c b/drivers/pci/controller/dwc/pcie-kirin.c
> index 5352e0c3be82..9b599296205d 100644
> --- a/drivers/pci/controller/dwc/pcie-kirin.c
> +++ b/drivers/pci/controller/dwc/pcie-kirin.c
> @@ -467,8 +467,8 @@ static int kirin_pcie_add_msi(struct dw_pcie *pci,
> return 0;
> }
>
> -static int __init kirin_add_pcie_port(struct dw_pcie *pci,
> - struct platform_device *pdev)
> +static int kirin_add_pcie_port(struct dw_pcie *pci,
> + struct platform_device *pdev)
> {
> int ret;
>
> --
> 2.19.0
>
next prev parent reply other threads:[~2018-09-19 10:30 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-19 5:38 [PATCH] PCI: kirin: Fix section mismatch warning Nathan Chancellor
2018-09-19 10:29 ` Lorenzo Pieralisi [this message]
2018-09-19 17:35 ` Nick Desaulniers
2018-09-19 17:58 ` Nathan Chancellor
2018-09-19 18:35 ` Nick Desaulniers
2018-09-19 18:48 ` Nathan Chancellor
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180919102944.GA15014@e107981-ln.cambridge.arm.com \
--to=lorenzo.pieralisi@arm.com \
--cc=bhelgaas@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=natechancellor@gmail.com \
--cc=ndesaulniers@google.com \
--cc=songxiaowei@hisilicon.com \
--cc=wangbinghui@hisilicon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).