From: Stephen Hemminger <stephen@networkplumber.org>
To: Haiyang Zhang <haiyangz@linuxonhyperv.com>
Cc: haiyangz@microsoft.com, davem@davemloft.net,
netdev@vger.kernel.org, olaf@aepfle.de,
linux-kernel@vger.kernel.org, devel@linuxdriverproject.org,
vkuznets@redhat.com
Subject: Re: [PATCH net-next, v2, 1/3] hv_netvsc: Add support for LRO/RSC in the vSwitch
Date: Fri, 21 Sep 2018 11:36:39 -0700 [thread overview]
Message-ID: <20180921113620.62a004cb@xeon-e3> (raw)
In-Reply-To: <20180921182037.10077-2-haiyangz@linuxonhyperv.com>
On Fri, 21 Sep 2018 18:20:35 +0000
Haiyang Zhang <haiyangz@linuxonhyperv.com> wrote:
Overall, this looks good. Some minor suggestions.
> +struct nvsc_rsc {
> + const struct ndis_pkt_8021q_info *vlan;
> + const struct ndis_tcp_ip_checksum_info *csum_info;
> + u8 is_last; /* last RNDIS msg in a vmtransfer_page */
> + u32 cnt; /* #fragments in an RSC packet */
> + u32 pktlen; /* Full packet length */
> + void *data[NVSP_RSC_MAX];
> + u32 len[NVSP_RSC_MAX];
> +};
> +
This new state structure is state on a per-channel basis.
Do you really need this to be persistent across packets?
Could this be on stack or do you need it to handle split packets
arriving in different polls? Or is the stack space a problem?
Also, maybe data and length could be in one structure since they
are related.
next prev parent reply other threads:[~2018-09-21 18:36 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-21 18:20 [PATCH net-next,v2,0/3] hv_netvsc: Support LRO/RSC in the vSwitch Haiyang Zhang
2018-09-21 18:20 ` [PATCH net-next,v2,1/3] hv_netvsc: Add support for " Haiyang Zhang
2018-09-21 18:36 ` Stephen Hemminger [this message]
2018-09-21 18:51 ` [PATCH net-next, v2, 1/3] " Haiyang Zhang
2018-09-21 20:22 ` Stephen Hemminger
2018-09-21 20:29 ` Haiyang Zhang
2018-09-21 18:20 ` [PATCH net-next,v2,2/3] hv_netvsc: Add handler for LRO setting change Haiyang Zhang
2018-09-21 18:20 ` [PATCH net-next,v2,3/3] hv_netvsc: Update document for LRO/RSC support Haiyang Zhang
2018-09-23 0:23 ` [PATCH net-next,v2,0/3] hv_netvsc: Support LRO/RSC in the vSwitch David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180921113620.62a004cb@xeon-e3 \
--to=stephen@networkplumber.org \
--cc=davem@davemloft.net \
--cc=devel@linuxdriverproject.org \
--cc=haiyangz@linuxonhyperv.com \
--cc=haiyangz@microsoft.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=olaf@aepfle.de \
--cc=vkuznets@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).