From: Jonathan Cameron <jic23@kernel.org>
To: kbuild test robot <lkp@intel.com>
Cc: Eugen Hristev <eugen.hristev@microchip.com>,
kbuild-all@01.org, ludovic.desroches@microchip.com,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org,
nicolas.ferre@microchip.com,
Maxime Ripard <maxime.ripard@bootlin.com>
Subject: Re: [PATCH 2/2] iio: adc: at91: fix wrong channel number in triggered buffer mode
Date: Sat, 22 Sep 2018 11:36:16 +0100 [thread overview]
Message-ID: <20180922113616.2d849fb0@archlinux> (raw)
In-Reply-To: <201809211544.zop1vk8B%fengguang.wu@intel.com>
On Fri, 21 Sep 2018 15:26:03 +0800
kbuild test robot <lkp@intel.com> wrote:
> Hi Eugen,
This one is leaving me stumped...
Anyone care to point out what I'm missing that is wrong here?
Also Eugen, please don't cc stable on a patch directly. It is fine to send
a backport request once a patch has hit mainline, but before that it's just
adding noise to a list as they won't take it directly anyway.
Jonathan
>
> I love your patch! Perhaps something to improve:
>
> [auto build test WARNING on iio/togreg]
> [also build test WARNING on v4.19-rc4 next-20180919]
> [if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
>
> url: https://github.com/0day-ci/linux/commits/Eugen-Hristev/iio-adc-at91-fix-acking-DRDY-irq-on-simple-conversions/20180920-215908
> base: https://git.kernel.org/pub/scm/linux/kernel/git/jic23/iio.git togreg
> config: arm-allmodconfig (attached as .config)
> compiler: arm-linux-gnueabi-gcc (Debian 7.2.0-11) 7.2.0
> reproduce:
> wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
> chmod +x ~/bin/make.cross
> # save the attached .config to linux build tree
> GCC_VERSION=7.2.0 make.cross ARCH=arm
>
> All warnings (new ones prefixed by >>):
>
> drivers/iio/adc/at91_adc.c: In function 'at91_adc_trigger_handler':
> >> drivers/iio/adc/at91_adc.c:257:8: warning: assignment discards 'const' qualifier from pointer target type [-Wdiscarded-qualifiers]
> chan = idev->channels + i;
> ^
>
> vim +/const +257 drivers/iio/adc/at91_adc.c
>
> 245
> 246 static irqreturn_t at91_adc_trigger_handler(int irq, void *p)
> 247 {
> 248 struct iio_poll_func *pf = p;
> 249 struct iio_dev *idev = pf->indio_dev;
> 250 struct at91_adc_state *st = iio_priv(idev);
> 251 struct iio_chan_spec *chan;
> 252 int i, j = 0;
> 253
> 254 for (i = 0; i < idev->masklength; i++) {
> 255 if (!test_bit(i, idev->active_scan_mask))
> 256 continue;
> > 257 chan = idev->channels + i;
> 258 st->buffer[j] = at91_adc_readl(st, AT91_ADC_CHAN(st, chan->channel));
> 259 j++;
> 260 }
> 261
> 262 iio_push_to_buffers_with_timestamp(idev, st->buffer, pf->timestamp);
> 263
> 264 iio_trigger_notify_done(idev->trig);
> 265
> 266 /* Needed to ACK the DRDY interruption */
> 267 at91_adc_readl(st, AT91_ADC_LCDR);
> 268
> 269 enable_irq(st->irq);
> 270
> 271 return IRQ_HANDLED;
> 272 }
> 273
>
> ---
> 0-DAY kernel test infrastructure Open Source Technology Center
> https://lists.01.org/pipermail/kbuild-all Intel Corporation
next prev parent reply other threads:[~2018-09-22 10:36 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-20 12:40 [PATCH 1/2] iio: adc: at91: fix acking DRDY irq on simple conversions Eugen Hristev
2018-09-20 12:40 ` [PATCH 2/2] iio: adc: at91: fix wrong channel number in triggered buffer mode Eugen Hristev
2018-09-21 7:26 ` kbuild test robot
2018-09-22 10:36 ` Jonathan Cameron [this message]
2018-09-22 11:19 ` Song Qiang
2018-09-22 11:48 ` Himanshu Jha
2018-09-22 12:51 ` Jonathan Cameron
2018-09-22 10:31 ` [PATCH 1/2] iio: adc: at91: fix acking DRDY irq on simple conversions Jonathan Cameron
2018-09-24 6:19 ` Eugen Hristev
2018-09-24 20:00 ` Jonathan Cameron
2018-09-24 20:27 ` Jonathan Cameron
2018-09-25 6:50 ` Eugen Hristev
2018-09-29 11:20 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180922113616.2d849fb0@archlinux \
--to=jic23@kernel.org \
--cc=eugen.hristev@microchip.com \
--cc=kbuild-all@01.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@intel.com \
--cc=ludovic.desroches@microchip.com \
--cc=maxime.ripard@bootlin.com \
--cc=nicolas.ferre@microchip.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).