From: Mark Rutland <mark.rutland@arm.com>
To: Jun Yao <yaojun8558363@gmail.com>
Cc: linux-arm-kernel@lists.infradead.org, catalin.marinas@arm.com,
will.deacon@arm.com, james.morse@arm.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v5 0/6] Move swapper_pg_dir to rodata section.
Date: Mon, 24 Sep 2018 18:19:36 +0100 [thread overview]
Message-ID: <20180924171936.q5bfvczzllmm5lpe@lakrids.cambridge.arm.com> (raw)
In-Reply-To: <20180917044333.30051-1-yaojun8558363@gmail.com>
Hi,
On Mon, Sep 17, 2018 at 12:43:27PM +0800, Jun Yao wrote:
> Version 5 changes:
> 1. Correct spelling and indentation errors[1].
> 2. Update init_mm.pgd by assembly[2].
> 3. Simplify set_p?d() by introducing set_swapper_pgd()[3].
> 4. Reduce unnecessary tlbi for every write to swapper_pg_dir
> during paging_init()[3].
>
> v4: https://www.spinics.net/lists/arm-kernel/msg672195.html
> v3: https://www.spinics.net/lists/arm-kernel/msg662537.html
> v2: https://patchwork.kernel.org/patch/10485641/
> v1: https://patchwork.kernel.org/patch/10476595/
>
> [1] https://www.spinics.net/lists/arm-kernel/msg675189.html
> [2] https://www.spinics.net/lists/arm-kernel/msg675193.html
> [3] https://www.spinics.net/lists/arm-kernel/msg675196.html
>
> Jun Yao (6):
> arm64/mm: Introduce the init_pg_dir.
> arm64/mm: Pass ttbr1 as a parameter to __enable_mmu().
> arm64/mm: Create the initial page table in the init_pg_dir.
> arm64/mm: Create the final page table directly in swapper_pg_dir.
> arm64/mm: Populate the swapper_pg_dir by fixmap.
> arm64/mm: Move {idmap_pg_dir .. swapper_pg_dir} to rodata section.
>
> arch/arm64/include/asm/assembler.h | 29 ++++++++++++++++++
> arch/arm64/include/asm/pgtable.h | 36 ++++++++++++++++++----
> arch/arm64/kernel/asm-offsets.c | 1 +
> arch/arm64/kernel/head.S | 48 ++++++++++++++++++++----------
> arch/arm64/kernel/sleep.S | 1 +
> arch/arm64/kernel/vmlinux.lds.S | 47 +++++++++++++++++++----------
> arch/arm64/mm/mmu.c | 45 +++++++++++++---------------
> 7 files changed, 147 insertions(+), 60 deletions(-)
I've pushed a branch with the cleanups I requested [1] folded in.
I'm still a bit worried about the pgd lock, but otherwise I think this
is sound. I intend to throw some testing at it, just in case.
If you're happy with that branch, I'll ask Will and Catalin to consider
picking it up.
Thanks,
Mark.
[1] git://git.kernel.org/pub/scm/linux/kernel/git/mark/linux.git arm64/ro-swapper
next prev parent reply other threads:[~2018-09-24 17:19 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-17 4:43 [PATCH v5 0/6] Move swapper_pg_dir to rodata section Jun Yao
2018-09-17 4:43 ` [PATCH v5 1/6] arm64/mm: Introduce the init_pg_dir Jun Yao
2018-09-24 13:01 ` Mark Rutland
2018-09-24 14:03 ` Mark Rutland
2018-09-17 4:43 ` [PATCH v5 2/6] arm64/mm: Pass ttbr1 as a parameter to __enable_mmu() Jun Yao
2018-09-24 13:26 ` Mark Rutland
2018-09-17 4:43 ` [PATCH v5 3/6] arm64/mm: Create the initial page table in the init_pg_dir Jun Yao
2018-09-24 13:34 ` Mark Rutland
2018-10-01 13:49 ` James Morse
2018-09-17 4:43 ` [PATCH v5 4/6] arm64/mm: Create the final page table directly in swapper_pg_dir Jun Yao
2018-09-17 4:43 ` [PATCH v5 5/6] arm64/mm: Populate the swapper_pg_dir by fixmap Jun Yao
2018-09-24 16:36 ` Mark Rutland
2018-10-01 10:41 ` James Morse
2018-10-01 13:49 ` James Morse
2018-09-24 16:54 ` Mark Rutland
2018-09-17 4:43 ` [PATCH v5 6/6] arm64/mm: Move {idmap_pg_dir .. swapper_pg_dir} to rodata section Jun Yao
2018-09-21 22:26 ` [PATCH v5 0/6] Move swapper_pg_dir " James Morse
2018-09-25 8:56 ` Jun Yao
2018-09-24 17:19 ` Mark Rutland [this message]
2018-09-25 9:53 ` Jun Yao
2018-09-25 14:06 ` Mark Rutland, catalin.marinas
2018-09-25 14:38 ` Catalin Marinas
2018-10-03 13:33 ` James Morse
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180924171936.q5bfvczzllmm5lpe@lakrids.cambridge.arm.com \
--to=mark.rutland@arm.com \
--cc=catalin.marinas@arm.com \
--cc=james.morse@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=will.deacon@arm.com \
--cc=yaojun8558363@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).