linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Petr Mladek <pmladek@suse.com>
To: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
Cc: Steven Rostedt <rostedt@goodmis.org>,
	He Zhe <zhe.he@windriver.com>,
	Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/2] printk: Fix panic caused by passing log_buf_len to command line
Date: Tue, 25 Sep 2018 14:23:00 +0200	[thread overview]
Message-ID: <20180925122300.qq5w4skwmxbzi6sy@pathway.suse.cz> (raw)
In-Reply-To: <20180925120135.GB523@tigerII.localdomain>

On Tue 2018-09-25 21:01:35, Sergey Senozhatsky wrote:
> On (09/21/18 09:37), Petr Mladek wrote:
> > 
> > I would personally keep the size as unsigned int. IMHO, a support
> > for a log buffer bigger than 4GB is not worth the complexity.
> > 
> 
> ftrace dumps are bothering me.
> 
> Steven Rostedt wrote [0]:
> >
> > Especially when I have a machine with 240 CPUs. But it also has a ton of
> > RAM, I could easily do log_buf_len=32G
> >
> 
> The systems are getting bigger, so log_buf_len=UINT_MAX+ might become
> a norm at some point.

Thanks for pointing this out. Well, it seems that the change would
require a new syscall to pass the buffer size as long. We need to
be sure that people would use this in the real life.

This thread suggested this change to avoid a checkpatch warning.
The 32GB was mentioned as an example one year ego. This is not enough
for a new syscall from my point of view.

Best Regards,
Petr

  reply	other threads:[~2018-09-25 12:23 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-09-18 17:17 [PATCH v2 1/2] printk: Fix panic caused by passing log_buf_len to command line zhe.he
2018-09-18 17:17 ` [PATCH v2 2/2] printk: Add KBUILD_MODNAME and correct bare use of unsigned zhe.he
2018-09-19  2:06   ` Sergey Senozhatsky
2018-09-19 11:20     ` Petr Mladek
2018-09-19  1:50 ` [PATCH v2 1/2] printk: Fix panic caused by passing log_buf_len to command line Sergey Senozhatsky
2018-09-19  2:27   ` He Zhe
2018-09-19  2:39     ` Sergey Senozhatsky
2018-09-19  2:43       ` Steven Rostedt
2018-09-19  2:47         ` Sergey Senozhatsky
2018-09-19  3:05           ` Steven Rostedt
2018-09-20 16:16         ` He Zhe
2018-09-20 16:30           ` Steven Rostedt
2018-09-21  7:37             ` Petr Mladek
2018-09-22 15:36               ` He Zhe
2018-09-25 12:16                 ` Sergey Senozhatsky
2018-09-25 12:01               ` Sergey Senozhatsky
2018-09-25 12:23                 ` Petr Mladek [this message]
2018-09-25 12:37                   ` Sergey Senozhatsky
2018-09-25 13:31                   ` Sergey Senozhatsky
2018-09-25 15:31                     ` He Zhe
2018-09-26 11:05                     ` Petr Mladek
2018-09-28  7:35                       ` Sergey Senozhatsky
2018-09-28  8:22                         ` He Zhe
2018-09-19  6:44     ` Sergey Senozhatsky
2018-09-19 10:09       ` He Zhe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180925122300.qq5w4skwmxbzi6sy@pathway.suse.cz \
    --to=pmladek@suse.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rostedt@goodmis.org \
    --cc=sergey.senozhatsky.work@gmail.com \
    --cc=sergey.senozhatsky@gmail.com \
    --cc=zhe.he@windriver.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).