From: Borislav Petkov <bp@suse.de>
To: Nick Desaulniers <ndesaulniers@google.com>
Cc: Thomas Gleixner <tglx@linutronix.de>,
mingo@redhat.com, hpa@zytor.com, x86@kernel.org,
"Kirill A . Shutemov" <kirill.shutemov@linux.intel.com>,
Masahiro Yamada <yamada.masahiro@socionext.com>,
Matthias Kaehlcke <mka@chromium.org>,
Kees Cook <keescook@chromium.org>,
Cao jin <caoj.fnst@cn.fujitsu.com>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] x86/boot: define CC_HAVE_ASM_GOTO
Date: Tue, 25 Sep 2018 21:08:29 +0200 [thread overview]
Message-ID: <20180925190829.GC15464@zn.tnic> (raw)
In-Reply-To: <CAKwvOdn4BcKUjGnGgFfbGxbwvSh9mYLT1gJ_ozDHua1LcjJ1rw@mail.gmail.com>
On Tue, Sep 25, 2018 at 11:41:19AM -0700, Nick Desaulniers wrote:
> bumping for review.
>
> On Fri, Sep 7, 2018 at 1:26 PM Nick Desaulniers <ndesaulniers@google.com> wrote:
> >
> > Since this file steamrolls KBUILD_CFLAGS, we have to redefine these
> > symbols.
Why do we have to redefine these symbols?
I don't see arch/x86/boot/ using asm_volatile_goto() and
CC_HAVE_ASM_GOTO anywhere.
> > This will prevent warnings in source files in this directory
> > when Clang supports asm goto.
This statement I can't grok either. Maybe I'm slow or maybe I need more
background info...
Thx.
--
Regards/Gruss,
Boris.
SUSE Linux GmbH, GF: Felix Imendörffer, Jane Smithard, Graham Norton, HRB 21284 (AG Nürnberg)
--
next prev parent reply other threads:[~2018-09-25 19:08 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-07 20:26 [PATCH] x86/boot: define CC_HAVE_ASM_GOTO Nick Desaulniers
2018-09-25 18:41 ` Nick Desaulniers
2018-09-25 19:08 ` Borislav Petkov [this message]
2018-09-25 21:08 ` Nick Desaulniers
2018-09-25 21:13 ` Nick Desaulniers
2018-09-26 9:08 ` Borislav Petkov
2018-09-28 20:41 ` H. Peter Anvin
2018-09-26 8:56 ` Borislav Petkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180925190829.GC15464@zn.tnic \
--to=bp@suse.de \
--cc=caoj.fnst@cn.fujitsu.com \
--cc=hpa@zytor.com \
--cc=keescook@chromium.org \
--cc=kirill.shutemov@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=mka@chromium.org \
--cc=ndesaulniers@google.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
--cc=yamada.masahiro@socionext.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).