From: Bjorn Andersson <bjorn.andersson@linaro.org>
To: Craig Tatlor <ctatlor97@gmail.com>
Cc: linux-arm-msm@vger.kernel.org,
Linus Walleij <linus.walleij@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
linux-gpio@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 2/2] dt-bindings: pinctrl: qcom: Add SDM660 pinctrl binding
Date: Tue, 25 Sep 2018 14:48:46 -0700 [thread overview]
Message-ID: <20180925214846.GK2523@minitux> (raw)
In-Reply-To: <20180925173801.3835-2-ctatlor97@gmail.com>
On Tue 25 Sep 10:38 PDT 2018, Craig Tatlor wrote:
> diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,sdm660-pinctrl.txt b/Documentation/devicetree/bindings/pinctrl/qcom,sdm660-pinctrl.txt
[..]
> +- reg:
> + Usage: required
> + Value type: <prop-encoded-array>
> + Definition: the base address and size of the TLMM register space.
This should mention that we're expecting address and size of the three
tiles. And the proposed patches depends on reg-names for the lookup.
> +
[..]
> +Example:
> +
> + tlmm: pinctrl@1010000 {
> + compatible = "qcom,sdm660-pinctrl";
> + reg = <0x1010000 0x300000>;
reg (and the node address) needs to be updated.
> + interrupts = <0 208 0>;
interrupts = <GIC_SPI 208 IRQ_TYPE_LEVEL_HIGH>;
> + gpio-controller;
> + gpio-ranges = <&tlmm 0 0 114>;
> + #gpio-cells = <2>;
> + interrupt-controller;
> + #interrupt-cells = <2>;
> + };
Regards,
Bjorn
next prev parent reply other threads:[~2018-09-25 21:48 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-12 14:24 [PATCH v2] pinctrl: qcom: Add sdm660 pinctrl driver Craig Tatlor
2018-08-13 7:24 ` Michal Vokáč
2018-08-13 7:36 ` Craig Tatlor
2018-08-13 7:56 ` Michal Vokáč
2018-08-13 7:36 ` Craig Tatlor
2018-09-24 18:53 ` Bjorn Andersson
2018-09-24 20:37 ` Craig
2018-09-25 17:37 ` [PATCH v3 1/2] " Craig Tatlor
2018-09-25 17:38 ` [PATCH v3 2/2] dt-bindings: pinctrl: qcom: Add SDM660 pinctrl binding Craig Tatlor
2018-09-25 21:48 ` Bjorn Andersson [this message]
2018-09-25 21:44 ` [PATCH v3 1/2] pinctrl: qcom: Add sdm660 pinctrl driver Bjorn Andersson
2018-09-26 6:57 ` Linus Walleij
2018-09-26 16:30 ` Craig
2018-09-28 7:21 ` Linus Walleij
2018-09-26 16:26 ` [PATCH v4 " Craig Tatlor
2018-09-26 16:26 ` [PATCH v4 2/2] dt-bindings: pinctrl: qcom: Add SDM660 pinctrl binding Craig Tatlor
2018-09-26 16:54 ` Bjorn Andersson
2018-09-27 18:46 ` Rob Herring
2018-10-03 6:59 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180925214846.GK2523@minitux \
--to=bjorn.andersson@linaro.org \
--cc=ctatlor97@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).