linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Maciej Purski <m.purski@samsung.com>
To: Dmitry Osipenko <digetx@gmail.com>, Tony Lindgren <tony@atomide.com>
Cc: Mark Brown <broonie@kernel.org>,
	linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org, linux-omap@vger.kernel.org,
	Carlos Hernandez <ceh@ti.com>,
	Marek Szyprowski <m.szyprowski@samsung.com>
Subject: Re: [PATCH] regulator: core: Pass max_uV value to regulator_set_voltage_rdev
Date: Mon, 1 Oct 2018 09:25:08 +0200	[thread overview]
Message-ID: <20181001072510eucas1p29a6e504d642d2cac67ed7c3b43f9d53c~Za0l11ceE1868218682eucas1p2w@eucas1p2.samsung.com> (raw)
In-Reply-To: <dbaa721a-9a47-2c6a-46d5-92a7ca13c5aa@gmail.com>

Hi all,
unfortunately, I don't work at kernel anymore. That would be great, if you could take over those patches and finish the 
work.
Best regards,
Maciej

On 09/29/2018 02:44 AM, Dmitry Osipenko wrote:
> On 9/29/18 3:27 AM, Tony Lindgren wrote:
>> * Dmitry Osipenko <digetx@gmail.com> [180928 23:55]:
>>> On 9/29/18 2:17 AM, Dmitry Osipenko wrote:
>>>> On 9/29/18 1:41 AM, Tony Lindgren wrote:
>>>>> I'm still getting these errors after init:
>>>>
>>>> Thank you very much again, seems I got what's wrong with your case. The ti-abb-regulator driver sets the "abb->current_info_idx = -EINVAL" on probe and that value is getting updated only after the first voltage change, hence _regulator_get_voltage() returns -22.
>>
>> OK that's starting to make some sense now thanks.
>>
>>>> Please try this patch:
>>>
>>> I've revised the patch and here is the current final version.
>>
>> Hey cool this one works now :) I suggest you rework the whole series
>> with these fixes. I recall the series had a problem with git bisect
>> too between the patches. It will make life easier for other people
>> who may need to git bisect these patches.
> 
> Awesome! There are few other things in this patchset that also need fixing. I've asked Maciej if he's going to continue working on the patches, waiting for the answer. I can pick up the patches and try to finish the work if necessary.
> 
> 

  reply	other threads:[~2018-10-01  7:25 UTC|newest]

Thread overview: 37+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-29 22:15 Regression in Linux next again Tony Lindgren
2018-05-30  9:13 ` Mark Brown
2018-05-30 14:03   ` Maciej Purski
2018-05-30 14:33     ` Mark Brown
2018-05-30 14:45       ` Tony Lindgren
     [not found]         ` <CGME20180604135952eucas1p292f7bcec405e6a1a6261031df36cad32@eucas1p2.samsung.com>
2018-06-04 13:59           ` Maciej Purski
     [not found]             ` <CGME20180604135952eucas1p2d76b6aa5d8fc9912113d519b48f7e99a@eucas1p2.samsung.com>
2018-06-04 13:59               ` [PATCH 1/7] regulator: core: Add debug messages Maciej Purski
     [not found]             ` <CGME20180604135952eucas1p2e3fdb68bf31e32b7c9557051671885a9@eucas1p2.samsung.com>
2018-06-04 13:59               ` [PATCH 2/7] regulator: core: Add regulator_set_voltage_rdev() Maciej Purski
     [not found]             ` <CGME20180604135953eucas1p2f2c9dd9581cd114d323c3d64afe5c308@eucas1p2.samsung.com>
2018-06-04 13:59               ` [PATCH 3/7] regulator: core: Use re-entrant locks Maciej Purski
     [not found]             ` <CGME20180604135953eucas1p2ec281df0793bc73e79f3000837abcb04@eucas1p2.samsung.com>
2018-06-04 13:59               ` [PATCH 4/7] regulator: core: Implement voltage balancing algorithm Maciej Purski
     [not found]             ` <CGME20180604135954eucas1p2156fed3300b5514a4efa2baf9e7b9bc5@eucas1p2.samsung.com>
2018-06-04 13:59               ` [PATCH 5/7] regulator: core: Lock dependent regulators Maciej Purski
2018-06-04 14:20                 ` Lucas Stach
2018-06-18 12:37                   ` Maciej Purski
     [not found]             ` <CGME20180604135954eucas1p2eeb77ada3ca97fecc6caec20d7e8397a@eucas1p2.samsung.com>
2018-06-04 13:59               ` [PATCH 6/7] regulator: core: Lock dependent regulators on regulator_enable() Maciej Purski
     [not found]             ` <CGME20180604135954eucas1p2bebd1c4970401bb957da228056f9a662@eucas1p2.samsung.com>
2018-06-04 13:59               ` [PATCH 7/7] regulator: core: Enable voltage balancing Maciej Purski
2018-06-04 23:13                 ` kbuild test robot
2018-06-04 23:54                 ` kbuild test robot
2018-06-05  4:45             ` Regression in Linux next again Tony Lindgren
     [not found]               ` <CGME20180613103622eucas1p1778ba2c2e5dd85ccb4c488bd0a38386d@eucas1p1.samsung.com>
2018-06-13 10:33                 ` [PATCH v2] regulator: core: Enable voltage balancing Maciej Purski
2018-06-15 11:29                   ` Tony Lindgren
2018-06-18 13:17                     ` Maciej Purski
     [not found]                     ` <CGME20180618140856eucas1p281619f9bf003655a3c2eac356216ab25@eucas1p2.samsung.com>
2018-06-18 14:08                       ` [PATCH] regulator: core: Pass max_uV value to regulator_set_voltage_rdev Maciej Purski
2018-07-02  8:05                         ` Tony Lindgren
2018-09-28 20:09                           ` Dmitry Osipenko
2018-09-28 20:09                             ` Dmitry Osipenko
2018-09-28 20:22                             ` Tony Lindgren
2018-09-28 20:36                               ` Dmitry Osipenko
2018-09-28 22:26                               ` Dmitry Osipenko
2018-09-28 22:41                                 ` Tony Lindgren
2018-09-28 23:17                                   ` Dmitry Osipenko
2018-09-28 23:51                                     ` Dmitry Osipenko
2018-09-29  0:27                                       ` Tony Lindgren
2018-09-29  0:44                                         ` Dmitry Osipenko
2018-10-01  7:25                                           ` Maciej Purski [this message]
2018-10-01 13:34                                             ` Dmitry Osipenko
2018-05-30 14:53       ` Regression in Linux next again Naresh Kamboju
2018-05-31  5:44         ` Naresh Kamboju

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='20181001072510eucas1p29a6e504d642d2cac67ed7c3b43f9d53c~Za0l11ceE1868218682eucas1p2w@eucas1p2.samsung.com' \
    --to=m.purski@samsung.com \
    --cc=broonie@kernel.org \
    --cc=ceh@ti.com \
    --cc=digetx@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=m.szyprowski@samsung.com \
    --cc=tony@atomide.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).