From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3358EC64EB8 for ; Tue, 9 Oct 2018 14:40:06 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 00C8D21479 for ; Tue, 9 Oct 2018 14:40:05 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 00C8D21479 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=atomide.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726617AbeJIV5S (ORCPT ); Tue, 9 Oct 2018 17:57:18 -0400 Received: from muru.com ([72.249.23.125]:51800 "EHLO muru.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726393AbeJIV5S (ORCPT ); Tue, 9 Oct 2018 17:57:18 -0400 Received: from atomide.com (localhost [127.0.0.1]) by muru.com (Postfix) with ESMTPS id E702780C3; Tue, 9 Oct 2018 14:40:00 +0000 (UTC) Date: Tue, 9 Oct 2018 07:40:00 -0700 From: Tony Lindgren To: Grygorii Strashko Cc: "David S. Miller" , netdev@vger.kernel.org, Rob Herring , Kishon Vijay Abraham I , Sekhar Nori , linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org, devicetree@vger.kernel.org Subject: Re: [RFC PATCH 02/11] dt-bindings: phy: add cpsw port interface mode selection phy bindings Message-ID: <20181009144000.GL5662@atomide.com> References: <20181008234949.15416-1-grygorii.strashko@ti.com> <20181008234949.15416-3-grygorii.strashko@ti.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20181008234949.15416-3-grygorii.strashko@ti.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Grygorii Strashko [181008 23:54]: > +Examples: > + phy_gmii_sel: phy-gmii-sel { > + compatible = "ti,am3352-phy-gmii-sel"; > + syscon-scm = <&scm_conf>; > + #phy-cells = <2>; > + }; Now that this driver can live in it's proper place in the dts, you may want to consider just using standard reg property for it instead of the syscon-scm. And also get rid of the syscon reads and writes. Regards, Tony