From: Cornelia Huck <cohuck@redhat.com>
To: Sebastian Ott <sebott@linux.ibm.com>
Cc: Halil Pasic <pasic@linux.ibm.com>,
Eric Farman <farman@linux.ibm.com>,
kvm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] s390/cio: make vfio_ccw_io_region static
Date: Mon, 15 Oct 2018 15:39:46 +0200 [thread overview]
Message-ID: <20181015153946.6c9b0e49.cohuck@redhat.com> (raw)
In-Reply-To: <alpine.LFD.2.21.1810151328570.1636@schleppi.aag-de.ibmmobiledemo.com>
On Mon, 15 Oct 2018 13:31:39 +0200 (CEST)
Sebastian Ott <sebott@linux.ibm.com> wrote:
> Fix the following sparse warning:
> drivers/s390/cio/vfio_ccw_drv.c:25:19: warning: symbol 'vfio_ccw_io_region'
> was not declared. Should it be static?
Hm, it seems my workflow needs more static checkers.
>
> Signed-off-by: Sebastian Ott <sebott@linux.ibm.com>
> ---
> drivers/s390/cio/vfio_ccw_drv.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/s390/cio/vfio_ccw_drv.c b/drivers/s390/cio/vfio_ccw_drv.c
> index f47d16b5810b..edbf542d82af 100644
> --- a/drivers/s390/cio/vfio_ccw_drv.c
> +++ b/drivers/s390/cio/vfio_ccw_drv.c
> @@ -22,7 +22,7 @@
> #include "vfio_ccw_private.h"
>
> struct workqueue_struct *vfio_ccw_work_q;
> -struct kmem_cache *vfio_ccw_io_region;
> +static struct kmem_cache *vfio_ccw_io_region;
>
> /*
> * Helpers
Thanks, applied.
prev parent reply other threads:[~2018-10-15 13:39 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-15 11:31 [PATCH] s390/cio: make vfio_ccw_io_region static Sebastian Ott
2018-10-15 13:39 ` Cornelia Huck [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181015153946.6c9b0e49.cohuck@redhat.com \
--to=cohuck@redhat.com \
--cc=farman@linux.ibm.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pasic@linux.ibm.com \
--cc=sebott@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).