Re: [PATCH 3/3] crypto: qce: ice: Add support for Inline Crypto Engine

From: kbuild test robot <lkp@intel.com>
To: AnilKumar Chimata <anilc@codeaurora.org>
Cc: kbuild-all@01.org, andy.gross@linaro.org, david.brown@linaro.org,
	robh+dt@kernel.org, mark.rutland@arm.com,
	herbert@gondor.apana.org.au, davem@davemloft.net,
	linux-soc@vger.kernel.org, devicetree@vger.kernel.org,
	linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org,
	AnilKumar Chimata <anilc@codeaurora.org>
Subject: Re: [PATCH 3/3] crypto: qce: ice: Add support for Inline Crypto Engine
Date: Thu, 18 Oct 2018 19:43:22 +0800	[thread overview]
Message-ID: <201810181902.44DQrfDL%fengguang.wu@intel.com> (raw)
In-Reply-To: <1539789476-6098-4-git-send-email-anilc@codeaurora.org>

[-- Attachment #1: Type: text/plain, Size: 2047 bytes --]

Hi AnilKumar,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on cryptodev/master]
[also build test ERROR on v4.19-rc8 next-20181018]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/AnilKumar-Chimata/firmware-qcom-scm-Update-qcom_scm_call-signature/20181018-182318
base:   https://git.kernel.org/pub/scm/linux/kernel/git/herbert/cryptodev-2.6.git master
config: sh-allmodconfig (attached as .config)
compiler: sh4-linux-gnu-gcc (Debian 7.2.0-11) 7.2.0
reproduce:
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        GCC_VERSION=7.2.0 make.cross ARCH=sh 

All errors (new ones prefixed by >>):

>> drivers/crypto/qce/ice.c:1372:5: error: redefinition of 'qcom_ice_setup_ice_hw'
    int qcom_ice_setup_ice_hw(const char *storage_type, int enable)
        ^~~~~~~~~~~~~~~~~~~~~
   In file included from drivers/crypto/qce/ice.c:25:0:
   include/crypto/ice.h:60:19: note: previous definition of 'qcom_ice_setup_ice_hw' was here
    static inline int qcom_ice_setup_ice_hw(const char *storage_type, int enable)
                      ^~~~~~~~~~~~~~~~~~~~~

vim +/qcom_ice_setup_ice_hw +1372 drivers/crypto/qce/ice.c

  1371	
> 1372	int qcom_ice_setup_ice_hw(const char *storage_type, int enable)
  1373	{
  1374		struct ice_device *ice_dev = NULL;
  1375		int ret = -1;
  1376	
  1377		ice_dev = get_ice_device_from_storage_type(storage_type);
  1378		if (ice_dev == ERR_PTR(-EPROBE_DEFER))
  1379			return -EPROBE_DEFER;
  1380	
  1381		if (!ice_dev)
  1382			return ret;
  1383	
  1384		if (enable)
  1385			return enable_ice_setup(ice_dev);
  1386	
  1387		return disable_ice_setup(ice_dev);
  1388	}
  1389	

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 49518 bytes --]