From: Viresh Kumar <viresh.kumar@linaro.org>
To: Niklas Cassel <niklas.cassel@linaro.org>
Cc: sboyd@kernel.org, andy.gross@linaro.org, ulf.hansson@linaro.org,
collinsd@codeaurora.org, mka@chromium.org, robh@kernel.org,
rnayak@codeaurora.org, devicetree@vger.kernel.org,
linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [RFC PATCH] dt-bindings: opp: Extend qcom-opp bindings with properties needed for CPR
Date: Mon, 22 Oct 2018 11:15:50 +0530 [thread overview]
Message-ID: <20181022054550.zlreptvlqn4z2jtq@vireshk-i7> (raw)
In-Reply-To: <20181015124749.27276-1-niklas.cassel@linaro.org>
On 15-10-18, 14:47, Niklas Cassel wrote:
> Extend qcom-opp bindings with properties needed for Core Power Reduction
> (CPR).
>
> CPR is included in a great variety of Qualcomm SoC, e.g. msm8916 and
> msm8996, and was first introduced in msm8974.
>
> Signed-off-by: Niklas Cassel <niklas.cassel@linaro.org>
> ---
> Hello Rob, Rajendra,
>
> Sorry for not replying sooner.
> Since Rob wanted the binding to be complete before merging,
> this is my proposal to extend the OPP binding with properties
> needed to support CPR (both for msm8916 and msm8996).
> I've discussed the proposal with Viresh, and this proposal
> seems better than what I previously suggested here:
> https://lore.kernel.org/lkml/20181005204424.GA29500@centauri.lan/
>
> .../devicetree/bindings/opp/qcom-opp.txt | 19 +++++++++++++++++++
> 1 file changed, 19 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/opp/qcom-opp.txt b/Documentation/devicetree/bindings/opp/qcom-opp.txt
> index db4d970c7ec7..3ab5dd84de86 100644
> --- a/Documentation/devicetree/bindings/opp/qcom-opp.txt
> +++ b/Documentation/devicetree/bindings/opp/qcom-opp.txt
> @@ -23,3 +23,22 @@ Required properties:
> representing a corner/level that's communicated with a remote microprocessor
> (usually called the RPM) which then translates it into a certain voltage on
> a voltage rail.
> +
> +Optional properties:
> +- opp-hz: Frequency in Hz, expressed as a 64-bit big-endian integer. Even
> + though a power domain doesn't need a opp-hz, there can be devices in the
> + power domain that need to know the highest supported frequency for each
> + corner/level (e.g. CPR), in order to properly initialize the hardware.
> +
> +- qcom,fuse-level: A positive value representing the fuse corner/level
> + associated with this OPP node. Sometimes several corners/levels shares
> + a certain fuse corner/level. A fuse corner/level contains e.g. ref uV,
> + min uV, and max uV.
> +
> +- qcom,fuse-level-<name>: Named qcom,fuse-level property. This is exactly
> + similar to the above qcom,fuse-level property, but allows multiple
> + fuse corners/levels to be provided for the same OPP. At runtime, the
> + platform can pick a <name> and matching qcom,fuse-level-<name> property
> + will be enabled for all OPPs. If the platform doesn't pick a specific
> + <name> or the <name> doesn't match with any qcom,fuse-level-<name>
> + properties, then qcom,fuse-level property shall be used, if present.
LGTM.
--
viresh
next prev parent reply other threads:[~2018-10-22 5:45 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-27 4:52 [PATCH v4 0/6] Add power domain driver for corners on msm8996/sdm845 Rajendra Nayak
2018-06-27 4:52 ` [PATCH v4 1/6] dt-bindings: opp: Introduce qcom-opp bindings Rajendra Nayak
2018-06-27 4:52 ` [PATCH v4 2/6] dt-bindings: power: Add qcom rpm power domain driver bindings Rajendra Nayak
2018-07-03 22:35 ` Rob Herring
2018-07-04 5:57 ` Viresh Kumar
2018-08-30 6:31 ` Rajendra Nayak
2018-09-20 18:51 ` Rob Herring
2018-09-25 10:25 ` Rajendra Nayak
2018-09-25 19:43 ` Rob Herring
2018-10-04 8:36 ` Viresh Kumar
2018-10-04 15:18 ` Rob Herring
2018-10-04 19:17 ` Niklas Cassel
2018-10-04 22:17 ` Rob Herring
2018-10-05 20:44 ` Niklas Cassel
2018-10-15 12:47 ` [RFC PATCH] dt-bindings: opp: Extend qcom-opp bindings with properties needed for CPR Niklas Cassel
2018-10-22 5:45 ` Viresh Kumar [this message]
2018-11-05 23:17 ` Rob Herring
2018-11-09 16:39 ` Niklas Cassel
2018-11-20 4:12 ` Rajendra Nayak
2018-11-20 16:14 ` Niklas Cassel
2018-11-27 5:04 ` Rajendra Nayak
2018-06-27 4:52 ` [PATCH v4 3/6] soc: qcom: rpmpd: Add a Power domain driver to model corners Rajendra Nayak
2018-06-27 4:52 ` [PATCH v4 4/6] soc: qcom: rpmpd: Add support for get/set performance state Rajendra Nayak
2018-06-27 4:52 ` [PATCH v4 5/6] arm64: dts: msm8996: Add rpmpd device node Rajendra Nayak
2018-06-27 4:52 ` [PATCH v4 6/6] soc: qcom: rpmhpd: Add RPMh Power domain driver Rajendra Nayak
2018-08-30 6:35 ` [PATCH v4 0/6] Add power domain driver for corners on msm8996/sdm845 Rajendra Nayak
2018-08-30 8:21 ` Niklas Cassel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181022054550.zlreptvlqn4z2jtq@vireshk-i7 \
--to=viresh.kumar@linaro.org \
--cc=andy.gross@linaro.org \
--cc=collinsd@codeaurora.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mka@chromium.org \
--cc=niklas.cassel@linaro.org \
--cc=rnayak@codeaurora.org \
--cc=robh@kernel.org \
--cc=sboyd@kernel.org \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).