From: Maxime Ripard <maxime.ripard@bootlin.com>
To: Paul Kocialkowski <contact@paulk.fr>
Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>, Chen-Yu Tsai <wens@csie.org>,
Thierry Reding <thierry.reding@gmail.com>,
David Airlie <airlied@linux.ie>,
linux-sunxi@googlegroups.com,
Mark Van den Borre <mark@fosdem.org>,
Gerry Demaret <gerry@fosdem.org>, Luc Verhaegen <libv@skynet.be>
Subject: Re: [PATCH 2/4] drm/panel: simple: Add support for the Lemaker BL035 3.5" LCD
Date: Wed, 24 Oct 2018 17:57:59 +0100 [thread overview]
Message-ID: <20181024165759.k6cnxyzgpiiuaigs@flea> (raw)
In-Reply-To: <30178c8b263656a9c285e45c78e1908927c99c48.camel@paulk.fr>
On Tue, Oct 23, 2018 at 12:08:17PM +0200, Paul Kocialkowski wrote:
> Hi,
>
> Le mercredi 10 octobre 2018 à 16:58 +0200, Maxime Ripard a écrit :
> > On Wed, Oct 10, 2018 at 01:41:32PM +0200, Paul Kocialkowski wrote:
> > > This adds support for the 3.5" LCD panel from Lemaker, sold for use with
> > > BananaPi boards. It comes with a 24-bit RGB888 parallel interface and
> > > requires an active-low DE signal
> > >
> > > Signed-off-by: Paul Kocialkowski <contact@paulk.fr>
> > > ---
> > > drivers/gpu/drm/panel/panel-simple.c | 27 +++++++++++++++++++++++++++
> > > 1 file changed, 27 insertions(+)
> > >
> > > diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c
> > > index 97964f7f2ace..229080fcf65e 100644
> > > --- a/drivers/gpu/drm/panel/panel-simple.c
> > > +++ b/drivers/gpu/drm/panel/panel-simple.c
> > > @@ -1461,6 +1461,30 @@ static const struct panel_desc kyo_tcg121xglp = {
> > > .bus_format = MEDIA_BUS_FMT_RGB888_1X7X4_SPWG,
> > > };
> > >
> > > +static const struct drm_display_mode lemaker_bl035_mode = {
> > > + .clock = 7000,
> > > + .hdisplay = 320,
> > > + .hsync_start = 320 + 20,
> > > + .hsync_end = 320 + 20 + 30,
> > > + .htotal = 320 + 20 + 30 + 38,
> > > + .vdisplay = 240,
> > > + .vsync_start = 240 + 4,
> > > + .vsync_end = 240 + 4 + 3,
> > > + .vtotal = 240 + 4 + 3 + 15,
> > > + .vrefresh = 60,
> > > +};
> > > +
> > > +static const struct panel_desc lemaker_bl035 = {
> > > + .modes = &lemaker_bl035_mode,
> > > + .num_modes = 1,
> > > + .size = {
> > > + .width = 70,
> > > + .height = 52,
> > > + },
> > > + .bus_format = MEDIA_BUS_FMT_RGB888_1X24,
> > > + .bus_flags = DRM_BUS_FLAG_DE_LOW,
> > > +};
> > > +
> > > static const struct drm_display_mode lg_lb070wv8_mode = {
> > > .clock = 33246,
> > > .hdisplay = 800,
> > > @@ -2456,6 +2480,9 @@ static const struct of_device_id platform_of_match[] = {
> > > }, {
> > > .compatible = "kyo,tcg121xglp",
> > > .data = &kyo_tcg121xglp,
> > > + }, {
> > > + .compatible = "lemaker,bl035",
> > > + .data = &lemaker_bl035,
> >
> > You should document that new compatible. Also, where is this name
> > coming from? Is it the name it's sold under? something you came up
> > with?
>
> Oh right, I forgot to document the compatible (and add the new vendor).
>
> The name "BL035" comes from the PCB itself, where it reads "BL035-RGB-
> 002" under the Lemaker logo. I went for "BL035" to keep it short.
>
> The latter part seems to be the PCB revision. According to the fex
> files[0], the timings are the same for all the screens of the same size
> (regardless of revision), so that revision probably shouldn't be in the
> panel name.
>
> As for the "RGB" part, Lemaker only makes 3.5 and 5 inch LCDs with a
> parallel RGB interface and 7 and 10.1 inch LCDs with LVDS, so there is
> no ambiguity for now.
>
> Do you think it makes sense to keep that part in the panel name
> nevertheless?
I'd just put the full reference, to be on the safe side.
Thanks!
Maxime
--
Maxime Ripard, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
next prev parent reply other threads:[~2018-10-24 16:58 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-10 11:41 [PATCH 1/4] drm/sun4i: tcon: Support an active-low DE signal with RGB interface Paul Kocialkowski
2018-10-10 11:41 ` [PATCH 2/4] drm/panel: simple: Add support for the Lemaker BL035 3.5" LCD Paul Kocialkowski
2018-10-10 14:58 ` Maxime Ripard
2018-10-23 10:08 ` Paul Kocialkowski
2018-10-24 16:57 ` Maxime Ripard [this message]
2018-10-10 11:41 ` [PATCH 3/4] ARM: dts: sun7i: Add pinmux configuration for LCD0 RGB888 pins Paul Kocialkowski
2018-10-10 14:59 ` Maxime Ripard
2018-10-10 11:41 ` [PATCH NOT FOR MERGE 4/4] ARM: dts: sun7i-a20-bananapi: Add bindings for the BL035 3.5" LCD Paul Kocialkowski
2018-10-10 14:57 ` [PATCH 1/4] drm/sun4i: tcon: Support an active-low DE signal with RGB interface Maxime Ripard
2018-10-23 9:33 ` Paul Kocialkowski
2018-10-24 16:47 ` Maxime Ripard
2018-10-24 17:24 ` Paul Kocialkowski
2018-10-26 11:20 ` Maxime Ripard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181024165759.k6cnxyzgpiiuaigs@flea \
--to=maxime.ripard@bootlin.com \
--cc=airlied@linux.ie \
--cc=contact@paulk.fr \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=gerry@fosdem.org \
--cc=libv@skynet.be \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sunxi@googlegroups.com \
--cc=mark.rutland@arm.com \
--cc=mark@fosdem.org \
--cc=robh+dt@kernel.org \
--cc=thierry.reding@gmail.com \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).