Hi Laurence, Thank you for the patch! Yet something to improve: [auto build test ERROR on linux-sof-driver/master] [also build test ERROR on v4.19 next-20181019] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Laurence-Oberman/V3-init-main-c-Enable-watchdog_thresh-control-from-kernel-line/20181025-015902 base: https://github.com/thesofproject/linux master config: i386-randconfig-s1-201842 (attached as .config) compiler: gcc-6 (Debian 6.4.0-9) 6.4.0 20171026 reproduce: # save the attached .config to linux build tree make ARCH=i386 All errors (new ones prefixed by >>): init/main.c: In function 'is_watchdog_thresh_setup': >> init/main.c:1037:20: error: 'watchdog_thresh' undeclared (first use in this function) get_option(&str, &watchdog_thresh); ^~~~~~~~~~~~~~~ init/main.c:1037:20: note: each undeclared identifier is reported only once for each function it appears in vim +/watchdog_thresh +1037 init/main.c 1033 1034 static int __init 1035 is_watchdog_thresh_setup(char *str) 1036 { > 1037 get_option(&str, &watchdog_thresh); 1038 return 1; 1039 } 1040 __setup("watchdog_thresh=", is_watchdog_thresh_setup); 1041 1042 --- 0-DAY kernel test infrastructure Open Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation