From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,USER_AGENT_NEOMUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B11D4C46475 for ; Thu, 25 Oct 2018 08:25:26 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 6E75B204FD for ; Thu, 25 Oct 2018 08:25:26 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6E75B204FD Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=netfilter.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727333AbeJYQ5G (ORCPT ); Thu, 25 Oct 2018 12:57:06 -0400 Received: from mail.us.es ([193.147.175.20]:56972 "EHLO mail.us.es" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726538AbeJYQ5F (ORCPT ); Thu, 25 Oct 2018 12:57:05 -0400 Received: from antivirus1-rhel7.int (unknown [192.168.2.11]) by mail.us.es (Postfix) with ESMTP id B8B2514121 for ; Thu, 25 Oct 2018 10:25:20 +0200 (CEST) Received: from antivirus1-rhel7.int (localhost [127.0.0.1]) by antivirus1-rhel7.int (Postfix) with ESMTP id A6C40DA542 for ; Thu, 25 Oct 2018 10:25:20 +0200 (CEST) Received: by antivirus1-rhel7.int (Postfix, from userid 99) id 998FBDA7AD; Thu, 25 Oct 2018 10:25:20 +0200 (CEST) Received: from antivirus1-rhel7.int (localhost [127.0.0.1]) by antivirus1-rhel7.int (Postfix) with ESMTP id B1E0BDA7A1; Thu, 25 Oct 2018 10:25:18 +0200 (CEST) Received: from 192.168.1.97 (192.168.1.97) by antivirus1-rhel7.int (F-Secure/fsigk_smtp/550/antivirus1-rhel7.int); Thu, 25 Oct 2018 10:25:18 +0200 (CEST) X-Virus-Status: clean(F-Secure/fsigk_smtp/550/antivirus1-rhel7.int) Received: from us.es (sys.soleta.eu [212.170.55.40]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: 1984lsi) by entrada.int (Postfix) with ESMTPSA id 901924265A32; Thu, 25 Oct 2018 10:25:18 +0200 (CEST) Date: Thu, 25 Oct 2018 10:25:18 +0200 X-SMTPAUTHUS: auth mail.us.es From: Pablo Neira Ayuso To: Jiri Slaby Cc: kadlec@blackhole.kfki.hu, fw@strlen.de, netfilter-devel@vger.kernel.org, coreteam@netfilter.org, linux-kernel@vger.kernel.org, =?iso-8859-1?Q?M=E1t=E9?= Eckl Subject: Re: [PATCH] netfilter: bridge: define INT_MIN & INT_MAX in userspace Message-ID: <20181025082518.yxvnoxfyr7qqpxyh@salvia> References: <20181024115403.3938-1-jslaby@suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20181024115403.3938-1-jslaby@suse.cz> User-Agent: NeoMutt/20170113 (1.7.2) X-Virus-Scanned: ClamAV using ClamSMTP Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Oct 24, 2018 at 01:54:03PM +0200, Jiri Slaby wrote: > With 4.19, programs like ebtables fail to build when they include > "linux/netfilter_bridge.h". It is caused by commit 94276fa8a2a4 which > added a use of INT_MIN and INT_MAX to the header: > : In file included from /usr/include/linux/netfilter_bridge/ebtables.h:18, > : from include/ebtables_u.h:28, > : from communication.c:23: > : /usr/include/linux/netfilter_bridge.h:30:20: error: 'INT_MIN' undeclared here (not in a function) > : NF_BR_PRI_FIRST = INT_MIN, > : ^~~~~~~ > > Define these constants by including "limits.h" when !__KERNEL__ (the > same way as for other netfilter_* headers). Applied, thanks.