From: Himanshu Jha <himanshujha199640@gmail.com>
To: Renato Lui Geh <renatogeh@gmail.com>
Cc: Lars-Peter Clausen <lars@metafoo.de>,
Michael.Hennerich@analog.com, jic23@kernel.org, knaack.h@gmx.de,
pmeerw@pmeerw.net, gregkh@linuxfoundation.org,
alexandru.Ardelean@analog.com, stefan.popa@analog.com,
giuliano.belinassi@usp.br, linux-iio@vger.kernel.org,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org,
kernel-usp@googlegroups.com
Subject: Re: [PATCH] staging: iio: ad7780: update voltage on read
Date: Thu, 25 Oct 2018 20:25:20 +0530 [thread overview]
Message-ID: <20181025145520.GA16950@himanshu-Vostro-3559> (raw)
In-Reply-To: <20181025142635.3apgyaxzhr73kehc@renatolg>
On Thu, Oct 25, 2018 at 11:26:36AM -0300, Renato Lui Geh wrote:
> Hi,
>
> Thanks for the quick review. :)
>
> > But please create one patch per issue and do not put unrelated changes into
> > the same patch.
>
> Should I resend this patch as a patchset containing the two changes?
Yes! "One patch per change policy"
> > Also your mail client seems to have replaced tabs in the patch with spaces,
> > this means the patch will not apply cleanly. Check the
> > Documentation/email-clients.txt file for some hints how to configure your
> > mail client so it will not break patches.
>
> From my end my original email patch appears to have tabs instead of
> spaces. I redownloaded my email and vim shows that the indentation has
> the ^I tab characters. But when downloading your reply it was converted
> to spaces. Am I missing something?
Your patch applies fine.
I think the problem is on Lars end due to Thunderbird.
In the meantime, you can verify the patch using:
$ git am <your_patch.patch>
Also, you can try to use `git send-email` to send patches.
--
Himanshu Jha
Undergraduate Student
Department of Electronics & Communication
Guru Tegh Bahadur Institute of Technology
next prev parent reply other threads:[~2018-10-25 14:55 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-25 13:32 [PATCH] staging: iio: ad7780: update voltage on read Renato Lui Geh
2018-10-25 13:38 ` Lars-Peter Clausen
2018-10-25 14:26 ` Renato Lui Geh
2018-10-25 14:55 ` Himanshu Jha [this message]
2018-10-25 16:01 ` Lars-Peter Clausen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181025145520.GA16950@himanshu-Vostro-3559 \
--to=himanshujha199640@gmail.com \
--cc=Michael.Hennerich@analog.com \
--cc=alexandru.Ardelean@analog.com \
--cc=devel@driverdev.osuosl.org \
--cc=giuliano.belinassi@usp.br \
--cc=gregkh@linuxfoundation.org \
--cc=jic23@kernel.org \
--cc=kernel-usp@googlegroups.com \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pmeerw@pmeerw.net \
--cc=renatogeh@gmail.com \
--cc=stefan.popa@analog.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).